help on min and max(debugging)

[kateng32]

cant seem to figure out whats missing

  #include<iostream>

using namespace std;

int main()

{
    int min, max, ave, sum, a, b, c;
    
    cout<<"Enter 3 numbers: \n";
    cin>>a;
    cin>>b;
    cin>>c;
   
     if(a > b) && (a > c)
     
     cout<<a<< "is the largest number \n";  
     
     else
     {
         if(b > a) && (b > c)
         
         cout<<b<< "is the largest number \n";
         
         else
         
         cout<<c<< "is the largest number \n";
     }    
         
         if(a < b) && (a < c)
         
         cout<<a<< " is the minimum number \n";
         
         else
         {
             if(b < a) && (b < c)
             
             cout<<b<< "is the minimum number \n";
             
             else
             
             cout<<c<< "is the minimum number \n";
         }
    

    sum = a + b + c;
    ave = sum / 3;
    
    cout<<"The average of the 3 numbers is "<<ave<<" \n";
    
    system("pause");
    
    return 0;
    
}    
    
    
    

[Zhuge]

You need parentheses around your conditions.

Also, you can simply write "else if" instead of entering an else block then immediately following with an if.

[Albo Coder]

 #include<iostream>

using namespace std;

int main()

{
    int min, max, ave, sum, a, array[a];
    
    for(a=0;a<3;a++)
    {
       cout << "Enter number " << a+1 << " :";
       cin >> array[a];
    }
    
    for(int x=0; x<2; x++)
    {
            for(int y=x; y<3; y++)
            {
                 if(array[x]>array[y])
                 {
                     int temporal;
                     array[x]=temporal; //I swap the value of array[a] with array[b] using another parameter
                     array[x]=array[y];
                     array[y]=temporal;
                 }
            }        
    }
    //code added by me to check if the two loops worked well
    min=array[0];
    max=array[2];
    cout << "The smallest number is: " << min << endl;
    cout << "The gratest number is: " << max << endl;
    
    
    
    sum = array[0]+array[1]+array[2];
    ave = sum / 3;
    cout<<"The average of the 3 numbers is "<<ave<<" \n";
    system("pause");
    
    return 0;
    
}    

[Albo Coder]

to understand the two loops function go here
http://www.youtube.com/watch?v=_SH8_vOcvLg
and here
http://www.youtube.com/watch?v=AoVs1s0kfhE

[kateng32]

i think else if needs a condition thats what i know.

and where is the parentheses needed?

ok ill figure it out thanks anyway

[Albo Coder]

   if((a > b) && (a > c))
     {
     cout<<a<< "is the largest number \n";  
     }
     else if((b > a) && (b > c))
         
        { cout<<b<< "is the largest number \n";}
         
         else
         
         {cout<<c<< "is the largest number \n";}
    

This is for max...

REMEMBER: ((b > a) && (b > c))

you can use "if" then "else if" and then "else"...


The "else" excludes even the first condition("else") even the second condition ("else if")

[Albo Coder]

Here your program reconstructed lines...

if((a > b) && (a > c))
     {
     cout<<a<< " is the largest number \n";  
     }
     else if((b > a) && (b > c))
         
        {
                 cout<<b<< " is the largest number \n";
                 }
         
         else
         
         {
             cout<<c<< " is the largest number \n";
             }
    
    
    
    
    
    
    
   if((a < b) && (a < c))
     {
     cout<<a<< " is the smallest number \n";  
     }
     else if((b < a) && (b < c))
         
        {
                 cout<<b<< " is the smallest number \n";
                 }
         
         else
         
         {
             cout<<c<< " is the smallest number \n";
             }

[Albo Coder]

Hope it helps

[kateng32]

wow that was simple as hell thanks

[Albo Coder]

NP... I guess It is solved...