Max and min of numbers input by the user

[jkevin]

I am trying ti write a program that displays the maximum and the minimum of different numbers input by the user. I got the max part right but something seems wrong with my minimum. here is my code.

#include<iostream>

using namespace std;

int main()
{
int num,max = 0,min = 0;
char choice;
do
{
cout <<"Enter a number: ";
cin >> num;

cout <<"Do you want to continue?: ";
cin >> choice;

if(max < num)
max = num;
else if(min > num)
min = num;
}while(choice == 'y');

cout <<"The maximum is "<< max << endl;
cout <<"The minimum is "<< min << endl;

cin.ignore();
cin.get();

return 0;
}

[vlad from moscow]

#include <iostream>

using namespace std;

int main()
{
   bool empty = true;
   int max, min;

   char choice;
   do
   {
      cout << "Enter a number: ";
   
      int num;
      cin >> num;

      if ( empty )
      {
         empty = false;
         min = num;
         max = num;
      }
      else if ( max < num )
      {
         max = num;
      }
      else if ( num < min )
      {
         min = num;
      }

      cout << "Do you want to continue?: ";
      cin >> choice;
   } while ( choice == 'y' || choice == 'Y' );

   if ( !empty )
   {
      cout << "The maximum is " << max << endl;
      cout << "The minimum  is " << min  << endl;
   }

   cin.ignore();
   cin.get();

   return 0;
}

[jkevin]

thanks can you explain the usage of bool empty???

[vlad from moscow]

It is the professor who will explain you. As for me I will say simply do at least something yourself.

[jkevin]

I am learning C++ by myself, there is no professor around me unfortunately I showed you what I did though.

[a k n]

The problem with your code is that you initialised min with 0 , and zero is always smaller than any positive number so as long as you input any positive number (0 < num) will evaluate to true.
A rather cheap way to make your logic work is to initialize you min with ( (1 << sizeof(int)*4) - 1 ) .On a typical 32-bit system it will evaluate to (1 << 16) i.e. 2 tothe 16 - 1.
Better yet use vlad ' s way which checks whether you are inputing the first time.
Hope that helps.

[geezle86]

"empty" means no input from user.

I am the professor, yeah :D

[aidyszh]

If you want to compare the numbers continuously, but not in pair, just remove the condition in the else branch.

if(max < num)
max = num;
else // if(min > num)
min = num;