Stack problem

[Ltp]

#include <iostream>
using namespace std;
class stack{
private:
	int *st;
	int s;
	int top;
public:
	stack(int);
	void set_values();
	void get_values();
	void push(int);
};

stack::stack(int x)
{
	s=x;
	top=0;
	st=new int[s];
}

void stack::set_values()
{
	for(int i=0; i<s; ++i)
		st[i]=rand()%10;
}
void stack::get_values()
{
	for(int i=0; i<s; ++i)
		cout<<st[i]<<endl;
}

void stack::push(int x)
{
	st[++top]=x;
}


int main()
{
	stack sc(10);
	
	sc.set_values();
	sc.get_values();
	sc.push(?);

	system ("Pause");
	return 0;
}

sc.push(?);

What should I put here as argument?

[ngopza]

fist of all srand was not declared, and what do you expect the main to do there, cause clearly it does nothing

[ngopza]

include the cstdlib header and call the functions in your main.then everything would be fine

[coder777]

Whats wrong here?

That depends on what do you expect.

Currently the only problem I see is a memory leak.

[ngopza]

Are you sure.Even though everything is done in the main.I used valgrind and it shows no memory leak.although he should implement a destructor , but why is the memory deallocated Coder777

[ngopza]

even used gdb....still no leaks

[Ltp]

The problem is, its doesnt display the desired outputs. In fact doesnt display anything.
I need the random values..

[ngopza]

Try this

#include <iostream>
#include <cstdlib>
using namespace std;
class stack{
private:
int *st;
int s;
int top;
public:
stack(int);
~stack();
void set_values();
void get_values();
};

stack::stack(int x)
{
s=x;
top=0;
st=new int[s];
}
stack :: ~stack()
{
delete [] st;
}
void stack::set_values()
{
for(int i=0; i<s; ++i)
st[i]=rand()%10;
}
void stack::get_values()
{
for(int i=0; i<s; ++i)
cout<<st[i]<<endl;
}


int main()
{
stack sc(10);

sc.set_values();
sc.get_values();
return 0;
}

[ngopza]

But the randomm numbers will always be the same.If thats the case then fine.If not consider srand and time functions

[Ltp]

~stack();

Whats this? Can you explain it simply?

[ngopza]

its a destructor.to deallocate memory from the heap that you allocated.

[Ltp]

Ya I can use srand; bt thats not a big problem, dude.
The problem is, the output is with garbage values..

[Ltp]

Oh ya I got the random values. Thanks a lot. But whats about this:

~stack();

and this:

stack :: ~stack()
{
delete [] st;
}

[Ltp]

Got it. Thanks..