Copy contructor with argument

[irfan2266]

I am doing some mistake in creating copy constructor with argument. Please help me to resolve the issue.

I wanted to have a copy of "oldClientInfo" object in "clientInfo". Both of type ClientInfo. But the values are not reflecting in object after using copy constructor

// Normal constructor
ClientInfo::ClientInfo(Listener& listener)
:msgId(0),
pId(0),
timeout(0),
gracePeriod(0),
eventSeverity(0),
timer(listener)
{
}

// usage 
Listener& listener;
ClientInfo clientInfo(listener);

/******************************************/
PROBLEM in copy constructor:
ClientInfo::ClientInfo(ClientInfo& clientInfo, Listener& listener)
:timer(listener)
{
    msgId = clientInfo.msgId;
    pId = clientInfo.pId;
    timeout = clientInfo.timeout;
    gracePeriod = clientInfo.gracePeriod;
    eventSeverity = clientInfo.eventSeverity;
}

// usage
Listener& listener;
ClientInfo clientInfo(oldClientInfo, listener);
/******************************************/

[keskiverto]

In what way are they 'off'?

How about normal copy construction and then update of the timer?

What are those uninitialized Listener references anyway?

[irfan2266]

Listener& listener;

Listener listener; // It not an reference my typo error

timeout callback function is implemented when the timer expires.

I AM VERY SURE THERE IS SOME PROBLEM BECAUSE OF copying TIMER.
When timer expires callback of listener is called.

And i need a new listener passed to copy constructor.

[keskiverto]

What does this have to do with ClientInfo? Constructor of 'timer' and nature of Listener are much more involved (and unknown to us).

[irfan2266]

Hi freind i think the definition is correct there was some basic mistake i was doing in my code. Was passing a local object clientInfo and storing the pointer.

Please just confirm the syntax i have written for copy constructor is correct.

I would be closing the post after your reply 2 solved :)

[keskiverto]

It is ok, but not really a "copy", because timer won't be a copy of clientInfo.timer.

See http://www.cplusplus.com/articles/y8hv0pDG/
for the syntax used by compiler-generated copy constructor.