Cant get functions to work

[Khillz3000]

I have 2 functions that I cant seem to get to work together. One sets up an aray of numbers and shuffles the numbers. The other one pulls the numbers a number in order of index each time its called. (basically the first time its called it returns the number in index 0. The second time its called it returns the number in index 1 and so on) I (with some help) got the functions to work when written as one function, however the assignment requires that they work as two separate functions, though they can work together, if that makes sense. Anyway the errors I keep getting are :

error C2109: subscript requires array or pointer type
IntelliSense: expression must be a pointer to a complete object type

These are both on line 37. I'm not sure what to do to fix it. I'm still very new to programing. Please help.

  #include "stdafx.h"
#include <iostream>
#include <cstdlib>       
#include <ctime>          


using std::cout; using std::endl;
using std::cin;



int deck();
int getcard();

int deck()     //sets up the deck and shuffles it
{
	int deck[52]={2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,8,8,8,8,9,9,9,9,10,10,10,10,10,10,10,10,10,10,10,10,
		10,10,10,10,11,11,11,11};
	int i,p,temp;

		srand(time(NULL));			// seed for random function

	for (p=0; p<520; p++){
		int k = rand()%52;
		int l = rand()%52;
			temp=deck[k];
			deck[k]=deck[l];
			deck[l]=temp;
		return(deck[i]);
}
}

	int getCardCalled=-1;       //deal function, incriments every time a card is drawn
	int getcard() {
		++getCardCalled;
		deck();
	return(deck[getCardCalled]);
}


	int main()	//main is for testing to see if the two functions work together			
{
			cout<<endl;cout<<endl;
	int i;
	
	for (i=0; i<52; i++){        //to print out shuffled deck
		cout<<deck()<<" "; 
}
			cout<<endl;cout<<endl;
		cout<<getcard();		//to see if it increments correctly
			cout<<endl;
		cout<<getcard();
			cout<<endl;
		cout<<getcard();
			cout<<endl;
		cout<<getcard();
			cout<<endl;cout<<endl;

		cout<<" Blackjack"<<endl;
			cout<<endl;cout<<endl;
}

[Ispil]

The issue is that the array that you're referring to is a variable in the function deck. It is not available in getcard.

[Khillz3000]

How would I define the array in getcard so that it can use the values in the array?

[Chervil]

You need to define the array in function main() and then pass it as a parameter to the other functions which need it.

#include <iostream>
#include <cstdlib>
#include <ctime>

using std::cout; using std::endl;
using std::cin; using std::time;
using std::srand; using std::rand;

void setup(int deck[]);

int getcard(int deck[]);

int main()
{
    int deck[52];    // define the deck here
    setup(deck);     // pass it as a parameter to the other functions

    cout << endl << endl;

    // Print out shuffled deck
    for (int i=0; i<52; i++)
    {
        cout << deck[i] << " ";
    }
    cout << endl;

}

void setup(int deck[] ) // sets up the deck and shuffles it
{
    // initialise the local array
    int cards[52] =
        {2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,8,8,8,8,9,9,9,9,
         10,10,10,10,10,10,10,10,10,10,10,10,10,10,10,10,11,11,11,11};

    // copy from local array to main deck
    for (int i=0; i<52; i++)
         deck[i] = cards[i];

    // display it (optional)
    for (int i=0; i<52; i++)
        cout << deck[i] << " ";
    cout << endl;

    srand(time(NULL));			// seed for random function

    // Shuffle the deck
    for (int p=0; p<520; p++)
    {
        int k = rand()%52;
        int l = rand()%52;
        int temp    = deck[k];
        deck[k] = deck[l];
        deck[l] = temp;
    }
}

[MikeyBoy]

Please don't spam the forum with multiple threads for the same question. This had already been answered in your previous thread at:

www.cplusplus.com/forum/beginner/112317/