Stupid problem with variables

[moreme]

Hey Guys!!!

I was writting this code and now there is a very simple problem which is eating my brain cause i dont know what the hell is wrong with the code. when you compile and run the code choose option number 1, then enter your data, and exit the program. the output will be stored in a file called info.txt. the problem is that account holder name will not be stored and exactly was has been entered for account type will be stored as account holder name too and i really dont know why.

thanks in advance.

  #include<iostream>
#include<cstdlib>
#include<fstream>
#include<cctype>
#include<cstdio>
#include<cstring>

using namespace std;

class Bank
{
public:
    void new_account();
    void deposit_amount();
    void withdraw_amount();
    void balance();
    void close_account();
    void modify_account();

    int acc_number_f();
    char acc_holder_name_f();
    char acc_type_f();
    int inital_amount_f();
    int total_amount_f();

private:
    int acc_number;
    char acc_holder_name[50];
    char acc_type;
    int inital_amount;
    int total_amount;

};
int main_menu();
/*----------------------------------------------------------
//--------------------MAIN FUNCTION()-----------------------
-----------------------------------------------------------*/
int main()
{
int chosen_number;
char ans;
start_over:
chosen_number=main_menu();
Bank cus_obj;
if(chosen_number=='1')
{
    system("cls");
    cus_obj.new_account();
}
else if(chosen_number=='4')
{
    system("cls");
    cus_obj.balance();
}
else
{
    return 0;
}
cout<<"do you want to continue? ";
cin>>ans;
if (ans=='y')
{
    system("cls");
    goto start_over;
}
else
{
system("cls");
cout<<"Thanks for Banking with us!!!";
}

return 0;
}
//-----------------MAIN MENU()-------------------------
int main_menu()
{
    char opt;
    cout<<"-------HPRO. Banking system---------\n";
    cout<<"1.   New account"<<endl;
    cout<<"2.   Deposit amount"<<endl;
    cout<<"3.   Withdraw amount"<<endl;
    cout<<"4.   Balance Inquery"<<endl;
    cout<<"5.   All Acount Hoedr List"<<endl;
    cout<<"6.   Close an account"<<endl;
    cout<<"7.   Modify and account"<<endl;
    cout<<"8.   Exit"<<endl;
    cout<<"Choose a number between 1 and 8: ";
    cin>>opt;
    if (opt>='1' && opt<='8')
    {
        return opt;
    }
    else
    {
        system("cls");
        cout<<"!!!!!!!!!!!!Wrong selection, Please choose again\n";
        main_menu();
    }
}
//-----------------------------------------------------------
void Bank::new_account()
{
    cout<<"***Creating new Account***\n";
    cout<<"Enter the account number: ";
    cin>>acc_number;
    cout<<"Enter the account holder's name: ";
    cin.ignore();
    gets(acc_holder_name);
    cout<<"Enter the account type(s/c): ";
    cin>>acc_type;
    cout<<"Initial amount: ";
    cin>>inital_amount;


    ofstream myfile;
    myfile.open("info.txt", ios::out | ios::app);
    if(myfile.is_open())
    {
        myfile<<acc_number_f()<<"\t"<<acc_holder_name_f()<<"\t"<<acc_type_f()<<"\t"<<inital_amount_f()<<endl;
        myfile.close();
    }
    else
    {
        cout<<"Error opening file, contact the administrator\n";
    }
}
/*----------------------------------------------------------
                BALANCE() FUNCTION
-----------------------------------------------------------*/
void Bank::balance()
{
    char input;
    ifstream myfile;
    myfile.open("info.txt", ios::in);
    while(!myfile.eof())
    {
        myfile.get(input);
        cout<<input;
    }
    myfile.close();

}
int Bank::acc_number_f()
{
    return acc_number;
}
char Bank::acc_holder_name_f()
{
    return acc_holder_name[50];
}
char Bank::acc_type_f()
{
    return acc_type;
}
int Bank::inital_amount_f()
{
    return inital_amount;
}
int Bank::total_amount_f()
{
    return total_amount;
}

[coder777]

The problem is this:

char Bank::acc_holder_name_f() // you return only a character
{
    return acc_holder_name[50]; // 50 is out of bounds
        // 49 is the last possible index because it starts with 0
}

what you want is this:

const char *Bank::acc_holder_name_f()
{
    return acc_holder_name; // This returns the string
}

[moreme]

Coder777 thanks for your response, i did what you said but the program gets error and does not get compiled.

[MikeyBoy]

I know playing "guess-the-error" is a lot of fun, but some of us are kinda busy. Perhaps you could, y'know, actually tell us what the error message is, rather than making us guess?

EDIT: Did you remember to change the method declaration in your class definition?

[zb0S216C]

You can return an array by reference:

char ( &GetCharArray( ) )[50]
{
    return( SomeArray );
}

_Wazzak