Hot Drink Menu

[blazemadej]

Stuck in an endless loop, It builds perfectly and I cannot pinpoint what is wrong.

  // This program uses a do-while loop in a menu.
#include <iostream>
#include <iomanip>
using namespace std;

int main()
{
   // Constants for menu choices
   const int COFFEE_CHOICE = 'A',
             TEA_CHOICE = 'B',
             HOT_CHOCOLATE_CHOICE = 'C',
             CAPPUCCINO_CHOICE = 'D',
             EXIT_CHOICE = 'E';

   // Constants drink prices
   const double COFFEE = 1.00,
                TEA = 0.75,
                HOT_CHOCOLATE = 1.25,
                CAPPUCCINO= 2.50;

   // Variables
   int choice;       // Menu choice
   int number;       // Number of cups
   double charges;   // Monthly charges

   // Output formatting.
   cout << fixed << showpoint << setprecision(2);

   do
   {
      // Display the drink menu.
      cout << "\n\t\tHot Beverage Menu\n\n"
           << "A. Coffee           $1.00\n"
           << "B. Tea              $ .75\n"
           << "C. C. Hot Chocolate $1.25\n"
           << "D. Cappuccino       $2.50\n"
           << "E. Exit\n\n"
           << "Please enter your choice: ";
      cin >> choice;

      // Validate the menu selection.
      while (choice < COFFEE_CHOICE || choice > EXIT_CHOICE)
      {
         cout << "Please enter a valid selection: ";
         cin >> choice;
      }

      // Validate and process the user's choice.
      if (choice != EXIT_CHOICE)
      {
         // Get the number of cups.
         cout << "How many cups would you like? ";
         cin >> number;

         // Respond to menu selection.
         switch (choice)
         {
            case COFFEE_CHOICE:
                charges = number * COFFEE;
                break;
            case TEA_CHOICE:
                charges = number * TEA;
                break;
            case HOT_CHOCOLATE_CHOICE:
                charges = number * HOT_CHOCOLATE;
                break;
            case CAPPUCCINO_CHOICE:
                charges = number * CAPPUCCINO;
         }

         // Display the tolal charges.
         cout << "Your grand total is $" << charges << endl;
      }
   } while (choice != EXIT_CHOICE);
   return 0;
}

[MikeyBoy]

My guess would be that it's because you're declaring choice as an int. This means that cin will consider 'E' invalid input for the variable.

Try declaring it as a char. After all, that's what you're using it to store.

[error1f1f]

In addition to what Mikey said; you should probably add a default case statement.

[blazemadej]

Thank you two so much for your help. I really appreciate it.

[MikeyBoy]

You're welcome! Glad I could help :)

[TheIdeasMan]

Just going to add an extra cent worth.

It is good practice to declare each variable on it's own line. Your code looks innocent enough, but I have a vague idea that the qualifiers like const only apply to the first variable & not to the rest of them. I don't have a copy of the standard with me at the moment, maybe someone could verify this?

Even if I am wrong, it is still good practice to declare & initialise 1 variable per line.