vowel & consonant counting

[chofs]

okay am writing a code that reads the number of vowels and consonant...code is running only for counting vowels n not consonants....made separate loops for each,,,,can someone help me count also the consonants coz am using != to vowels to count the consonats...plzzzzzzzzzzzzzzzzz help....any help will be highly appreciated......

#include <iostream>
#include <string>

using namespace std;

int main()
{
  string input;
  cout<<"please type in a sentence"<<endl;
  getline(cin,input);

  int numofvowel=0;
  int numofconsonant=0;

  for(unsigned int i=0;i<input.length();i++)
  {
      if(input.at(i)=='a')
      {
          numofvowel++;

      }
      else if(input.at(i)=='e')
      {
         numofvowel++;
      }
      else if(input.at(i)=='i')
      {
         numofvowel++;
      }
      else if(input.at(i)=='o')
      {
        numofvowel++;
      }
      else if(input.at(i)=='u')
      {
        numofvowel++;
      }
  }

  for(unsigned int j=0;j<input.length();j++)
  {
       if(input.at(j)=!'a')
      {
          numofconsonant++;

      }
      else if(input.at(j)=!'e')
      {
         numofconsonant++;
      }
      else if(input.at(j)=!'i')
      {
         numofconsonant++;
      }
      else if(input.at(j)=!'o')
      {
        numofconsonant++;
      }
      else if(input.at(j)=!'u')
      {
        numofconsonant++;
      }
  }
  cout<<"number of vowels: "<<numofvowel<<endl;
  cout<<"number of consonants:"<<numofconsonant<<endl;

  return 0;
}  

[amchinese]

1.Just add an 'else' at the end of first if-else structure:

else
numofconsonant++;

2.Change second if-else into:

#define a input.at(j)
if(a!='a'&&a!='e'[and so on])

3.You can also use switch.

[JLBorges]

Vowel (characters) may be in upper case.
Some characters are neither vowels nor consonants.

#include <iostream>
#include <string>
#include <cctype>

int main()
{
    const std::string wovels = "AEIOUaeiou" ;

    std::cout << "please type in a sentence\n" ;
    std::string sentence ;
    std::getline( std::cin, sentence ) ;
    std::cout << sentence << '\n' ;

    int num_vowels = 0 ;
    int num_consonants = 0 ;

    for( char c : sentence ) // http://www.stroustrup.com/C++11FAQ.html#for
    {
        // http://www.cplusplus.com/reference/string/string/find/
        if( wovels.find(c) != std::string::npos ) ++num_vowels ;

        // http://www.cplusplus.com/reference/cctype/isalpha/
        else if( std::isalpha(c) /* || std::isdigit(c) ?? */ ) ++num_consonants ;
    }

    std::cout << "number of vowels: " << num_vowels << '\n'
              << "number of consonants: " << num_consonants << '\n' 
              << "number of characters: " << sentence.size() << '\n' ;
}

http://coliru.stacked-crooked.com/a/0fec283c46a2fe7d

[cire]

1.Just add an 'else' at the end of first if-else structure:

That wouldn't be correct. A character that is not a vowel is not necessarily a consonant. A space character, for instance, is neither.

Your #define suggestion is particularly disturbing.

char& a = input.at(j); would be more appropriate.

#include <iostream>
#include <string>

using namespace std;

int main()
{
    const string vowels("aeiou");
    const string consonants("bcdfghjklmnpqrstvwxyz");

    string input;
    cout << "please type in a sentence" << endl;
    getline(cin, input);

    unsigned nVowels = 0;
    unsigned nConsonants = 0;

    for (auto ch : input)
    {
        if (vowels.find(ch) != std::string::npos)
            ++nVowels;
        if (consonants.find(ch) != std::string::npos)
            ++nConsonants;
    }

    std::cout << "Vowels:     " << nVowels;
    std::cout << "\nConsonants: " << nConsonants << '\n';
}

[chofs]

okay i also took into consideration space chacters as you said cire....and also reduced my code a bit... now i want to knw hw i wud output the number of each vowel for instance: a=?
e=?
i=?
o= ?
u=?

question mark indicating the number of each vowel......thanx for the help guys
awsme

  #include <iostream>
#include <string>

using namespace std;

int main()
{
  string input;
  cout<<"please type in a sentence"<<endl;
  getline(cin,input);

  int numofvowel=0;
  int numofconsonant=0;
  int numofspace=0;

  for(unsigned int i=0;i<input.length();i++)
  {
      if(input.at(i)=='a')
      {
          numofvowel++;

      }
      else if(input.at(i)=='e')
      {
         numofvowel++;
      }
      else if(input.at(i)=='i')
      {
         numofvowel++;
      }
      else if(input.at(i)=='o')
      {
        numofvowel++;
      }
      else if(input.at(i)=='u')
      {
        numofvowel++;
      }
      else if(input.at(i)==' ')
      {
        numofspace--;
      }
      else numofconsonant++;
  }


  cout<<"number of vowels: "<<numofvowel<<endl;
  cout<<"number of consonants:"<<numofconsonant<<endl;

  return 0;
}