function fails to run

Hello I am trying to run a program that allows a user to update a list of URL bookmarks in a data file. The bookmarks are to be sorted alphabetically by category at all times. I used several functions to create this program. The read, sort, display and quit functions are working. The add_bookmark, search, and delete_bookmark functions are not working properly. I added comments next to the function calls of these functions in the main. Please advise. I appreciate your help.
  #include<iostream>
#include<fstream>
#include<string>

using namespace std;
const int BK_MK_LEN = 50;
const int CAT_LEN = 30;
const int NUM_URLS = 50;

int read_bookmarks(char[][BK_MK_LEN], char[][CAT_LEN]);
void sort_bookmarks(int, char[][BK_MK_LEN], char [][CAT_LEN]);
int menu();
void display_bookmark(int, char [][BK_MK_LEN], char [][CAT_LEN]);
int add_bookmark(int, char [][BK_MK_LEN], char [][CAT_LEN], int);
void quit(int,  char [][BK_MK_LEN], char [][CAT_LEN], int);
int search(int, char[][BK_MK_LEN], int);
int delete_bookmark(int, char[][BK_MK_LEN], char[][CAT_LEN], int, int);


void main()
{
	int count, choice, lookup;

	char bookmark[NUM_URLS][CAT_LEN];
	char URL[NUM_URLS][BK_MK_LEN];


	choice = menu();	
	count = read_bookmarks(URL, bookmark);
	sort_bookmarks(count, URL, bookmark);
	display_bookmark(count, URL, bookmark);
	quit(count, URL, bookmark, choice);

    add_bookmark(count, URL, bookmark, choice);// function does not write to file. 
	lookup = search(count, URL, choice); // not sure if this is working
	delete_bookmark(count, URL, bookmark, choice, lookup); // function does not run at all 
	//also I noticed that the last URL is deleted randomly after I run this program a few times. 
		
	
	system("pause");

}


int read_bookmarks(char URL[][BK_MK_LEN], char bookmark[][CAT_LEN])
{  
	int count = 0;

	ifstream in;
	in.open("bookmark.txt");

	if(in.is_open())
	{
		in >> bookmark[count];
		in >> URL[count];
		
		while(!in.eof())
		{
			count++;
			in >> bookmark[count];
			in >> URL[count];
			
				}

	cout<<"The number of URLs read is "<<count<<endl<<endl;
	}

	else 
		cout<<"Unable to open file";

	in.close();
	return count;
}

void sort_bookmarks(int count, char URL[][BK_MK_LEN], char bookmark[][CAT_LEN])
{ 
	char temp1[CAT_LEN];
	char temp2[BK_MK_LEN];

	for (int i = 1; i < count; i++)
	{
		for (int j = 0; j<count-1; j++)
		{
        
			if (strcmp(bookmark[j],bookmark[j+1])>0)
			{
				strcpy(temp1, bookmark[j]);
				strcpy(bookmark[j], bookmark[j+1]);
				strcpy(bookmark[j+1], temp1);
            
				strcpy(temp2, URL[j]);
				strcpy(URL[j], URL[j+1]);
				strcpy(URL[j+1], temp2);
		
			}
	
		}
	}

	ofstream out;
	out.open("bookmark.txt");

	if(out.is_open())
	{	
		for(int i = 0; i < count; i++)
		{
			out<<bookmark[i]<<" "<<URL[i]<<endl;
		}
	}
	
	else 
	{ 
		cout<<"Unable to open file";
	}

	out.close();
	
}


int menu()
{		
		int choice = 0; 

		cout<<"Please choose whether you would like to amend your bookmarks."<<endl;
		cout<<"To delete a bookmark, please enter 1. To add a bookmark, please enter 2. To quit, please enter 3: ";
		cin>>choice;
		
		cout<<endl;

		if(choice == 1 || choice == 2 || choice == 3)
		{
			cout<<"You entered a valid choice."<<endl<<endl;

		}
		else
		{	while(choice != 1 && choice != 2 && choice !=3)
			{
				cout<<"You entered an invalid number. Please enter 1 to delete a bookmark, 2 to add a bookmark or 3 to quit."<<endl;
				cin>>choice;
			}

			cout<<"You entered a valid choice."<<endl<<endl;
			
		}
		
		
		return choice;
}


void display_bookmark(int count, char URL[][BK_MK_LEN], char bookmark[][CAT_LEN])
{
	
	cout<<"Your original list of bookmarks is: "<<endl<<endl;

	for(int j=0; j<count; j++)
	cout<<bookmark[j]<<" "<<URL[j]<<endl;

	cout<<endl;
}


int add_bookmark(int count, char URL[][BK_MK_LEN], char bookmark[][CAT_LEN], int choice)
{ 	
	int i = 0;
	char newURL[40][BK_MK_LEN];
	char newBookmark[40][BK_MK_LEN];

	bool answer = 1;
	
			
			
			
			if(choice == 2)
		
				{
						cin.ignore();
						cout<<"You chose to add a bookmark. Please enter the category of the URL."<<endl;
						cin.getline(newBookmark[i],BK_MK_LEN);
						cin.clear();

						cout<<"Please enter the URL: "<<endl;
						cin.getline(newURL[i],BK_MK_LEN);
						cin.clear();
					
					
						ofstream out;
						out.open("bookmark.txt");

						if(out.is_open())
							{	
								
									cout<<"\n\nThe following will be added to the data file: "<<newBookmark[i]<<" "<<newURL[i]<<endl<<endl;
									out<<newBookmark[i]<<" "<<newURL[i]<<endl;
								
							
							}
		
						else 
							{ 
								cout<<"Unable to open file"<<endl;
							}

						out.close();
		
						sort_bookmarks(count, URL, bookmark);

						
						i++;

						
						cout<<"Would you like to add another bookmark? Please answer 1 for yes or 0 for no: "<<endl;
						cin>>answer;
				}
			
				while((answer == 1) && i<40)
					{	
						
						if(choice==2)

						{	cin.ignore();
							cout<<"You chose to add a bookmark. Please enter the category of the URL."<<endl;
							cin.getline(newBookmark[i],BK_MK_LEN);
							cin.clear();
							
							cout<<"Please enter the URL: "<<endl;
							cin.getline(newURL[i],BK_MK_LEN);
							cin.clear();

						
					
							ofstream out;
							out.open("bookmark.txt");

							if(out.is_open())
							{	
								
									cout<<"\n\nThe following will be added to the data file: "<<newBookmark[i]<<" "<<newURL[i]<<endl<<endl;
									out<<newBookmark[i]<<" "<<newURL[i]<<endl;
								
							
							}
		
							else 
							{ 
								cout<<"Unable to open file"<<endl;
							}

							out.close();
		
							sort_bookmarks(count, URL, bookmark);
		
							i++;
							count++;

								
							cout<<"Would you like to add another bookmark? Please answer 1 for yes or 0 for no: "<<endl;
							cin>>answer;
						
						}
			
						
				
				}

						if(answer==0)
							cout<<"\n\nYou chose to not add any more bookmarks. Thank you for using this bookmark program."<<endl;

		
		return count;

}
	


void quit(int count,  char URL[][BK_MK_LEN], char bookmark[][CAT_LEN], int choice)
{		
	if(choice==3)
	{
		cout<<"You chose to quit. No more bookmarks will be added or deleted"<<endl;
	}

}



int search(int count, char URL[][BK_MK_LEN], int choice)
{	
	char searchURL[NUM_URLS][BK_MK_LEN];
	int i = 0;
	

	for(int k = 0; k < count; k++) 
	
		{ 
			if(searchURL[i] ==  URL[k])
				{
					return k;
				}
						
			else
				{
					return -1;
				}
		}
}


int delete_bookmark(int count,char URL[][BK_MK_LEN],char bookmark[][CAT_LEN], int choice, int lookup)
{	
	
	int i = 0;
	char searchURL[NUM_URLS][BK_MK_LEN];
	
	bool answer = 1;
		
	
			
		if(choice == 1)
		
				{
						cin.ignore();
						cout<<"You chose to delete a bookmark. Please enter the URL you would like to delete: "<<endl;
						cin.getline(searchURL[i],BK_MK_LEN);
						cin.clear();

						if(lookup != -1)
						{
							delete [lookup]URL;
							delete [lookup]bookmark;
							sort_bookmarks(count, URL, bookmark);
							count--;
							i++;
						}
						
						else
							cout<<"The URL was not found. Please try again."<<endl;

						
						cout<<"Would you like to delete another bookmark? Please answer 1 for yes or 0 for no: "<<endl;
						cin>>answer;

				}


		while((answer == 1))
			{
				if(choice == 1)
		
				{
						cin.ignore();
						cout<<"You chose to delete a bookmark. Please enter the URL you would like to delete: "<<endl;
						cin.getline(searchURL[i],BK_MK_LEN);
						cin.clear();

						if(lookup != -1)
						{
							delete [lookup]URL;
							delete [lookup]bookmark;
							count--;
							i++;
						}
						
						else
							cout<<"The URL was not found. Please try again."<<endl;

						sort_bookmarks(count, URL, bookmark);
		

						cout<<"Would you like to delete another bookmark? Please answer 1 for yes or 0 for no: "<<endl;
						cin>>answer;
						
				}	
			

		}
	return count;
				
}
Topic archived. No new replies allowed.
C++

Forum

function fails to run
