Merge Sort (Template)

When I try to run this program, I get this error: " 'void KW::merge(RI, RI, RI, RI, RI, RI)' : template parameter 'RI' is ambiguous". I'm not sure if there is a problem with the iterators or what.
It runs into this problem when merge_sort(...) calls merge(...).

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
#include <iostream>
#include <string>
#include <sstream>
#include <string.h>
#include <vector>

using namespace std;

namespace KW {

	template<typename RI>
	void merge(RI left, RI end_left,
		RI right, RI end_right,
		RI out) {
		// while there is data in both input sequences
		while (left != end_left && right != end_right) {
			// find the smaller and
			// insert it into the output sequence
			if (*left < *right) {
				*out++ = *left++;
			}
			else {
				*out++ = *right++;
			}
		}

		// Assert: one of the sequences has more items to copy.
		// Copy remaining input from left sequence into ouput
		while (left != end_left) {
			*out++ = *left++;
		}

		//copy remaining input from right sequence into output
		while (right != end_right) {
			*out++ = *right++;
		}
	}
	template<typename RI>
	void merge_sort(RI first, RI last) {
		if (last - first > 1) {
			// split table into two new half tables
			typedef typename std::iterator_traits<RI>::value_type value_type;
			RI middle = first + (last - first) / 2;
			std::vector<value_type> left_table(first, middle);
			std::vector<value_type> right_table(middle, last);

			// sort the halves
			KW::merge_sort(left_table.begin(), left_table.end());
			KW::merge_sort(right_table.begin(), right_table.end());

			// merge the halves back into the original table.
			merge(left_table.begin(), left_table.end(),
				right_table.begin(), right_table.end(),
				first);
		}
	}

}

int main()
{
	
	string str;
	int count = 0;
	getline(cin, str);
	stringstream ss;
	ss << str;
	int nums = 0;
	while (ss >> nums) {
		count++;
	}
	
	int *arr = new int[count];
	memset(arr, 0, sizeof(int)* count);

	int num = 0;
	count = 0;
	ss.clear();
	ss << str;
	while (ss >> num) {
		arr[count] = num;
		count++;
	}

	KW::merge_sort(arr, arr + count);
	//quickSort(arr, 0, count - 1);

	for (int i = 0; i < count; ++i) {
		cout << arr[i] << " ";
	}
	delete[] arr;
	//system("PAUSE");
}
Ok, so I figured out that it works when I use the correct parameters for the KW::merge_sort() function call initially in the main function.
This code works. But how could I get the array that I had before to work?
How are you supposed to pass the parameters?

this is the working code with the vector:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
int main()
{
	
	string str;
	int count = 0;
	getline(cin, str);
	stringstream ss;
	ss << str;
	int nums = 0;
	while (ss >> nums) {
		count++;
	}
	
	//create vector
	vector<int> arr;

	//int *arr = new int[count];
	//memset(arr, 0, sizeof(int)* count);

	int num = 0;
	count = 0;
	ss.clear();
	ss << str;
	while (ss >> num) {
		arr.push_back(num);
		count++;
	}

	// call the sort function using the vector iterators
	KW::merge_sort(arr.begin(), arr.end());
	//quickSort(arr, 0, count - 1);

	for (int i = 0; i < count; ++i) {
		cout << arr[i] << " ";
	}
	//delete[] arr;
	system("PAUSE");
}
Topic archived. No new replies allowed.