display vector with struct

[heston]

To start off, I have a menu system. I have a struct, which I put in a vector. I add name and age to to vector. That works fine.
In a seperate function, I want display whats in the vector. How can I do this? Nothing I've tried seems to work

struct Patient  
    {
    string name;				
    string age;	
    string gender;			
    };

void getNames(vector<Patient>&); 
void displayNames(vector<Patient>&);

int main()
{
	vector<Patient> patientData;  
	string mainMenuSelection;
	
	while (menuSelection != "quit")
	{
		cout << "1) add" << endl;
		cout << "2) display" << endl;
                cout << "3) quit" << endl
		cout << "> ";
		
		cin >> menuSelection;
		 
		if (menuSelection == "add" || menuSelection == "1")
			{
	    	getNames(patientData);
	  		}
	  	else if (menuSelection == "display" || menuSelection == "2")
		  	{
	      	
	  	else if (menuSelection == "quit" || menuSelection == "3")
	  		{
			break; //terminates program
	  		}
	  	else
		  {
	  	  cout << "Invalid entry" << endl;
	  	  }
	}
	return 0;
}

void getNames(vector<Patient>& patientData)
{
	system("cls");
    
    //Header
    cout <<"********" << endl; 
    cout <<"* DATA *" << endl;
    cout <<"********" << endl << endl;
    cin.ignore();
    string name, gender; 
    int age;
    Patient aPatient; //Struct for patient data
    aPatient.name = name;
    aPatient.age = age;
    aPatient.gender = gender;
    
	while(name != "quit")
    {
    cout << "Name: (quit to stop) \t";
    getline(cin, name);
		if(name == "quit")
		{
		break;
		system("cls");
		}
    cout << "Age: \t";
    getline(cin, age);
    
	cout << "gender: \t";
    getline(cin, gemder);
     
    vector<Patient>patientData;
	patientData.push_back(aPatient);	
	}
	system("cls");	
}

void displayNames(vector<Patient>& patientData)
{
	
	system("cls"); // clear screen
	cout << "*******************" << endl; // page header
	cout << "* Display Records *" << endl;
	cout << "*******************" << endl << endl;
	Patient aPatient;
	string name, age, gender;
	aPatient.name = name;
        aPatient.age = age;
        aPatient.gender = gender;
	
	int y = patientData.size();
         for(int x = 1; x < y; x++)
             {
             cout << patientData[x].name; // ??
	     }
		 
	system("PAUSE");
	system("cls");
	
}  

[Smac89]

Line 75, you are creating a new vector with the same name as the vector passed as argument to the function. Why are you doing this?

[heston]

That's a mistake...but was deleted.

[BHX]

I went back using your code as a example and tried to keep it close to what you had, but made a few changes one being system() due to OS (I'm on linux and System("cls") is windows, but rather than changing it to my OS equivalents I simply removed them though you can add them back if you like).

#include <iostream>
#include <vector>
#include <string>

using namespace std;

struct Patient{
	string name;
	string age;
	string gender;
};

void getNames(vector<Patient>&);
void displayNames(vector<Patient>&);

int main()
{
	vector<Patient> patientData;
	string menuSelection;
	
	do{
		cout << "1) add" << endl;
		cout << "2) display" << endl;
		cout << "3) quit" << endl;
		cout << "> ";
		
		cin >> menuSelection;
		
		if (menuSelection == "add" || menuSelection == "1")
		{
			getNames(patientData);
		}
		else if(menuSelection == "display" || menuSelection == "2")
		{
			displayNames(patientData);
		}
		else if(menuSelection == "quit" || menuSelection == "3")
		{
			break;
		}
		else
		{
			cout << "Invalid entry" << endl;
		}
	}while (menuSelection != "quit" || menuSelection != "3");
	
	return 0;
}

void getNames(vector<Patient> &patientData)
{
	Patient aPatient;
	cout << "*************" << endl;
	cout << "*    DATA   *" << endl;
	cout << "*************" << endl << endl;
	cin.ignore();
	cout << "Name:\t";
	getline(cin, aPatient.name);
	cout << "Age:\t";
	getline(cin, aPatient.age);
	cout << "Gender:\t";
	getline(cin, aPatient.gender);
	
	patientData.push_back(aPatient);
}

void displayNames(vector<Patient> &patientData)
{
	cout << "*******************" << endl;
	cout << "* DISPLAY RECORDS *" << endl;
	cout << "*******************" << endl << endl;
	
	for (unsigned int i = 0; i < patientData.size(); i++)
	{
		cout << patientData[i].name << endl;
	}
	cout << endl;
}