TicTacToe-Linked List Winning Conditions

[venros]

Hi guys,

Im new to linked list so bear with this code. I'm stuck on the winning conditions, and the one I have currently will simply not work if I get x in pos 2,3,4 for the Horizontal check.


Ignore the int data, and me trying to use 'x' or '0' ill fix that later.

#include <iostream>
#include <string>
#include <ctime>
#include <cstdlib>
using namespace std;



//4. Implement a two player tic-tac-toe game. First use a linked list to represent the board. Then use
//an array. Which is easier? Why?


typedef struct node* nodePtr;
int playerTurn(1);
list board; // error C2146: syntax error : missing ';' before identifier 'board'

struct node{

  int data;
  node* next;

};


class list{
public:
  nodePtr head;
  nodePtr temp;
  nodePtr curr;

  list();
  void move();
  void display(nodePtr &temp, nodePtr &head);
  //void initialize(nodePtr &temp, nodePtr &head);
  void input(nodePtr curr, int searchValue);
  void switchTurn();
  int whoWon(nodePtr curr);
};


list::list(){
  head = NULL;
  temp = NULL;

  nodePtr n = new node;
  nodePtr head = n;
  nodePtr temp = n;
  nodePtr curr = temp;
  n->data = 1;

  for(int i = 2; i < 10; i++){
    nodePtr localNode = new node;
    localNode->data = i;
    temp->next = localNode;
    temp = localNode;
  }
  temp->next = NULL;
  temp = head;
}



void list::move(){
  int input;
  board.display(temp, head);
  cout << "Please Make a move: " << endl;
  cin >> input;
  board.input(curr, input);
}

void list::input(nodePtr curr, int searchValue){
  if(curr == NULL){
    cout << searchValue << " was an invalid move." << endl;
    move();
  }
  else if(curr->data == searchValue){
    if(playerTurn == 1){
      curr->data = 'x';
      board.switchTurn();
      move();
    }else{  
      curr->data = '0';
      board.switchTurn();
      move();
    }
  }
  else{ 
    input(curr->next, searchValue);
  }
}


void list::display(nodePtr &temp, nodePtr &head){ 
  while(temp != NULL){
    int i;
    for(i = 0; i < 3; i++){
      cout << temp->data << "\t";
      temp = temp->next;
    }
    cout<<endl;
    i = 0;
  };
  temp = head;
}

//void initialize(nodePtr &temp, nodePtr &head){
//
//}

void switchTurn(){
  switch (playerTurn){
  case 1: 
    board.switchTurn();
    system("cls");// refresh board
    break;
  case 2: 
    board.switchTurn();
    system("cls");// refresh board
    break;
  }
}

int list::whoWon(nodePtr curr){
  int x_Counter(0);
  int y_Counter(0);
  //HORIZONTAL CHECK
  if(curr->data == 'x'){ 
    y_Counter = 0;
    x_Counter++;
    whoWon(curr->next);
    if(x_Counter == 3){
      return 1;
    }
  }
  else if(curr->data == '0'){
    x_Counter = 0;
    y_Counter++;
    whoWon(curr->next);
    if(y_Counter == 3){
      return 2;
    }
  }
  else{ 
    return 0;
  }
}


int main(){


  board.move();


  system("pause");
}

[venros]

I did a quick fix for the whoWon function, but still dont know if it works or not because the program doesnt compile:

int list::whoWon(nodePtr curr){
  int x_Counter(0);
  int y_Counter(0);
  int row_counter(0);
  //HORIZONTAL CHECK
  if(curr->data == 'x'){ 
    y_Counter = 0;
    x_Counter++;
    row_counter++;
    whoWon(curr->next);
    if(row_counter <= 3){
      if(x_Counter == 3){
        return 1;
      }
    }else{
      x_Counter = 0;
      y_Counter = 0;
    }
  }
  else if(curr->data == '0'){
    x_Counter = 0;
    y_Counter++;
    row_counter++;
    whoWon(curr->next);
    if(row_counter <= 3){
      if(y_Counter == 3){
        return 2;
      }
    }else{  
      x_Counter = 0;
      y_Counter = 0;
    }
  }
  else{ 
    return 0;
  }
}

[CodeGoggles]

You also declare a variable (list board) line 15 before the declaration of the class list.

error C2146: syntax error : missing ';' before identifier 'board'

That is what it is referring to.

[venros]

I fixed it, ty.

But i still get errors, forexample my who won function is giving me issues, because I must return a value on the else statements.

Im thinking of putting it in a switch statement with the default, unless there is a cleaner fix for it.

[CodeGoggles]

void switchTurn(){
  switch (playerTurn){
  case 1: 
    board.switchTurn();
    system("cls");// refresh board
    break;
  case 2: 
    board.switchTurn();
    system("cls");// refresh board
    break;
  }

I notice here you have recursion happening but I don't see a base case. Would this not cause a stack overflow? how are you changing playerTurn variable to make the function return?

[CodeGoggles]

But i still get errors, forexample my who won function is giving me issues, because I must return a value on the else statements.

Can you be more concise on what is happening with your return values and why it is an issue.

[venros]

CodeGoggles, that was a left over code, Its supposed to change player turn to 1 or 2 based on the current turn.

Im trying to retun 1, for player 1 won, 2 for 2 won, or 0 for its a tie.

The issue is there because I dont have a return on every else statement such as this block of code:

    if(row_counter <= 3){
      if(y_Counter == 3){
        return 2;
      }
    }else{  
      x_Counter = 0;
      y_Counter = 0;
    }

the else does not return anything, even if i return whoWon(curr->next) (maybe cuz its an int? not sure.

Im still learning and testing with recursion but this is where I got stuck.


edit:
This is what I have so far but still requires a return on every if else etc.

int list::whoWon(nodePtr curr){
  int x_Counter(0);
  int y_Counter(0);
  int row_counter(0);
  //HORIZONTAL CHECK
  switch(playerTurn){
  case 1:
    if(curr->data == 'x'){ 
      y_Counter = 0;
      x_Counter++;
      row_counter++;
      whoWon(curr->next);
      if(row_counter <= 3){
        if(x_Counter == 3){
          return 1;
        }
      }else{
        x_Counter = 0;
        y_Counter = 0;
        break;
      }
    }
  case 2:
    if(curr->data == '0'){
      x_Counter = 0;
      y_Counter++;
      row_counter++;
      whoWon(curr->next);
      if(row_counter <= 3){
        if(y_Counter == 3){
          return 2;
        }
      }else{  
        x_Counter = 0;
        y_Counter = 0;
        break;
      }
    }
  default:
    return 0;
  }
}