C++

Forum

 
counting duplicate array need help

qwertyking (50)
Hi, I am learning computer science this semester, and having trouble with my homework.
I think I am heading the right way. but it keeps giving me infinite loop when I put

 
 
 cout << "'" << source[i] << "'" << " appeared " << count << " times.\n";


9. duplicate for all the element within the range lowhigh, only print out one copy of the word when they are contiuous duplicates, along with the count of how many times this word appeared continuously.

For example, when the source array has the following words from index 0 to 9:
0: aa
1: aa
2: aa
3: bb
4: cc
5: cc
6: aa
7: aa
8: aa
9: aa
duplicate(words, 0, 9) would produce this output:
'aa' appeared 3 times.
'bb' appeared 1 times.
'cc' appeared 2 times.


1
2
3
4
5
6
7
8
9
10
11
12
13
 
void duplicate(const string source[], int low, int high) {
    int i;
    int j;
    int count = 0;
    for (int i = low; i < high; i++) {
        for (int j = low; j < high; j++) {
            if (source[i]==source[j]) {
                count++;
            }
        }
    }        
    return;
}
LB (13399)
Where are you putting that output statement?
qwertyking (50)
@LB
I tried it everywhere. under if statement, under second for loop, and the first for loop. but it doesn't work.
LB (13399)
Why would it be inside that function at all? Shouldn't the function return the value of count?
qwertyking (50)
@LB
but if it's not in the function, it will not repeat. It should count every array that is duplicated. so if it's out of function it will only print out once. Isn't it?
I thought about using while loop or another for loop to print it out till there are no duplicates left. but, I am so confused now
LB (13399)
Your function does not count individual duplicates, it counts all duplicates. You want to put the output statement after the inner for loop and then reset count to 0 after the output statement.
qwertyking (50)
@LB
I got what you said, but I don't know how to reset the count to 0
do I reset it like this?
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
 
void duplicate(const string source[], int low, int high) {
    int i;
    int j;
    int count = 0;
    for (int i = low; i < high; i++) {
        for (int j = low; j < high; j++) {
            if (source[i]==source[j]) {
                count++;
            }
            cout << "'" << source[i] << "'" << " appeared " << count << " times.\n";
            count = 0;
        }
    }        
    return;
}
LB (13399)
Yes, but you accidentally put the code inside the inner for loop instead of after the inner for loop.
qwertyking (50)
@LB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
 
void duplicate(const string source[], int low, int high) {
    int i;
    int j;
    int count = 0;
    for (int i = low; i < high; i++) {
        for (int j = low; j < high; j++) {
            if (source[i]==source[j]) {
                count++;
            }
        }
        cout << "'" << source[i] << "'" << " appeared " << count << " times.\n";
        count = 0;
    }        
    return;
}


I did it what you said, but it is giving me weird outputs... It prints out alot of the same values.

'a' appeared 8 times. 'a' appeared 8 times. 'a' appeared 8 times. 'a' appeared 8 times. 'a' appeared 8 times. 'a' appeared 8 times. 'a' appeared 8 times. 'a' appeared 8 times.

like this. I'm pretty sure I did something wrong at the count parts
LB (13399)
Yes, because you loop through the entire array without discriminating. If you only want to show the duplicates for the first element, you need to do some more work.

I would recommend instead using a std::map<std::string, int> as it will simplify your code dramatically.
qwertyking (50)
@LB
I'm using <Iostream> and i don't know what that std::map<std::string.
what do you want me to use?
LB (13399)
Topic archived. No new replies allowed.