C++

Forum

 
Writing a Card Game program errors

cjn5143 (3)
I am trying to write a program for the card game Old Maid, but I am getting some errors which I don't know how to fix. My main function isn't complete yet, but the error that I specifically need help with is in my functions. Specifically in my DealCard function and Turn function.

1>c:\users\christian\documents\visual studio 2013\projects\consoleapplication1\consoleapplication1\consoleapplication1.cpp(150): error C2087: 'hands' : missing subscript
1>c:\users\christian\documents\visual studio 2013\projects\consoleapplication1\consoleapplication1\consoleapplication1.cpp(176): error C2087: 'hands' : missing subscript
1>c:\users\christian\documents\visual studio 2013\projects\consoleapplication1\consoleapplication1\consoleapplication1.cpp(280): error C2664: 'void dealCard(int [][1],int [],int)' : cannot convert argument 1 from 'int [6][26]' to 'int [][1]'
1> Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
 
void dealCard(int hands[][], int handsize[], int players){
	int deck[51] = { 1, 1, 1, 1, 2, 2, 2, 2, 3, 3, 3, 3, 4, 4, 4, 4, 5, 5, 5, 5, 6, 6, 6, 6, 7, 7, 7, 7, 8, 8, 8, 8, 9, 9, 9, 9, 10, 10, 10, 10, 11, 11, 11, 11, 12, 12, 12, 13, 13, 13 };
	for (int i = 0; i < 51; i++){
		int random = rand() % 51 + 1;
		if (random != i){ //make sure not to swap a number with itself
			swap(deck[i], deck[random]);
		}
	}
	for (int card = 0; card < (51 / players); card++){
		for (int player = 0; player < players; player++){
			for (int draw = 0; draw < 51; draw++){
				hands[player][card] = deck[draw]; //Distribute the cards in order, to each player
				handsize[player] = handsize[player] + 1; //Add a card to the hand
			}
		}
	}
}

void Turn(int hands[][], int handsize[], int current_player, int previous_player){
			//takes a turn, either for the person at the keyboard or simulated by computer
			if (current_player == 0){ // Player taking from computer
				cout << "You have these cards in your hand:  " << endl;
				for (int t = 0; t < 51; t++)
					if (hands[0][t] == 1)
						cout << "Ace    ";
					else if (hands[0][t] == 2)
						cout << "Two   ";
					else if (hands[0][t] == 3)
						cout << "Three   ";
					else if (hands[0][t] == 4)
						cout << "Four   ";
					else if (hands[0][t] == 5)
						cout << "Five   ";
					else if (hands[0][t] == 6)
						cout << "Six   ";
					else if (hands[0][t] == 7)
						cout << "Seven   ";
					else if (hands[0][t] == 8)
						cout << "Eight   ";
					else if (hands[0][t] == 9)
						cout << "Nine   "; 
					else if (hands[0][t] == 10)
						cout << "Ten   ";
					else if (hands[0][t] == 11)
						cout << "Jack   ";
					else if (hands[0][t] == 12)
						cout << "Queen   ";
					else if (hands[0][t] == 13)
						cout << "King   ";
				

				int pickcard;
				cout << "You get to draw a card from a hand containing   " << handsize[previous_player] << endl;;
				cout << "Choose a number from one to   " << handsize[previous_player] << endl;
				cin >> pickcard;

				ReceiveCard(hands[current_player], handsize[current_player], hands[previous_player][pickcard]);
				RemoveCard(hands[previous_player], handsize[previous_player], pickcard);
			}
			else if (previous_player == 0){ //Simulate a computer taking from player, randomly choosing a card.
				int compcard;
				compcard = rand() % handsize[previous_player] + 1;
				cout << "A computer player took your  ";
				if (hands[0][compcard] == 1)
					cout << "Ace    ";
				else if (hands[0][compcard] == 2)
					cout << "Two   ";
				else if (hands[0][compcard] == 3)
					cout << "Three   ";
				else if (hands[0][compcard] == 4)
					cout << "Four   ";
				else if (hands[0][compcard] == 5)
					cout << "Five   ";
				else if (hands[0][compcard] == 6)
					cout << "Six   ";
				else if (hands[0][compcard] == 7)
					cout << "Seven   ";
				else if (hands[0][compcard] == 8)
					cout << "Eight   ";
				else if (hands[0][compcard] == 9)
					cout << "Nine   ";
				else if (hands[0][compcard] == 10)
					cout << "Ten   ";
				else if (hands[0][compcard] == 11)
					cout << "Jack   ";
				else if (hands[0][compcard] == 12)
					cout << "Queen   ";
				else if (hands[0][compcard] == 13)
					cout << "King   ";
				ReceiveCardComputer(hands[current_player], handsize[current_player], hands[previous_player][compcard]);
				RemoveCardComputer(hands[previous_player], handsize[previous_player], compcard);
			}
			else{																		//Computer taking from computer, randomly choosing a card
				int compcard2;
				compcard2 = rand() % handsize[previous_player] + 1;
				ReceiveCardComputer(hands[current_player], handsize[previous_player], hands[previous_player][compcard2]);
				RemoveCardComputer(hands[previous_player], handsize[previous_player], compcard2);
			
			
			
			}
		}
int main()
{

	char yesNo;
	do{
		int players;
		int hands[6][26];
		int handsize[6] = { 0 };
		cout << "How many players do you want to play? ";
		cin >> players;
		int turnorder[6];
		for (int counter = 0; counter < players; counter++){ //filling the turn order array depending on how many players there are, from one to the number of players.
		for (int counter1 = 1; counter1 <= players; counter1++){
			turnorder[counter] = counter1;
			}
		}
		dealCard(hands, handsize, players);



		bool GameOver = false;
		int counter3;
		for (int check = 0; check < players; check++){ //see how many players are left in the game
			if (turnorder[check] != 0)
				counter3++;
			if (counter3 = 1) //if there is only one player left, then the game is over
				GameOver = true;
		}
				
			
		if (GameOver = true){
			cout << "Game Over! Do you want to play again? (y\n)  ";
			cin >> yesNo;
		}
	} while (yesNo == 'y' || yesNo == 'Y');
			cout << "Thanks for playing!" << endl;
		}
LB (13399)
The lines in your error messages do not line up with he line numbers here. The first error message is line 150, but you have only shown us 140 lines of code.
cjn5143 (3)
Sorry! I went over the character limit by putting in all of my code. The lines of error correspond to line 19, 1, and 119.
wildblue (1505)
error: declaration of ‘hands’ as multidimensional array must have bounds for all dimensions except the first
 void Turn(int hands[][], int handsize[], int current_player, int previous_player){
                       ^


With multidimensional arrays, you need to tell the compiler the size of the dimensions other than the first.

void Turn(int hands[][26], int handsize[], int current_player, int previous_player


Also - on line 128 and 133 in your posted code - I think you want == not = ?
Last edited on
cjn5143 (3)
Thanks! That took care of the compiler problem. And thank you for the corrections on the other lines!
Topic archived. No new replies allowed.