Keep on getting wrong answer for 3n + 1 problem

I think there is something wrong with my user input, I'm not sure.
Thanks

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
#include <iostream>
using namespace std;
int cyclerfunc( long int a, long int y);
int main()
{    long int a, b;
     int counter = 0;
	 while (cin>>a>>b){
	}
	cout<<a<<" "<<b<<" "<<cyclerfunc(a, b)<<endl;

	 
	 
};

int cyclerfunc(long int a,  long int y){     
	int n=0;
	int cycler = 0;
	int currentcycler = 0;
	n = a;
	while( n <= y){
		a = n;
		while (a != 1){
        
		if (a % 2 != 0){
			
			a = 3*a+1;
			cycler++;
			}
		else{
			a= (a/2);
			cycler++;
		}
	}
	cycler++;
	n++;

	if (currentcycler < cycler){
		currentcycler = cycler;
	}
	cycler = 0;
	
}
	return currentcycler;
}
	
What is wrong with your input? Did you mean to put your cout call in the while loop? Or did you mean to give an input like this:
1
2
3
4
5
while (!(std::cin >> a >> b)) {
    std::cout << "Invalid input! ";
    std::cin.clear();
    std::sin.sync();
}

Please give us more details.
I don't really know, what the problem is. Here is the 3n + 1 problem,
Everytime I submit it into the online judge I get a wrong answer.


Consider the following algorithm to generate a sequence of numbers. Start with an integer n. If n is even, divide by 2. If n is odd, multiply by 3 and add 1. Repeat this process with the new value of n, terminating when n = 1. For example, the following sequence of numbers will be generated for n = 22:

22 11 34 17 52 26 13 40 20 10 5 16 8 4 2 1
It is conjectured (but not yet proven) that this algorithm will terminate at n = 1 for every integer n. Still, the conjecture holds for all integers up to at least 1, 000, 000.
For an input n, the cycle-length of n is the number of numbers generated up to and including the 1. In the example above, the cycle length of 22 is 16. Given any two numbers i and j, you are to determine the maximum cycle length over all numbers between i and j, including both endpoints.

Input

The input will consist of a series of pairs of integers i and j, one pair of integers per line. All integers will be less than 1,000,000 and greater than 0.
Output

For each pair of input integers i and j, output i, j in the same order in which they appeared in the input and then the maximum cycle length for integers between and including i and j. These three numbers should be separated by one space, with all three numbers on one line and with one line of output for each line of input.
Sample Input

1 10
100 200
201 210
900 1000
Sample Output

1 10 20
100 200 125
201 210 89
900 1000 174

(http://www.programming-challenges.com/pg.phppage=downloadproblem&probid=110101&format=html)
Topic archived. No new replies allowed.