Need some help plz.....

Hi all,

i am creating a program for simple calculation (+,-,*,/) and i need the user to give the 1st number, operator, 2nd number. This is what i did, is this right, whats my mistake?

#include <iostream>
using namespace std;
int main(int argc, char *argv[]) {
	float n1;
	float n2;
	char op;
	float answer
	cin>>n1;
	cin>>op;
	cin>>n2;
	switch (op)
	{
	case '+': answer=(n1+n2);
			  cout<<"The answer is:"<<answer<<endl;
				break;
	case '-': answer=(n1-n2)
			  cout<<"The answer is:"<<answer<<endl;
				break;
	case 'x': answer=(n1*n2);
			  cout<<"The answer is:"<<answer<<endl;
				break;
	case '/': answer=(n1/n2);
			  cout<<"The answer is:"<<answer<<endl;
				break;
    default: cout<<"Make sure you are using, '+' for addition, '-' for subtraction, '*' for multiplication and '/' for division!";			
	}
	return 0;
}

************************************EDITED VERSON******************************
THANKS A LOT IN ADVANCED!!! IT WILL REALLY HELP MY TRAINING!!!

Last edited on

OspreyR10A (4)

You could try using a if statement to say:

If the operator is equal to + then do addition, something like this,

if (operator == '+') n1 += n2;

ShehabKKhan (15)

@OspreyR10A, the ='==' is for the value....

Jaybob66 (534)

"operator" is a keyword in c++, call your variable "op" or something similar.

@line 10, don't make answer equal to anything yet. just float answer;

cases for - * / @ lines 16,19,22 reference "cout<<" make them like line 13.

all of the lines cout<<"The answer is:"<<answer<<endl can come out and be replaced by a single copy of it after the switch statement between lines 26/27

Last edited on

coder777 (8439)

Remove line 10. It makes no sense
lines 13,16,19,22: use single quotation marks '' (for char) instead of "" (for strings)

You don't need to repeat cout<<"The answer is:"<<answer<<endl for each case. Just place it below the switch

[EDIT]
do not use operator as a name for a variable. It's a keyword in C++ (hence it's blue...)

Last edited on

ShehabKKhan (15)

Hi guys, i did everything, but nothing worked :/ there is still syntax error...

Chervil (7320)

there is still syntax error...

I suppose it might be useful to mention what the actual error is. And also share the updated version of your code please.

ShehabKKhan (15)

this is the updated version...

coder777 (8439)

You still have the wrong quotation marks: "" instead of correct ''

ShehabKKhan (15)

still not working :/