I am having trouble with reading from a vector of strings

[Sawrana]

Here is my issue, the program will allow me to input new names and i can search for them just fine but it will NOT allow me to search for IDs that I input, however it does find IDs that are read from the file. (For the sake of length and relevance I've take out that part of the code.) I am so confused as to why it doesn't do that. I've checked the portion of the code that takes in names and IDs and i've checked the searching portion and it identical I can't find anything wrong with it. I've also checked to make sure that the IDs are loaded onto the vector... They are in there. So why the heck would it let me search for names I put in but not for IDs? I've been going crazy trying to figure this out.

About my code, first there are some lines in here like 238 that are commented out. I did that because it wasn't working so i tried using a basic binary search function instead and that's not working either. Start by hitting B it will let you create a vector that can be used to test case F.

#include <iostream>
#include <string>
#include <iomanip>
#include <vector>
#include <algorithm>
#include <cstdlib>
#include <fstream>
#include <sstream>
#include <cctype>

using namespace std;


void sortFunction(vector <string> &, vector <string> &, vector <string> &); 
void displayVector(vector <string> &, vector <string> &, vector <string> &); 
void displayMenu(); 
int binarySearchName(vector <string> &, string, int, int); 

int main()
{

	vector <string> vName, vID, vClass;
	int iStudents, iClass, iSearch;
	string sAccumulatedClass, sSelection, sFileName, sTemp, sFirstName, sLastName, sMiddleName, sFullName, sID, sClass, sSearchN, sSearchI, sQuestion, sPick;
	ofstream newStudentList;


	const char OPTION_READING = 'A', OPTION_ADDING = 'B', OPTION_DISPLAYING = 'C', OPTION_SORTING = 'D',
		OPTION_WRITING = 'E', OPTION_SEARCHING = 'F', OPTION_ENDING = 'G';

	ifstream inputFile;

	do
	{

		displayMenu();  
		
		cout << "\nPlease choose an option" << endl << endl;
		getline(cin >> ws, sSelection);

		while (sSelection.length() > 1)
		{
			cout << "Invalid entry, please try again: ";
			getline(cin >> ws, sSelection);
		}
		
		

		switch (sSelection[0])
		{



		case OPTION_ADDING:
		case 'b':

			cout << "How many students would you like to add?" << endl;
			cin >> iStudents;
			cin.ignore();

			for (int j = 0; j < iStudents; j++)
			{
				cout << "Student" << j + 1 << ":\n";
				cout << "Please enter the student Full Name: ";
				getline(cin, sFullName);
				vName.push_back(sFullName);
				
				cout << "Enter ID number ";
				getline(cin >> ws, sID);
				vID.push_back(sID);				
				cout << "How many classes would you like to add?";
				cin >> iClass;
                cin.ignore();

				sAccumulatedClass.clear();
				for (int k = 0; k < iClass; k++)
				{
					cout << "Please enter the student's Class?";
					getline(cin >> ws, sClass);
					sAccumulatedClass += sClass + ' ';	
				}
				vClass.push_back(sAccumulatedClass);
			}
			
			cout << endl;
			displayVector(vName, vID, vClass);
		    break;

		case OPTION_SORTING:
		case 'd':
			if (vName.size() == 0)
			{
				cout << "Invalid entry, please try again!";
				break;
			}
			else
			cout << "The Student List after Sorting:" << endl;
				cout << "\n";
			
				sortFunction(vName, vID, vClass);

				displayVector(vName, vID, vClass);
				break;



		case OPTION_SEARCHING:
		case 'f':
		do
		{
			
			cout << "Search Menu:" << endl;
			cout << "1. By Name\n";
			cout << "2. By Student ID\n \n";
			cout << "Would you like to search by Name or ID?" << " " << endl << endl;
			getline(cin >> ws, sPick);
			while (sPick.length() > 1 || sPick != "1" && sPick != "2")
			{
				cout << "Please enter 1 (search by Name) or 2 (search by ID) to continue: ";
				getline(cin >> ws, sPick);
			}

			cout << endl << endl;
			displayVector(vName, vID, vClass);


			
				if (sPick == "1")
				{
					cout << endl << endl;
					cout << "Please enter a Full Name to be searched" << endl;
					getline(cin >> ws, sSearchN);
					iSearch = binarySearchName(vName, sSearchN, 0, vName.size() - 1);
					if (iSearch != -1)
					{
						cout << "\n";
						cout << "The name " << sSearchN << " was found in the student list." << endl << endl;
						cout << left << setw(30) << vName[iSearch] << setw(20) << vID[iSearch] << setw(20) << vClass[iSearch] << endl << endl;
					}
					else
					cout << "The name:" << " " << sSearchN << " " << "was not found in The Student List." << endl << endl;
					cout << "would you like to search more?" << endl;
					cout << "Please enter Y/y for Yes and N/n for No:" << endl << endl;
					getline(cin >> ws, sQuestion);
					
		}


				else if (sPick == "2")
				{
					cout << endl << endl;
					cout << "Please Enter an ID to be searched:" << endl << endl;
					getline(cin >> ws, sSearchI);
					/*iSearch = binarySearchName(vID, sSearchI, 0, vID.size() - 1);
					if (iSearch != -1)*/
					if (binary_search(vID.begin(), vID.end(), sSearchI))
					{
						cout << "The ID:" << " " << sSearchI << " " << "was found in The Student List." << endl << endl;
						/*cout << left << setw(30) << vName[iSearch] << setw(20) << vID[iSearch] << setw(20) << vClass[iSearch] << endl << endl;*/
					}
					else
					cout << "The ID:" << " " << sSearchI << " " << "was not found in The Student List." << endl << endl;
					cout << "would you like to search more?" << endl;
					cout << "Please enter Y/y for Yes and N/n for No:" << endl << endl;
					getline(cin >> ws, sQuestion);
					
				}

				else
						
				while (sPick.length() > 1 || sPick != "1" && sPick != "2")
				{
					cout << "Please enter 1 (search by Name) or 2 (search by ID) to continue: ";
					getline(cin >> ws, sPick);
				}
			 
		} while (sQuestion == "Y" || sQuestion == "y");
			break;


		case OPTION_ENDING:
		case 'g':
			cout << "Thank you for using this program!";

			return 0;
			break;
	
		default:
			cout << "Error, invalid choice, try again!" << endl << endl;
		
		}
	} while (toupper(sSelection[0] != OPTION_ENDING));


}

//void function for calling menu when needed
void displayMenu()
{
	
	cout << "\t \t \t" "Student List menu" << endl << endl;
	cout << "A. Reading the Student List from a file\n";
	cout << "B. Adding Student's Informations into the Student List\n";
	cout << "C. Displaying the content of the Student List\n";
	cout << "D. Sorting and Displaying the content of the Student List\n";
	cout << "E. Writing the Student List to a file\n";
	cout << "F. Searching for a Student's Informations from the Student List\n";
	cout << "G. Ending the program" << endl << endl;


}

//Void function for calling vectors when needed
void displayVector(vector <string> &vName, vector <string> &vID, vector <string> &vClass)
{
	cout << "Now the Student List has the size of:" << " " << vName.size() << endl << endl;
	cout << left << setw(30) << "Name:" << setw(20) << "ID:" << setw(20) << "Enrolled Class : " << endl;
	cout << "--------------------------------------------------------------------------";
	cout << "\n \n";
	
	for (int i = 0; i < vName.size(); i++)
		cout << left << setw(30) << vName[i] << setw(20) << vID[i] << setw(20) << vClass[i] << endl;

}

//Void sorting fuction
void sortFunction(vector <string> &vName, vector <string> &vID, vector <string> &vClass)
{
	int startScan, minIndex;
	string minValue, minValueA, minValueB;
//loop for number of iterations
	for (startScan = 0; startScan < vName.size() - 1; startScan++)
	{
		minIndex = startScan; 
		minValue = vName[startScan]; 
		minValueA = vID[startScan]; 
		minValueB = vClass[startScan]; 


		for (int index = startScan + 1; index < vName.size(); index++)
		{

			if (vName[index] < minValue)
			{
				minValue = vName[index];
				minValueA = vID[index];
				minValueB = vClass[index];
				minIndex = index;

			}
		}

		vName[minIndex] = vName[startScan];
		vName[startScan] = minValue; 
		vID[minIndex] = vID[startScan];
		vID[startScan] = minValueA;
		vClass[minIndex] = vClass[startScan];
		vClass[startScan] = minValueB;

	}
}

//binary search function for vName
int binarySearchName(vector <string> & vName, string sSearch, int min, int max)
{
	while (min <= max) 
	{
		int mid = (min + max) / 2; 
		if (vName[mid] == sSearch) 
		{
			return mid; 
		}
		else if (vName[mid] < sSearch) 
		{
			return binarySearchName(vName, sSearch, mid + 1, max); 
		}
		else 
			return binarySearchName(vName, sSearch, min, mid - 1); 
	}
	return -1;
}

[Cody0023]

my guess is this thing you're doing with getline.

getline(cin>>variable,variable)

[Sawrana]

I've tried going through it with F11 step into and F10 step over watching the values of everything and it seems that everything loads correctly. the variable sSearchI contains whatever the user inputs and the vector vID has said variable when the compiler gets to the if(binary_search) statement it simply tests and moves on even though its in there.

The problem seems to be when i add case A. Please ignore/remove this thread