Why won't this validate my input for values between 0-10?

[samintheoc]

Hi,
I am having trouble with this input validation code. When I input values of the designated range (0-10) the first time through this loop it allows the program to continue down as it should, but when I enter an input not in the range like -1, 11, or a it invalidates it and prompts me to reenter. At this point when I enter a number that is 0-10 it still invalidates it and prompts me to reenter. Stays in an infinite loop. Can't figure it out. Please help!
(65-72)

#include <iostream>
#include <string>

using namespace std;

int main()
{
	int i1 = 0;
	int i2 = 1;
	double score = 0;
	double scorenew = 0;
	double highestscore;
	double lowestscore;
	string name;
	string city;
	char prompt;
	double dod = 0;
	double overall;
	double average;
	double totaloverall = 0;
	int s = 1;


	cout << "Diving competitor's scores/information organizer" << endl;

	cout << "Enter information of diver? ";

	cin >> prompt;

	cout << endl;

	if (prompt != 'y')
	{
		return 0;
	}
	else

		cout << "Enter the divers name: ";

	cin >> name;

	cout << endl;

	cout << "Enter the diver's city: ";

	cin >> city;

	cout << endl;

	//prompt user to enter values

	while (prompt == 'y')//if user enters "y" the logic within is executed
	{
		i2 = 1;
		score = 0;
		highestscore = 0;
		lowestscore = 10;
		while (i2 <= 5)
		{

			cout << "Enter score given by judge #" << i2 << "\t";

			cin >> scorenew;

			while (!(0 <= scorenew && scorenew <= 10) || cin.fail())
			{
				cout << "Invalid. Please enter a number 1-10\n";
				cin.clear();
				cin.ignore(20, '\n');
			}

			cout << "\n";

			//input validation for score 



			score = score + scorenew;

			cout << score << "\n";

			i2 = i2 + 1;

			cout << i2 << "\n";

			if (scorenew >= highestscore)
			{
				highestscore = scorenew;
			}
			if (scorenew <= lowestscore)
			{
				lowestscore = scorenew;
			}


			cout << highestscore << "\n";
			cout << lowestscore << "\n";
		}

		cout << "Enter degree of difficulty: ";

		cin >> dod;


		cout << endl;




		overall = (score - (highestscore + lowestscore))*dod;

		cout << "Diver: " << name << ", City: " << city << "\n\n";

		cout << "Overall score was: " << overall << "\n";

		i1 = i1 + 1;

		totaloverall = totaloverall + overall;

		cout << "\n";

		cout << totaloverall;

		cout << "Enter information of diver? ";

		cin >> prompt;

		cout << endl;

		average = totaloverall / i1;

		cout << "\tEvent Summary" << "\n\n";

		cout << "Number of divers participating: " << i1 << "\n\n";

		cout << "Average score of all divers: " << average;

	}

	system("pause");

	return 0;


}

[anup30]

did it compile ?

[samintheoc]

everything compiles. I cut this out of a larger bit of code. I thought this would be more appropriate. Should I post all the code?

[anup30]

as i see your above code: i2 is not declared, and return0; --> return 0;

[samintheoc]

Between lines lines 63-72 is where I am having trouble. This part

cin >> scorenew;

			while (!(0 <= scorenew && scorenew <= 10) || cin.fail())
			{
				cout << "Invalid. Please enter a number 1-10\n";
				cin.clear();
				cin.ignore(20, '\n');
			}

			cout << "\n";

[Peter87]

You never never try to get a new value for scorenew from cin inside the loop.

[PCrumley48]

I know some folks don't like the

do
{ 
     //some statements;
}while (condition)

construction, but in this case it could be a good thing. Put your conditions after the block, and put this:

cout << "Enter score given by judge #" << i2 << "\t";
cin >> scorenew;

inside the block. Use a logical flag bool retry = false; before the block, and use it to decide whether to print the error message or not by setting it true inside the block:

like this:

bool retry = false // first run through the loop you get a free pass; no error

do 
{ 
      if (retry) cout << "You are wrong; please try again" << endl;
      retry = true; // after first time you get the error message until you get it right.
      cout << "Enter a valid. . .";
      cin >> value_being_entered;
}while (conditions_not_met);

The error message will only display on second and following retries.

[samintheoc]

Thank you PCrumley48, Peter 87, and anup30 for your helpful comments.