C++ help needed: Infinite loop

[cookie123]

The program should properly display a box of the given link. However, the box keeps going on for infinite. I've tried multiple things, none of which worked. I had to move my code around and take the function prototypes out because I kept getting a compilation error when I used them. I can't seem to figure out the issue and this program is due tonight.

#include <iostream>
using namespace std;

//Global Constants
const int MINDIM = 2;
const int MAXDIM = 20;
//Function Prototypes
/*int Intro(const int, const int);
char AskSymbol();
int AskSizes(int, int);
void TopBot(char, int);
void Slice (char, int);
*/

//Display the program title and intro
int Intro(int MIN, const int MAX)
{
       cout
       << "BOX DISPLAYING PROGRAM"
       << endl << endl
       << "This program will display a rectangle made from a symbol"
       << endl
       << "specified by the user and of a width  and depth specified"
       << endl 
       << "by the user. The program will accept user input of width"
       << endl
       << "and depth values between " << MINDIM << "and " << MAXDIM << " (inclusive) only."
       << endl << endl;
}

//Request and return a symbol to be used to display the rectangle
char AskSymbol()    
{
       //Local Variables of AskSymbol
       char S;
       int WIDE, DEEP;
       //Request and store S
       cout << "Symbol to display? ";
       cin >> S;
       return S;       //Return S to main
}

//Request and return only valid width & depth values between 2 and 20 inclusive.
int AskSizes(int MIN, int MAX, int*WPTR, int *DPTR)    
{
    //Local Variables of AskSizes
     int W, D;
     do
     {
            if (MIN > W && W > MAX)
            {
                  cout 
                  << "INVALID ENTRY: Enter a value between 2 and 20 inclusive - "
                  << "\a";
            }
             
            {
                  cout
                  << "Width (2-20)?";
                  cin >> W;
            }
     }
       while ( MIN > W && W > MAX );
       
    cout
    << "Depth (2-20)?";
    cin >> D;
    

    while  ( MIN > D && D > MAX);
    {
           cout << "INVALID ENTRY: Enter a value between 2 and 20 inclusive - "
           << "\a"
           << "Depth (2-20)?";
           cin >> D;
    }
     *DPTR = D;
     *WPTR = W;
    
}

//Display a line made from the passed-in symbol by repeating it the passed-in width times.
void TopBot(char S, int W)      
{
     int I;       //counting loop index
     for (I = 1; I <= W; I++)
     {
         cout << S;
         I++;
     }
     cout << endl;
}

//Display a line of (2 less than the passed-in width) spaces, with the passed-in symbol on both ends.
void Slice(char S, int W)    
{
     int I = 1;
     cout << S;
     for (I=1; I <=( W- 2); I++) //check
     {
         cout << " ";
     I ++;
     }
     cout << S << endl;
}


//Creates the rectangle
int main ()
{
    //Variables
    char SYMB;
    int C, WIDE, DEEP;
    
    Intro(MINDIM, MAXDIM);                     //Pass MINDIM and MAXDIM to the Intro function
    SYMB = AskSymbol();                       //Return the value from AskSymbol to the variable SYMB
    AskSizes (MINDIM, MAXDIM, &WIDE, &DEEP);  //Return WIDE and DEEP  
    cout << endl;
    TopBot(SYMB, WIDE);
    C = 1;
    while (C <= (DEEP-2))
    {
       Slice(SYMB, WIDE);
       C + 1;
    }
    TopBot(SYMB, WIDE);
    system ("pause");
    return 0;
}

[AbstractionAnon]

Line 124 does nothing, therefore C is never incremented resulting in an infinite loop.

Change line 124:

 
    C++;

[SECMoG1T]

Line 70 too can also be an infinite loop if D satisfies the conditions, remove the semicolon.

[cookie123]

@AbstractionAnon C++ and C + 1 both increment C by 1. They are interchangeable.

@andy1992 I somehow skipped over the semicolon.

Thank you both so much! You both helped me lots. I realized the && was illogical in the loop and switched to || so that solved the final issue.


Thanks :)

[AbstractionAnon]

@AbstractionAnon C++ and C + 1 both increment C by 1. They are interchangeable.

No they are not the same.

C + 1 calculates the sum of C and 1 but does not store the result anywhere, therefore the statement C+1 by itself accomplishes nothing.

The following is equivalent to C++;

  C = C + 1;  // Add and store the result back into C