Streams & files

[igoreshka3333]

Hey there! The program below are supposed to take as an argument a few files and place them in a vector. Then creates the file and writes the text of incoming files. But the command line I run the exe, it writes - work program stopped ... What can u advice?

  #include <iostream>
#include <fstream>
#include <string>
#include <vector>

class Concatenation
{

private:

    int m_numbFiles;

    std::vector<std::string> m_OutputFile;

    std::ifstream m_ArrIstreams[];

    std::string m_ArrStrIn;

public:

    Concatenation( int, char*[] );
    void to_buffer();
    void output_file();

};

//--------------------------------------------------------

int main( int argc, char* argv[] )
{

    Concatenation C( argc, argv );

    C.to_buffer();
    C.output_file();

    std::system( "pause" );

    return 0;
}

//--------------------------------------------------------------

Concatenation::Concatenation( int argc, char* argv[] ) :
    m_numbFiles( argc )
{
    const int SIZE = 100;

    std::ifstream m_ArrIstreams[SIZE];

    for( int i=1; i<argc; i++ )
    {

        m_ArrIstreams[i-1].open( argv[i] ); 

        if( !argv[i] ){
            std::cerr << "Error: unable to open file!" << argv[i] << std::endl;
            m_isOpenAllFiles = false;
        }
    }
}
//----------------------------------------------------------------
void Concatenation::to_buffer()
{

    for( int i=0; i<m_numbFiles-1; i++ )
    {
        while( std::getline( m_ArrIstreams[i], m_ArrStrIn ) ){
            m_OutputFile.push_back( m_ArrStrIn );
            m_OutputFile.push_back( "\n " );
        }
    }
}
//---------------------------------------------------------------
void Concatenation::output_file()
{
    std::ofstream m_Ostream( "OutputFile.TXT" );

    for( int i=0; i<m_OutputFile.size(); i++ ){
        m_Ostream << m_OutputFile[i];
    }

    std::cout << "The file is recorded!" << std::endl;
}

[rafae11]

your code does not compile on my machine.
i made a few changes
i just store the string open the file when you call to buffer.

// gives me an error
 std::ifstream m_ArrIstreams[];

// is undefined
m_isOpenAllFiles 

#include <iostream>
#include <fstream>
#include <string>
#include <vector>

class Concatenation
{

private:

    int m_numbFiles;

	bool m_isOpenAllFiles;

	std::vector<std::string> m_fileArray;
    std::vector<std::string> m_OutputFile;

    std::string m_ArrStrIn;

public:

    Concatenation( int, char*[] );
    void to_buffer();
    void output_file();

};

//--------------------------------------------------------

int main( int argc, char* argv[] )
{

    Concatenation C( argc, argv );

    C.to_buffer();
    C.output_file();

    std::system( "pause" );

    return 0;
}

//--------------------------------------------------------------

Concatenation::Concatenation( int argc, char* argv[] ) :
    m_numbFiles( argc )
{
    // check if files open
	
    for( int i=1; i<argc; i++ )
    {		
		m_fileArray.push_back(argv[i]);

		std::ifstream fs;
		fs.open(m_fileArray[i-1].c_str());

		 if (fs.is_open())
		  {
			std::cout << "File successfully open" << std::endl;
			fs.close();
		  }
		  else
		  {
			std::cout << "Error opening file" << std::endl;
		  }		
    }

	
}
//----------------------------------------------------------------
void Concatenation::to_buffer()
{
	for (auto fs : m_fileArray)
	{
		std::ifstream file;
		file.open(fs);

		if(file.is_open())
		{
			for( int i=0; i < m_numbFiles-1; i++ )
			{
				while( std::getline( file, m_ArrStrIn ) ){
					m_OutputFile.push_back( m_ArrStrIn );
					m_OutputFile.push_back( "\n " );
				}
			}
		}
	}
}
//---------------------------------------------------------------
void Concatenation::output_file()
{
    std::ofstream m_Ostream( "OutputFile.TXT" );

    for( int i=0; i<m_OutputFile.size(); i++ ){
        m_Ostream << m_OutputFile[i];
    }

    std::cout << "The file is recorded!" << std::endl;
}

[igoreshka3333]

Thanks, but it write: syntax error!

for (auto fs : m_fileArray)

[rafae11]

just change it to an index loop.

void Concatenation::to_buffer()
{
	for (int iter = 0; iter < m_fileArray.size(); iter++ )
	{
		std::ifstream file;
		file.open(m_fileArray[iter]);

		if(file.is_open())
		{
			for( int i=0; i < m_numbFiles-1; i++ )
			{
				while( std::getline( file, m_ArrStrIn ) ){
					m_OutputFile.push_back( m_ArrStrIn );
					m_OutputFile.push_back( "\n " );
				}
			}
		}
	}
}

[igoreshka3333]

Thanks a lot)
I have tried to do as you. Already without errors, but id doesn't record file(((((

[shadowCODE]

Works. Did a little change though.

#include <iostream>
#include <fstream>
#include <string>
#include <vector>
#include <cstdlib>

class Concatenation
{

private:

    int m_numbFiles;

	bool m_isOpenAllFiles;

	std::vector<std::string> m_fileArray;
    std::vector<std::string> m_OutputFile;

    std::string m_ArrStrIn;

public:

    Concatenation( int, char*[] );
    void to_buffer();
    void output_file();

};

//--------------------------------------------------------

int main( int argc, char* argv[] )
{

    Concatenation C( argc, argv );

    C.to_buffer();
    C.output_file();

    system( "pause" );   //change from std::system()..
                  // system is not in namespace std. its a system call

    return 0;
}

//--------------------------------------------------------------

Concatenation::Concatenation( int argc, char* argv[] ) :
    m_numbFiles( argc )
{
    // check if files open
	
    for( int i=1; i<argc; i++ )
    {		
		m_fileArray.push_back(argv[i]);

		std::ifstream fs;
		fs.open(m_fileArray[i-1].c_str());

		 if (fs.is_open())
		  {
			std::cout << "File successfully open" << std::endl;
			fs.close();
		  }
		  else
		  {
			std::cout << "Error opening file" << std::endl;
		  }		
    }

	
}
//----------------------------------------------------------------
void Concatenation::to_buffer()
{
	for (auto fs : m_fileArray)
	{
		std::ifstream file;
		file.open(fs);

		if(file.is_open())
		{
			for( int i=0; i < m_numbFiles-1; i++ )
			{
				while( std::getline( file, m_ArrStrIn ) ){
					m_OutputFile.push_back( m_ArrStrIn );
					m_OutputFile.push_back( "\n " );
				}
			}
		}
	}
}
//---------------------------------------------------------------
void Concatenation::output_file()
{
    std::ofstream m_Ostream( "OutputFile.TXT" );

    for( int i=0; i<m_OutputFile.size(); i++ ){
        m_Ostream << m_OutputFile[i];
    }

    std::cout << "The file is recorded!" << std::endl;
}

g++ -o test test.cpp -std=c++11  //compile
test test.cpp test.xml  //concatenate the 2 files in OutputFile.txt 

[igoreshka3333]

Thank u!