Magic Square help!

[alex067]

I have to write a program which checks the conditions of this specific 2D array:
const int Size = 3;
int a[][Size] = { { 4, 9, 2 }, { 3, 5, 7 }, { 8, 1, 6 } };


This is a magic square, as each row, col, and diagonal sum equals 15.

However, my program says that it is not a magic square, so there is an issue in the condition check.

#include <iostream>
#include <cmath>
using namespace std;

const int Size = 3;
bool isMagic(const int inArray[][Size]);

int main()
{
	int a[][Size] = { { 4, 9, 2 }, { 3, 5, 7 }, { 8, 1, 6 } }; //initially, 3 rows 3 cols

	if (isMagic(a))
	{
		cout << "This is a magic square" << endl;
	}
	else
	{
		cout << "This is NOT a magic square :(" << endl;
	}

	system("PAUSE");
	return 0;
}
bool isMagic(const int inArray[][Size])
{
	int MagicTotal;
	MagicTotal = Size*(pow(Size, 2) + 1) / 2.0;
	cout << "The magic square sum is: " << MagicTotal << endl;
	int condition;
	condition = 0;

	for (int i = 0; i < Size; i++)
	{
		for (int j = 0; j < Size; j++)
		{
			condition += inArray[i][j];
			if (condition == MagicTotal)
			{
				return true;
			}
			else
			{
				return false;
			}
		}
	}
}

[ne555]

you've got

for()
   for()
      if() return
      else return

you are stopping at the first iteration

please comment your code describing your approach

[alex067]

Is it stopping at the first iteration because its checking for the boolean condition?

I'm trying to construct the nested for loop and the condition variable where the condition variable is the total sum of the rows and columns

so condition =
row[0]col[0] + row[0]+col[1]+row[0]+col[2] = 15

Then the next condition is =
row[1]col[0]+row[1]+col[1]+row[1]+col[2] = 15

basically i'm checking if the sum of all rows, columns, and diagnols = 15

[alex067]

need urgent help!

[Texan40]

Think about the iterations. If you find a magic you want to immediately return true. When would you want to return false?

[OxBADC0DE]

Hasn't that been answered already?

for( int x = 0; x != Size; ++x ){
    for( int y = 0; y != Size; ++y ){
        condition += whatever[x][y];
    }
    if( condition != magicSum ) return false;
    condition = 0;
}
//if you get here, it means you have a magic strand or whatever you call it 

It should be quite obvious what part of your code you have to make changes to.