Help my readName doesnt work

[michael1320]

Ok so Sorry for the huge code. But I am almost finished with it. I am a beginner so there are a few bugs to work out. I am having trouble with my char readName(char name[])function. Its supposed to ask for your name and then post it at the bottom later. When I get to the last part my program crashes. I am positive the crash has something to do with the readName function or in the displayResults function. Thanks everyone for your help on my project.

#include <stdio.h>
#include <stdlib.h>

/* NOTE you can't change my main */

const int MAX = 100;
const int ASSIGN_TOTAL = 7, QUIZ_TOTAL = 3, EXAMS_TOTAL = 2;
const int ASSIGN_MAX = 100, QUIZ_MAX = 25, EXAMS_MAX = 100, FINAL_MAX = 100;

char readName(char name[]);
float fillArray(int x[], int num, int k);
int goAgain();
int selectionSort(int myScore[], int total);
int findMedian(int myPapery[], int num);
int findMean(int myPaperx[], int num);
float calcPercentage(int papers[], int total, int max);
float readFinalScore();
float calcfinalPercentage(int exam, int max1);
float calcGrade(double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc);
float calcClassPerc(double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc);
displayResults(char name, double classPerc, double classGrade,
                       double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc,
                       double assignsMean, double quizzesMean, double examsMean,
                       double assignsMedian, double quizzesMedian, double examsMedian);

int main()
{
    char name[MAX];
    int assigns[ASSIGN_TOTAL], quizzes[QUIZ_TOTAL], exams[EXAMS_TOTAL], finalExam;
    double assignsMedian, assignsMean, assignsPerc;
    double quizzesMedian, quizzesMean, quizzesPerc;
    double examsMedian, examsMean, examsPerc, finalPerc, classPerc, classGrade;

    do
    {
        readName(name);

        fillArray(assigns, ASSIGN_TOTAL, "assignments");
        selectionSort(assigns, ASSIGN_TOTAL);
        assignsMedian = findMedian(assigns, ASSIGN_TOTAL);
        assignsMean = findMean(assigns, ASSIGN_TOTAL);
        assignsPerc = calcPercentage(assigns, ASSIGN_TOTAL, ASSIGN_MAX);


        fillArray(quizzes, QUIZ_TOTAL, "quizzes");
        selectionSort(quizzes, QUIZ_TOTAL);
        quizzesMedian = findMedian(quizzes, QUIZ_TOTAL);
        quizzesMean = findMean(quizzes, QUIZ_TOTAL);
        quizzesPerc = calcPercentage(quizzes, QUIZ_TOTAL, QUIZ_MAX);


        fillArray(exams, EXAMS_TOTAL, "exams");
        selectionSort(exams, EXAMS_TOTAL);
        examsMedian = findMedian(exams, EXAMS_TOTAL);
        examsMean = findMean(exams, EXAMS_TOTAL);
        examsPerc = calcPercentage(exams, EXAMS_TOTAL, EXAMS_MAX);


        finalExam = readFinalScore();
        finalPerc = calcfinalPercentage(finalExam, FINAL_MAX);

        classPerc = calcClassPerc(assignsPerc, quizzesPerc, examsPerc, finalPerc);
        classGrade = calcGrade(assignsPerc, quizzesPerc, examsPerc, finalPerc);

        displayResults(name, classPerc, classGrade,
                       assignsPerc, quizzesPerc, examsPerc, finalPerc,
                       assignsMean, quizzesMean, examsMean,
                       assignsMedian, quizzesMedian, examsMedian);

    }while(goAgain());

    return 0;
}

//**************************************************************************************//

char readName(char name[])

{
    printf("\nName: ");
    gets(name);

    return;
}

//**************************************************************************************//

float fillArray(int x[], int num, int k)

{
    int i;

    for(i = 0; i < num; i++)
    {
        printf("\nScore for %s %d: ", k, i+1);
        scanf(" %d", &x[i]);
    }
}

//**************************************************************************************//

int goAgain()

{
    char answer;

    printf("\nWould you like to calculate another set of scores (Y/N) ");
    scanf(" %c", &answer);

    if(answer != 'n' && answer != 'N')
       {
           return answer;
       }
    else
        {
            return 0;
        }
}

//**************************************************************************************//

int selectionSort(int myScore[], int total)

{  int  lim,
        hole;

   for ( lim = 1 ; lim < total ; lim++ )      //Credit Tim Rolfe
   {  int save = myScore[lim];              //Lecture 02-12-2015 Chapter 23 Sorting Arrays

      for ( hole = lim ;

            hole > 0 && save < myScore[hole-1] ;
            hole-- )
      {  myScore[hole] = myScore[hole-1];  }

      myScore[hole] = save;
   }
}

//**************************************************************************************//

int findMedian(int myPapery[], int num)

{
    int middle1, middle2, i;
    float median, median2;

    middle1 = num / 2;
    middle2 = (num/2)-1;

    if ((num % 2) == 0)
    {
        median = (myPapery[middle1] + myPapery[(middle2)]);
        median = median /2;
    }
    else
    {
        median = myPapery[middle1 + 0] / 1;
    }
return median;
}

//**************************************************************************************//

int findMean(int myPaperx[], int num)

{
    int i, sum;
    float sum1;

    for(sum = i = 0; i < num; i++)
    {
        sum += myPaperx[i];
        sum1 = (float)sum / num;
    }

    return sum1;
}

//**************************************************************************************//

float calcPercentage(int papers[], int total, int max)

{
    int i, sum;
    float perc;

    for(sum = i = 0; i < total; i++)
    {
        sum += papers[i];
        perc = (((float)sum/(total*max))*100);
    }
    printf(" SUM: %d\n", sum);
    printf(" PERC: %f\n", perc);

    return perc;
}

//**************************************************************************************//

float readFinalScore(int last)

{
    printf("\nScore for Final Exam: ");
    scanf(" %d", &last);

    return last;
}

//**************************************************************************************//

float calcfinalPercentage(int exam, int max1)

{
    float sum;
    sum = (((float)exam/max1)*100);
    printf("\n %f", sum);

    return sum;
}

//**************************************************************************************//


float calcClassPerc(double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc)

{
    double grade1, grade2, grade3, grade4, overallGrade;

    grade1 = (assignsPerc * 0.40);
    grade2 = (quizzesPerc * 0.10);
    grade3 = (examsPerc * 0.25);
    grade4 = (finalPerc * 0.25);
    overallGrade = (grade1 + grade2 + grade3 + grade4);

return overallGrade;
}

//**************************************************************************************//

float calcGrade(double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc)

{
    double grade, grade1, grade2, grade3, grade4, overallGrade, x, sum1, sum;
    grade1 = (assignsPerc * 0.40);
    grade2 = (quizzesPerc * 0.10);
    grade3 = (examsPerc * 0.25);
    grade4 = (finalPerc * 0.25);
    overallGrade = (grade1 + grade2 + grade3 + grade4);

    if (overallGrade >= 95)
    {
        grade = 4.0;
    }
    else
    {
        sum = 95 - overallGrade;
        sum1 = sum/10;
        grade = 4.0 - sum1;
    }

    return grade;
}

//**************************************************************************************//

displayResults(char name, double classPerc, double classGrade,
                       double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc,
                       double assignsMean, double quizzesMean, double examsMean,
                       double assignsMedian, double quizzesMedian, double examsMedian)

{

    printf("\nPercentage per category:");
    printf("\n\nAssignments: %.0lf%%", assignsPerc);
    printf("\n\nQuizzes: %.0f%%", quizzesPerc);
    printf("\n\nExams: %.0f%%", examsPerc);
    printf("\n\nFinal Exam: %.0f%%", finalPerc);
    printf("\n %s:", name);
    printf("\n\nYour weighted percentage is: %.0f%% ", classPerc);
    printf("\n\nYour Grade point is %.1f", classGrade);
    printf("\n\nFor assignments the average score was %.0lf and the median score was %.0lf\n", assignsMean, assignsMedian);
    printf("\nFor quizzes the average score was %.0lf and the median score was %.0lf\n", quizzesMean, quizzesMedian);
    printf("\nFor exams the average score was %.0lf and the median score was %.0lf\n", examsMean, examsMedian);

}

[TarikNeaj]

char readName(char name[])

{
    printf("\nName: ");
    gets(name);

    return;
}

The function doesnt return anything. It has to return something, you probably want

return* name;

[michael1320]

P
Ok so I fixed the return but the program still crashes.

char readName(char name[])

{
    printf("\nName: ");
    gets(name);

    return name;
}

[TarikNeaj]

First of all. You didint do as I told you. I said

return* name

.

Also, can you provide more information? Whats the error? When does it crash?

[michael1320]

I actually tied the return* name; but it didn't do anything different. It crashes when the display results gets to the print name part.

displayResults(char name, double classPerc, double classGrade,
                       double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc,
                       double assignsMean, double quizzesMean, double examsMean,
                       double assignsMedian, double quizzesMedian, double examsMedian)

{

    printf("\nPercentage per category:");
    printf("\n\nAssignments: %.0lf%%", assignsPerc);
    printf("\n\nQuizzes: %.0f%%", quizzesPerc);
    printf("\n\nExams: %.0f%%", examsPerc);
    printf("\n\nFinal Exam: %.0f%%", finalPerc);
    printf("\n %s:", name);

[michael1320]

Ok so I figured out my problem.

displayResults(char name, double classPerc, double classGrade,
                       double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc,
                       double assignsMean, double quizzesMean, double examsMean,
                       double assignsMedian, double quizzesMedian, double examsMedian)

name needed to be a pointer.

displayResults(char *name, double classPerc, double classGrade,
                       double assignsPerc, double quizzesPerc, double examsPerc, double finalPerc,
                       double assignsMean, double quizzesMean, double examsMean,
                       double assignsMedian, double quizzesMedian, double examsMedian)

But the only thing I have a problem with now is that when I say yes to go again. It skips over name and goes straight to entering the first assignment.

[michael1320]

Bump?