Random numbers in a array

[SCB3]

so in a minesweeper game, I am trying to set the mines on the array to be random, but this function just crashes the compiler

now minesweeper[row][col] is set as minesweeper[8][8] and -1 is the number on the array for a mine

void mine_set()
{ 
   int minesetter = 0;
do
	{
		row=rand()%row;
		col=rand()%col;
		if (minesweeper[row][col] !=-1)
			{
			minesweeper[row][col]=space;
			mines++;
			}
	}
		while (minesetter<mines); 
}

[Peter87]

Crashes the compiler? You mean it gives you a compiler error? In that case it would be very helpful if you posted it.

If it crashes at runtime I would suspect row and col to be set incorrectly. Make sure they have the same value as the dimensions of the game board.

If mines start out below zero the loop will never run.
If mines start out above zero the loop will never stop.
Are you sure you want to increment mines inside the loop?

[fg109]

If it's a compiler error, I suspect that row and col are supposed to be const int variables.

[SCB3]

The compiler runs the game, but when I select to play that board, it freezes

I'll try setting them as const ints next

[coder777]

Lines 6/7 should look something like this:

		row=rand()%8; // Note: The maximum allowed number
		col=rand()%8; // Note: The maximum allowed number 

[SCB3]

set as const ints, same issue, can get into the main menu, freezes on selecting it, if I take out the Random function though, it works fine, so obviously there's something wrong there

[coder777]

Well, minesetter never changes, it remains 0. mines might increase. So as Peter87 said you'll have an infinite loop that freezes your program

[SCB3]

oh so minesetter needs to be a global int? or am I missing something there?

[coder777]

oh so minesetter needs to be a global int?

Nope, global variable should be only the last resort. Pass it as a parameter:

void mine_set(int minesetter)
{

mines is a global variable. I would be better to make it local and pass it as a parameter as well. Global variables tend to have surprising values...

This minesetter<mines doesn't make too much sense when mines only increases

[SCB3]

void mine_set(int minesetter, int mines=10)
{ 
   
do
	{
		row=rand()%8;
		col=rand()%8;
		if (minesweeper[row][col] !=mine)
			{
			minesweeper[row][col]=mine;
			mines--;		
			}
		
	}
		while (minesetter<mines);
	
}

so like this?

[SCB3]

so now I have that parameter set up


I get this error

C2660 " mine_set : function does not take 0 arguments"

what does that even mean?

[coder777]

When a function requires parameter you need to provide parameter. Without more context it's impossible to say what the problem is.

[fg109]

In my last post, I was suggesting that row and col were const int and that you were trying to change them in your code, which is illegal. Sorry if I wasn't clear.

Anyway, from the fact that they are not declared in your function, they must be global variables. Are they used in loop conditions when you populate your array?

If so, they really should be const int and this part

		row=rand()%8;
		col=rand()%8;
		if (minesweeper[row][col] !=mine)
			{
			minesweeper[row][col]=mine;

should be changed to

		int r=rand()%row;
		int c=rand()%col;
		if (minesweeper[r][c] !=mine)
			{
			minesweeper[r][c]=mine;

[SCB3]

now when I've changed it I get

First-chance exception at 0x00D1982E in Project5.exe: 0xC0000094: Integer division by zero.

If there is a handler for this exception, the program may be safely continued.

[fg109]

You need to post your whole code.

[SCB3]

ok, here it is (I cut out the other difficulties for now)

#include<iostream>
#include<iomanip>
#include <stdio.h>      
#include <stdlib.h>     
#include <time.h>
#include <ctime>
#include<fstream>
using namespace std;
unsigned int Time = time(0);


int minesweeper[8][8];
						
int minesweeperI[16][16];
int minesweeperE[24][24];
char game[8][8];
char gameI[16][16];
char gameE[24][24];
int minesetter; 
int mines=0;
int guesses=0;
int row, col;
char square = 178, mine = 153,flag=214, rowline=179,space=' ';
char userchoice;
char play_again;


void initialise()
{
	int row,col;
	for (row=0;row<8;row++)
		for(col=0;col<8;col++)
			game[row][col]=square;


void mine_set()
{ 
   
do
	{
		int r=rand()%row;
		int c=rand()%col;
		if (minesweeper[r][c] !=mine)
			{
			minesweeper[r][c]=mine;
			mines--;		
			}
		
	}
		while (mines<10);
	
}



void drawGridB()
{    
	cout<<setw(18)<<"|0|1|2|3|4|5|6|7|"<<endl;
	
	
   for (row=0;row<8;row++)
	{
		cout<<setw(2)<<"------------------"<<endl;
		cout<<row<<rowline;
		for(col=0;col<8;col++)
			
		{
			
			cout<<game[row][col]<<rowline;
		}
			
		cout<<endl;
			
		}	
   cout<<setw(2)<<"------------------"<<endl<<endl;
}
	

void playB()//this is for the beginners game
{	
	 int score = 0;
	 guesses=0; 
	 initialise();
	 mine_set();

	do
	{ 
		
		drawGridB();		
		cout<<endl<<setw(6)<<"Score = "<<score<<endl<<endl;
		cout<<setw(6)<<"Guesses = "<<guesses<<endl<<endl;
		cout << "Please enter the Vertical number" << endl;
		cin >> col;
		cout << "Now enter the Horizontal number" << endl;
		cin >> row;

			if (row>=8||col>=8)
			{
				cout << "You have entered an invalid choice." << endl;
			}
			else
			{
				cout << "Do you want to dig(d) or flag for a bomb here(f)?" << endl;
				cin >> userchoice;

			if (game[row][col]=space)
				{
					cout<<"You have entered a invalid choice"<<endl;
				}
			//else if (game[row][col]=flag);
			//	{
			//		cout<<"You will now Dig at these coordinates"<<endl;
			//		game[row][col]=space;
			//	}

			if (userchoice == 'd' && minesweeper[row][col]==-1||guesses==65)
			{
				cout << "BOOM!!" << endl;
				cout << "You have hit a mine" << endl;
				cout<<"Score = "<<score<<endl;
				cout<<"Guesses ="<<guesses<<endl;
				cout << "Please Play again" << endl;
				game[row][col]=mine;
			}
			else if (userchoice == 'd' && minesweeper[row][col] == 0)
					{
						game[row][col]=' ';
						guesses++;
						score++;
						cout<<userchoice<<endl;
						
					}
			else if(userchoice=='d'&&minesweeper[row][col]==1)
					{
						game[row][col]='1';
						score++;
						guesses++;
						cout<<userchoice<<endl;;
						cout<<endl<<setw(6)<<"Score = "<<score<<endl<<endl;
						cout<<setw(6)<<"Guesses = "<<guesses<<endl<<endl;
					}
			else if (userchoice=='d'&&minesweeper[row][col]==2)
					{
						game[row][col]='2';
						guesses++;
						score++;
						cout<<userchoice<<endl;
						cout<<endl<<setw(6)<<"Score = "<<score<<endl<<endl;
						cout<<setw(6)<<"Guesses = "<<guesses<<endl<<endl;
					}
			else if (userchoice=='d'&&minesweeper[row][col]==3)
					{
						game[row][col]='3';
						guesses++;
						score++;
						cout<<userchoice<<endl;
						cout<<endl<<setw(6)<<"Score = "<<score<<endl<<endl;
						cout<<setw(6)<<"Guesses = "<<guesses<<endl<<endl;
					}
				else if (userchoice == 'f')
						{
							game[row][col]=flag;
							guesses++;
							
						}
			drawGridB();
		}
  }
  while (guesses<64);


		/*if(guesses==mines)
			cout<<"Congratulations- You Win!!!!"<<endl<<endl;
		cout<<"would you like to play again? Yes or No"<<endl;
		cin>>play_again;
		if ("yes")
			playB();
		else if ("No")
			playB();*/
}


				cin>>option;
				cout<<endl;
				cin.ignore();
				switch(option)
				{
				case '1':playB();
						break;
				




void main()//start of the program, fully compiled
{
		displaymenu();
		srand(time(NULL));
		system("pause");
	
}

[Peter87]

Your code is messed up. It looks like mine_set() is being defined inside initialise() because there is no ending }, and lines 183-189? Copy paste error?

[SCB3]

yea, I musta missed that part when I copied it, its there in the original code

183-189 is part of my main menu, thats the part that starts the game, I left the rest out as it's not relevant, but wanted to include that part as it starts after selecting option 1

[coder777]

On line 41/42 you use the global variables form line 22. But since they permanently change (like on line 93/95, 61/65) you cannot predict what the value is.

[SCB3]

So, how can I rectify that? Change the names of them? Set them as local variables?