Linked List: Inserting Value at the End

[abdalimran]

I've written as follows:

#include <bits/stdc++.h>

using namespace std;

struct Node
{
    int Data;
    Node* Next;
};

Node* Head;

void InsertEnd(int num)
{
    Node *NewNode;
    NewNode=new Node;
    NewNode->Data=num;
    NewNode->Next=NULL;

    Node* EndNode;
    EndNode=Head;

    if(EndNode == NULL)
       EndNode=NewNode;
    else
    {
        while(EndNode->Next!=NULL)
            EndNode=EndNode->Next;
        EndNode=NewNode;

    }
}

void PrintList()
{
	Node* NewNode=Head;
	cout<<"List is: ";
	while(NewNode!=NULL)
	{
		cout<<NewNode->Data<<" ";
		NewNode=NewNode->Next;
	}
	cout<<endl;
}

int main()
{
    Head=NULL;
    InsertEnd(90);
    InsertEnd(80);
    PrintList();

    return 0;
}

It doesn't work. Where is the problem?

[LaboPie]

First of all what does this include do?

#include <bits/stdc++.h>

As how the code is now, seems that do nothing.

This include instead

#include <iostream>

is missing and you need it if you want to use the cout.

Then after this, you do not change Head, that in this way is always init to NULL (btw use nullptr instead of NULL).

[SECMoG1T]

void InsertEnd(int num)
{
    Node *NewNode;
    NewNode=new Node;
    NewNode->Data=num;
    NewNode->Next=NULL;

    Node* EndNode;
    EndNode=Head;

    if(EndNode == NULL)
       EndNode=NewNode;
    else
    {
        while(EndNode->Next!=NULL)
            EndNode=EndNode->Next;
        ///by now EndNode->Next is equal to null
        EndNode->next=NewNode;///so this is what you need

    }
}