making this loop continue and q to quit

[bcav311]

I am trying to make this program keep asking for inputs to make new squares and also to stop when you hit q. i have tried different things but i keep getting errors. this will run but it stops due to the break. if the break is not there it will continue to run and not stop.

  #include <iostream>
using namespace std;

int main() {

	int size;
	int row;
	int col;
	int quit;

	cout <<"Please enter a number between 1 and 10: ";
	cin >> size;
	if (size < 0, size > 10)
        {
		cout <<"That is not a positive number, please try again!! " <<endl;
		cin >> size;
	    }


	while(true)
	{
		for (int row = 0; row < size; row++){

			for (int col = 0; col < size; col++){
				if (row==0 || row == (size-1) )
				{
					if (col == 0 || col == size - 1)
						cout <<  "-";
					else {

						cout << "-";
					} 

				}
				else if (col==0 || col == (size-1) )
					cout <<"|";
				else
					cout <<" ";
			}

			cout << endl;
		}
		cout << "Try again or press q to quit" << endl;


		break;


	}
	return 0;
}

[TarikNeaj]

if (size < 0, size > 10) // Doesnt work that way. You want to say if the size is less than 0 OR size is bigger than 10. Then you use the || operator.

if (size < 0 || size > 10)

if you want the user to enter quit, then you need a char variable, not integer.

char quit = 'a'; // initialize it to any other letter than q

while(quit != 'q')
{
      // Everything that you want repeated until q is pressed you put here. Remove the break.
}

[bcav311]

@tarikNeaj

ok i replaced true with the quit and here is the code but i'm getting invalid conversion from const char to char

#include <iostream>

using namespace std;

int main() {

	int size;
	int row;
	int col;
	char quit = "q";


	cout <<"Please enter a number between 1 and 10: ";
	cin >> size;
	if (size < 0 || size > 10)
        {
		cout <<"That is not a positive number, please try again!! " <<endl;
		cin >> size;
	    }


	while(quit != "q")
	{
		for (int row = 0; row < size; row++){

			for (int col = 0; col < size; col++){
				if (row==0 || row == (size-1) )
				{
					if (col == 0 || col == size - 1)
						cout <<  "-";
					else {

						cout << "-";
					}

				}
				else if (col==0 || col == (size-1) )
					cout <<"|";
				else
					cout <<" ";
			}

			cout << endl;
		}
		cout << "Try again or press q to quit" << endl;



	}
	return 0;
}

[TarikNeaj]

Thats becuase you didint look close enough.

while(quit != 'q') // ' ' not " "

[bcav311]

@Tarikneaj

ok same code I changed to sigle '' and it runs but after i input a number it just says press any key to continue. does not make my square . I moved the cout try again or press q into the main while statement

[TarikNeaj]

char quit = 'a'; // initialize it to any other letter than q

You gotta read things more carefully my friend

Edit: And dont forget to add a input at the end so the user can actually choose to enter q or not.

[bcav311]

ok i had to just start over i was getting my self lost. here is my new code and it does the same thing but a little shorter. only thing it does is when i hit q it will ask the enter a number from 1 to 10 over and over and will not close the program

#include<iostream>


using namespace std;
int main()
{
    int size ;
    char exit1;


do{
    cout<< "Enter a number from 1 to 10 or hit q to leave: \n";
    cin>>  size;



    if (size < 0 || size > 10)
        {
		cout <<"That is not a positive number, please try again!! " <<endl;
		cin >> size;
        }


  for(int width=1; width<=size; width++)
    {
   if(width <= 1)

   for(int width=1; width<=size; width++)
            {
                cout<< "-";
            }
        else if(width<size)
        {
            cout<< endl;
for(int width2=1; width2<=size; width2++)
            {
      if(width2==1 || width2==size)
                    cout<< "|";
                else
                    cout<< " ";
            }
        }
        else
        {
            cout<< endl;
for(int width3=1; width3<=size; width3++)
            {
                cout<<"-";

            }
        }
    }
    cout << endl;

}

while(exit1 != 'q' );


}

[TarikNeaj]

You never ask the user whether he wants to quit or not... you never use the variable exit1 to take input from the user.

[xenovia12]

only thing it does is when i hit q it will ask the enter a number from 1 to 10 over and over and will not close the program

   cout<< "Enter a number from 1 to 10 or hit q to leave: \n";
    cin>>  size;

size is an int type, what would you expect if you enter 'q'?
edit:

while(exit1 != 'q' );

this is okay but it will block the execution of program the moment you hit q and will not conitnue anymore