A code that needs to loop

[apurpledragon]

Here is the finalized code i came up with with your help. sorry for deleting the original problem didnt realize i wasnt supposed to do that.

#include <iomanip>
#include <stdio.h>
#include <iostream>
#include <math.h>
#include <string>
#include <stdlib.h>
using namespace std;

void pattern1();
void pattern2();
void pattern3();
void pattern4();

int main()
{
	bool bGettingInput = true;
	

	cout << "Welcome to pattern generator\n";
	cout << "Patterns can be sizes 2,3,4,5,6,7,8,9";
	cout << endl;

	
	while (bGettingInput)
	{
			int pattern, ready;
			cout << "1. pattern 1\n";
			cout << "2. pattern 2\n";
			cout << "3. pattern 3\n";
			cout << "4. pattern 4\n";
			cout << "enter your pattern choice\n";
			cin >> pattern;
			cout << "ready? Press 1 for yes Press any other key to quit\n";
			cin >> ready;
	
			if (ready == 1)
			{
				switch (pattern)
				{
				case 1:
					pattern1();
					break;
				case 2:
					pattern2();
					break;
				case 3:
					pattern3();
					break;
				case 4:
					pattern4();
					break;
				



				}
			

		}
			else
			break;
			

			

		}
		cout << "Exiting\n\n";
		cout << "Thanks for making patterns with me!!";
		cout << endl;
		cout << "press any key to continue...";
		cin.ignore();
		char ch = getchar();

	}

void pattern1()
{
	int size;
	cout << "enter pattern size\n";
	cin >> size;
	int i, j;
	if (size > 1 && size < 10)
	{
		for (i = 0; i < size; i++)
		{
			cout << endl;
			for (j = 0; j < size; j++)
			{
				if (i <= j)

					cout << size;
				else
					cout << "$";
			}
		}
		if (size <= 1 && size >= 10)
		{
			cout << "size error";
	}
	}
	cout << endl;
	cout << "\n\n";
}

void pattern2()
{
	int size;
	cout << "enter pattern size \n";
	cin >> size;
	int i, j;
	if (size > 1 && size < 10)
	{
		for (i = 0; i < size; i++)
		{
			cout << endl;
			for (j = 0; j < size; j++)
			{
				if (i <= j)

					cout << "$";
				else
					cout << size;
			}

		}
		if (size <= 1 && size >= 10)
		{
			cout << "size error";
		}
	}
	cout << endl;
	cout << "\n\n";
}
void pattern3()
{
	int size;
	cout << "enter pattern size \n";
	cin >> size;
	int i, j;
	if (size > 1 && size < 10)
	{
		for (i = 0; i < size; i++)
		{
			for (j = 0; j < size; j++)
				if (j == i)
					cout << size;
				else
					cout << "$";
			cout << endl;
		}

	}
	cout << endl;
	cout << "\n\n";
}
void pattern4()
{
	int size;
	cout << "enter pattern size \n";
	cin >> size;
	int i, j;
	if (size > 1 && size < 10)
	{
		for (i = size; i > 0; i--)
		{
			for (j = 0; j < size; j++)
				if (j == i)
					cout << size;
				else
					cout << "$";
			cout << endl;
		}

	}
	cout << endl;
	cout << "\n\n";


}

[koothkeeper]

You can try to set up a Boolean, such as this:

bool bGettingInput = true;


while( bGettingInput )
    {
    //    Put your code to get the input in this new while loop:

    //    Add this test in your switch statement:

        case 'q':
            bGettingInput = false;

            break;

    }    /*    while( bGettingInput )    */

That should do it?

[apurpledragon]

yesss thank you

[TheIdeasMan]

Please don't delete you r original post, it's considered rude :+)

[apurpledragon]

i reposted the code to correct that my bad for anyone who found that rude :) first time poster

[koothkeeper]

Well you didn't add the case 'q': statement, but what you do have should work anyway. I think what I suggested is a little more clearer.

[apurpledragon]

when i added the q statement it made an infinite loop for some reason whenever i tried to quit and im pretty sure it still infinitely loops when you try to quit if you run the program a certain amount of times before exiting

[koothkeeper]

I tested your code and added the case 'q' statement. It works for me. Where did you put the case 'q' statement?

[TheIdeasMan]

Hi,

One should also have a default: case to catch bad input.

Not sure what compiler you use, but here is some info to do with the gcc compiler:

There is a compiler option with gcc that enables a warning for this: -Wswitch-default

Also consider using an enum with a switch, and use the -Wswitch warning if there is no case for each of the enums. This is disabled if there is a default case though.

https://gcc.gnu.org/onlinedocs/gcc-5.2.0/gcc/Warning-Options.html#Warning-Options

Some other things:

Your main function could be made more tidy by having a function to print the menu. Even have a function to say goodbye if you want.

You could also have a function to get the size input and validate it, each pattern function can call this function. If you find yourself writing the same code over and over, then there is a better way :+)

If you set your editor to change tabs into spaces, your code will display better when you post it here. The problem with tabs is they get converted to 8 spaces.

Good Luck !! :+)

[apurpledragon]

seriously i learn more from you guys than i do in school its wonderful im gonna go back through and clean up this code. also im looking for the file i made to show you where i put the q statement. i am sure i put it in the wrong spot or somthing this was the very first code i had written .