help with a simple function

[leashbomb69]

Function int readHours() reads one or more hours worked by an employee in the week, computes their sum and returns it. The list of hours is terminated by the dummy value -99. Function main calls the function 3 times with input values and then prints the total number of hours

Im not getting a value returned after inputting a value, anyone see any mistakes ?

  #include<iostream>
using namespace std;
#define DUMMYVALUE -99
int readhours()
{
	int sum=0, hours;
	cin>>hours;
	while(hours != DUMMYVALUE);
	{
		sum+=hours;
		cin>>hours;	
	}
	return sum;
}
int main ()
{
	cout<<endl << "Number of hours:\t";
	cout<< readhours();
	cout<<endl<< "Number of hours:\t";
	cout<< readhours();
	cout<<endl<< "Number of hours:\t";
	cout<<readhours();
	return 0;
}

[48T7M4Gy]

line 8 has a problem with its colon. Surgery is required.

Also you don't need to duplicate all those lines after line 19.

[leashbomb69]

surgerey ? What is surgerey, and yes I do need to duplicate those lines, since it is calling the function 3 times.

[leashbomb69]

Omg, I see my error, thank you. you could have just mentioned the semi colon in line 8, lmfao.

[48T7M4Gy]

#include<iostream>

using namespace std;

#define DUMMYVALUE -99

int readhours()
{
	int sum = 0, hours = 0;
	
	while( hours != DUMMYVALUE )
	{
	    sum += hours;
	    cout << "Number of hours: ";
		cin >> hours;
	}
	return sum;
}

int main ()
{
    cout<< readhours();	
	return 0;
}

[48T7M4Gy]

Surgeon fixed up surgery error too - multiskilled.

I took the liberty of showing you how you could simplify a bit. But keep in mind yours is OK. :)

[48T7M4Gy]

PS I know you were calling the function three times and maybe you have special reason but remember that the dummy value allows any number of inputs, so a user would get sick of typing in -99. There are also problems if you wanted a grand total of the three.