nested class

[ebucna]

can anyone tell me whats wrong with my code, the compiler says:
line 25: expected identifier before numeric constant
line 25: expected "," or "..." before numeric constant
the same for line 26

  #include <iostream>
#include <iomanip>
using namespace std;

class Time{
private:
    unsigned short hours, minutes;
public:
    Time (unsigned short h, unsigned short m) {hours = h; minutes  = m;};
    void printTime () {
    cout << "\n\t" << setw(2) << setfill('0') << hours << ":" << setw(2) << minutes << ":" << endl;};
};
class Date{
private:
    unsigned short day, month, year;
public:
    Date (unsigned short d, unsigned short m, unsigned short y) {day = d; month = m; year = y;};
    void printDate () {
    cout << "\n\t" << setw(2) << setfill('0') << day << "/" << setw(2) << month << "/" << year << endl;};
};

class Flights{
private:
    string departureAirport, arrivalAirport;
    Time departureTime(1,1), arrivalTime(1,1), journeyLength(0,0);
    Date departureDate(1,1,1), arrivalDate(1,1,1);
    float cost;
public:
    Flights(string deptAir, string arrivAir, float costt){departureAirport = deptAir; arrivalAirport = arrivAir; cost = costt;};
    };

int main(){
    return 0;
}

[cire]

class Flights {
private:
    string departureAirport, arrivalAirport;
    Time departureTime = Time(1, 1), arrivalTime = Time(1, 1), journeyLength = Time(0, 0);
    Date departureDate = Date(1, 1, 1), arrivalDate= Date(1, 1, 1);
    float cost;
public:
    Flights(string deptAir, string arrivAir, float costt) { departureAirport = deptAir; arrivalAirport = arrivAir; cost = costt; };
};

Time departureTime(1,1) is interpreted as a function declaration.

[AbstractionAnon]

Are you using a C++14 compiler?

Older compilers don't allow initializing members as you are doing in lines 25-26.

[ebucna]

i am using codeblox

[ebucna]

i was told that because i have constructor for class Time that taking 2 values
i have to give it values when i am using it in Flights

[ebucna]

if i comment out the constructors for Time and Date and take out values in line 25 and 26 it compiles.

#include <iostream>
#include <iomanip>
using namespace std;

class Time{
private:
    unsigned short hours, minutes;
public:
   // Time (unsigned short h, unsigned short m) {hours = h; minutes  = m;};
    void printTime () {
    cout << "\n\t" << setw(2) << setfill('0') << hours << ":" << setw(2) << minutes << ":" << endl;};
};
class Date{
private:
    unsigned short day, month, year;
public:
    //Date (unsigned short d, unsigned short m, unsigned short y) {day = d; month = m; year = y;};
    void printDate () {
    cout << "\n\t" << setw(2) << setfill('0') << day << "/" << setw(2) << month << "/" << year << endl;};
};

class Flights{
private:
    string departureAirport, arrivalAirport;
    Time departureTime, arrivalTime, journeyLength;
    Date departureDate, arrivalDate;
    float cost;
public:
    Flights(string deptAir, string arrivAir, float costt){departureAirport = deptAir; arrivalAirport = arrivAir; cost = costt;};
    };

int main(){
    return 0;
}

but i need the constructors, so what do i do now?

[cire]

i am using codeblox

Code::Blocks is not a compiler. It's an IDE. You can find it packaged with g++, so perhaps that's the compiler you're using. If so, you should specify that you want the compiler to use C++11. If you do so, the code I posted above should compile.

Otherwise, you can just explicitly initialize them with the Flights constructor:

Flights (string deptAir, string arrivAir, float costt) : departureTime(1,1), arrivalTime(1,1), // etc
{
    // ...
}

[AbstractionAnon]

The problem was not your explicit constructors (line 9,17), but that you did not have a default constructor.

Since you appeared to be trying to instantiate those classes with default values, you have a couple of choices:
1) Provide a default constructor that initializes the object.

    //  Initialize members with default values
    Time ()  : hours(1), minutes(1)
    {}

2) Provide default values on your existing constructor.

    //  Constructor with default values
     Time (unsigned short h = 1, unsigned short m = 1)  : hours(h), minute (m)
    {}

Don't use both methods. You will get an error because the compiler will consider the constructors ambiguous.

[ebucna]

I see how I didn't think it through. unfortunately the time is not default, there will be 8 flight objects and they all will have different time and date

[AbstractionAnon]

Then pass the Date and Time through Flight's constructor.

[ebucna]

would you mind showing me an example please

[AbstractionAnon]

Flights (Date depdate, Time deptime, Date arrdate, Time arrtime, string deptAir, string arrivAir, float costt)
{ departureDate = depdate;
  departureTime = deptime;
  arrivalDate = arrdate;
  arrivalTime = arrtime;
  //  journeyLength should be calculated
  departureAirport = deptAir; 
  arrivalAirport = arrivAir; 
  cost = costt;
}

[ebucna]

it works if i take out the constructors from Time and Date. but i need to be able to input 2 values for time and 3 for date.

or if i leave it the way you did this this, how will i declare objects for class flight.
I need to input all the values in when declaring the objects (except journey length that has to be calculate as you stated)

this obviously doesn't work
flight1((1,1,1), (1,1), (1,1,1), (1,1), "ORK", "LTH", 480);

[AbstractionAnon]

Try this:

flight1(Date(1,1,1), Time(1,1), Date(1,1,1), Time(1,1), "ORK", "LTH", 480);

[ebucna]

I ended up doing this:

class Flights{
private:
    string departureAirport, arrivalAirport;
public:
    Time departureTime = Time(1,1), arrivalTime = Time (1,1), journeyLength = Time(0,0);
    Date departureDate = Date (1,1,1), arrivalDate = Date(1,1,1);
    float cost;
public:
    Flights(string deptAir, string arrivAir, float costt){departureAirport = deptAir; arrivalAirport = arrivAir; cost = costt;};
    };