what is problem? i don't know ...

[chachika]

Write your question here.

 #include <iostream>
#include <string>
#include <fstream>
#include <vector>
const int N = 4;
using namespace std;
class ocean{
	string saxeli;
	double partobi;
public:
	ocean(){}
	ocean(ifstream &ifs){
		ifs >> saxeli >> partobi;
	}
	string get_s(){ return saxeli; }
	double get_p(){ return partobi; }
};
void print(vector<ocean>& x){
	for (int i = 0; i < N;i++)
	if (x[i].get_p() < 150)
		cout << "misi saxelia" << x[i].get_s() << endl
		<< "xolo misi partobia " << x[i].get_p() << endl;
}
void printfile(vector<ocean>c){
	ofstream ofs("Pasuxi.txt");
	double sum = 0;
	for (int i = 0; i < N; i++)
		sum += c[i].get_p();
	double average = 0;
	average = sum / 4.;
	ofs << "SASHUALO PARTOBI GAMOVIDA " << average;
}
int main(){
	vector<ocean> x(N);
	ifstream ifs("Ocean.txt");
	for (int i = 0; i < N; i++)
		ocean FN(ifs);
	print(x);
	printfile(x);
}

[ne555]

¿why do you think there is a problem?

[tipaye]

main problem:

int main(){
	vector<ocean> x(N); // This actually creates N ocean objects
	ifstream ifs("Ocean.txt");
	// the next 2 lines repeatedly create (and destroy as they go out of scope), another N ocean objects and does nothing with them
	for (int i = 0; i < N; i++) 
		ocean FN(ifs); 
	// the next 2 lines work on the original, empty N objects!
	print(x); 
	printfile(x);
}

suggestion:

#include <iostream>
#include <string>
#include <fstream>
#include <vector>
const int N = 4;
using namespace std;
class ocean{
	string saxeli;
	double partobi;
public:
	ocean(){}
	ocean(ifstream &ifs){
		ifs >> saxeli >> partobi;
	}
	string get_s() const { return saxeli; }
	double get_p() const{ return partobi; }
};
void print(const vector<ocean>& x){
	for (int i = 0; i < N;i++)
	if (x[i].get_p() < 150)
		cout << "misi saxelia " << x[i].get_s() << endl
		<< "xolo misi partobia " << x[i].get_p() << endl;
}
void printfile(const vector<ocean>& c){ 
	ofstream ofs("Pasuxi.txt");
	double sum = 0.0;
	for (int i = 0; i < N; i++)
		sum += c[i].get_p();
	double average = sum / 4.0;
	ofs << "SASHUALO PARTOBI GAMOVIDA " << average;
}
int main(){
	vector<ocean> x(N); // this may not work in newer compilers?
	ifstream ifs("Ocean.txt");
	for (int i = 0; i < N; i++) 
		x[i] = ocean(ifs); // this is not bounds checked!
	print(x);
	printfile(x);
}