Odd error

[Gector]

... Any obvious reason I'm getting "First-chance exception at 0x003E5EBB in Clue.exe: 0xC0000005: Access violation reading location 0x003F4000."?

 #include <iostream>
#include <string.h>   // strlen()
#include <stdlib.h>  // system()


char words[50] = "Knife Wrench Candlestick Rope Pipe Revolver";
char word[50];
char compare = ' ';

int main()
{
	
	/*
	Buffer words table into word until it meets a space, then compare it with the user input
	*/
	int inc = 0;

	for (int i = 0; strlen(words); ++i){
		if (words[i] != compare){
			inc++;
			std::cout << words[i];
		}
		else if (words[i] == compare){
			std::cout << "\n";
		}
	}

	std::cout << "\n";
	system("Pause");
}

[Arslan7041]

line 18: What is your condition to end the for-loop?

[Gector]

The length of the character array, 'words'... Is that incorrect? It throws the same error with ++i and i++

[Arslan7041]

The loop should end once it gets to the end of the char array.

Therefore the ending condition should be: i < strlen(words)

[Gector]

Cool, thanks!

Here's the next question, why doesn't this print out the input back to the user if it matches the word in 'words'?

#include <iostream>
#include <string.h>  // strlen()
#include <stdlib.h>  // system()


char words[50] = "Knife Wrench Candlestick Rope Pipe Revolver";
char word[15];
char compare = ' ';
char input[15];

int main()
{
	
	/*
	Buffer words table into word until it meets a space, then compare it with the user input
	*/
	std::cin >> input;

	int inc = 0;
	for (int i = 0; i <= 43; i++){
		if (words[i] != compare){
			word[inc] = words[i];
			inc++;
		}
		else if (words[i] == compare){
			inc = 0;
			int len = strlen(word);
			for (int x = 0; x <= len; x++){
				word[x] = ' ';
			}
		}
	}

	std::cout << "\n";
	system("Pause");
}

[Moschops]

why doesn't this print out the input back to the user if it matches the word in 'words'?

Because you haven't written any code to compare the input with 'words'.