Problem with Tic Tac Toe Toggle

Hello everyone,

I am trying to construct a really basic Tic Tac Toe game. There is something wrong with the toggle. After player X moves, it toggles to O. But after this first toggle it doesn't go back to X. What's the problem here? Also, are there any suggestions for how to optimize this code? (Ignore the part where it says "computer wins." I am planning to make this a player vs. computer Tic Tac Toe game, but I want to fix the Toggle problem first before coding that in). Thanks in advance!

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
#include <iostream>
#include <limits>
#ifdef __cplusplus__
  #include <cstdlib>
#else
  #include <stdlib.h>
#endif


using namespace std;

char grid[3][3] = {'1', '2', '3', '4', '5', '6', '7', '8', '9'};
char player = 'X';

void Draw()
{
    if (system("CLS")) system("clear");                         // clears the screen

    for(int r = 0; r < 3 ; ++r)
    {
       cout << "-----------"<< endl;
       for(int c = 0; c < 3; ++c)
       {
           cout << grid[r][c] << " | ";
       }
       cout << endl;
    }
}

void input()
{

    cout << endl;
    cout << "Input the number of the field you would like to fill." << endl;

    int n;
    LOOP: cin >> n;

    while(!cin || n < 1 || n > 9)                                       // disallows inputs that are not integers between 1 and 9.
    {
        cout << "Please enter an integer value between 1 and 9." << endl;
        cin.clear();
        cin.ignore(numeric_limits <streamsize>::max(), '\n');
        goto LOOP;
    }

    if(n == 1)
    {
        if(grid[0][0] == '1')
        {
            grid[0][0] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
    else if(n == 2)
    {
        if(grid[0][1] == '2')
        {
            grid[0][1] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }

    else if(n == 3)
    {
        if(grid[0][2] == '3')
        {
            grid[0][2] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
    else if(n == 4)
    {
        if(grid[1][0] == '4')
        {
            grid[1][0] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
    else if(n == 5)
    {
        if(grid[1][1] == '5')
        {
            grid[1][1] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
    else if(n == 6)
    {
        if(grid[1][2] == '6')
        {
            grid[1][2] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
    else if(n == 7)
    {
        if(grid[2][0] == '7')
        {
           grid[2][0] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
    else if(n == 8)
    {
        if(grid[2][1] == '8')
        {
            grid[2][1] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
    else if(n == 9)
    {
        if(grid[2][2] == '9')
        {
            grid[2][2] = player;
        }
        else
        {
            cout << "This field has already been taken; please try again!" << endl;
            input();
        }
    }
}
void TogglePlayer()
{
    if(player = 'X')
    {
        player = 'O';
    }
    else if(player = 'O')
    {
        player = 'X';
    }
}
char Win()
{

/*

Grid Field:

00 | 01 | 02
------------
10 | 11 | 12
------------
20 | 21 | 22

*/
    // Checking to see if we have three 'X's in a row

    if(grid[0][0] == 'X' && grid[0][1] == 'X' && grid[0][2] == 'X')
    {
        return 'X';
    }
    if(grid[1][0] == 'X' && grid[1][1] == 'X' && grid[1][2] == 'X')
    {
        return 'X';
    }
    if(grid[2][0] == 'X' && grid[2][1] == 'X' && grid[2][2] == 'X')
    {
        return 'X';
    }

    //Checking to see if we have three 'X's in a column

    if(grid[0][0] == 'X' && grid[1][0] == 'X' && grid[2][0] == 'X')
    {
        return 'X';
    }
    if(grid[0][1] == 'X' && grid[1][1] == 'X' && grid[2][1] == 'X')
    {
        return 'X';
    }
    if(grid[0][2] == 'X' && grid[1][2] == 'X' && grid[2][2] == 'X')
    {
        return 'X';
    }

    //Checking to see if we have three 'X's in a diagonal

    if(grid[0][0] == 'X' && grid[1][1] == 'X' && grid[2][2] == 'X')
    {
        return 'X';
    }
    if(grid[2][0] == 'X' && grid[1][1] == 'X' && grid[0][2] == 'X')
    {
        return 'X';
    }

    //Checking to see if we have three 'O's in a row

    if(grid[0][0] == 'O' && grid[0][1] == 'O' && grid[0][2] == 'O')
    {
        return 'O';
    }
    if(grid[1][0] == 'O' && grid[1][1] == 'O' && grid[1][2] == 'O')
    {
        return 'O';
    }
    if(grid[2][0] == 'O' && grid[2][1] == 'O' && grid[2][2] == 'O')
    {
        return 'O';
    }

    //Checking to see if we have three 'O's in a column

    if(grid[0][0] == 'O' && grid[1][0] == 'O' && grid[2][0] == 'O')
    {
        return 'O';
    }
    if(grid[0][1] == 'O' && grid[1][1] == 'O' && grid[2][1] == 'O')
    {
        return 'O';
    }
    if(grid[0][2] == 'O' && grid[1][2] == 'O' && grid[2][2] == 'O')
    {
        return 'O';
    }

    //Checking to see if we have three 'O's in a diagonal

    if(grid[0][0] == 'O' && grid[1][1] == 'O' && grid[2][2] == 'O')
    {
        return 'O';
    }
    if(grid[2][0] == 'O' && grid[1][1] == 'O' && grid[0][2] == 'O')
    {
        return 'O';
    }
}
int main()
{
    int count = 0;
    cout << "Welcome to the Tic Tac Toe Game!" << endl; cout << endl;
    Draw();
    while (count < 9)
    {
        ++count;
        input();
        Draw();

        if (Win() == 'X')
        {
            cout << "You win!" << endl;
            break;
        }
        else if (Win() == '0')
        {
            cout << "The computer wins!" << endl;
            break;
        }
        else if (Win() != 'X' && Win() != 'X' && count == 8)
        {
            cout << "You drew with the computer!" << endl;
        }
        TogglePlayer();
    }
    if(count == 9)
    {
        cout << endl; cout << "Game over!" << endl;
    }
}

Last edited on
if(player = 'X') this is assignment not equality. It should look more like this
if(player == 'X')
Topic archived. No new replies allowed.