Why does my selectionSort() function not sort the list

Program compiles 100% correct but the list comes out NOT sorted?

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
  #include "arrayListType.h"
#ifndef H_OrderedListType
#define H_OrderedListType

#include <iostream>
//#include "listType.h"

using namespace std;

template<class elemType>

class orderedArrayListType : public arrayListType<elemType>
{
public:
	
	orderedArrayListType(int size = 100);
		//constructor
	int minLocation(int first, int last);
	void swap(int first, int second);
		void selectionSort();	
private:
	
	void insertOrd(const elemType&);
	
	int binarySearch(const elemType& item) const;

};
 #endif
template<class elemType>
int orderedArrayListType<elemType>::minLocation(int first, int last)
{
	int list[100];
	int loc, minIndex;
	minIndex = first;
	
	for(loc = first + 1; loc <= last; loc++)
		if(list[loc] < list[minIndex])
			minIndex = loc;
		
	return minIndex;
} //end minLocation
template<class elemType>
void orderedArrayListType<elemType>::swap(int first, int second)
{
	int list[100];
	elemType temp;
	temp = list[first];
     list[first] = list[second];
	list[second] = temp;
}   //end swap

template<class elemType>
void orderedArrayListType<elemType>::selectionSort()
{
	int length;
	int loc, minIndex;
	
	for(loc = 0; loc < length - 1; loc++)
	{
		minIndex = minLocation(loc, length - 1);
		swap(loc, minIndex);
	}
}
template<class elemType>
	orderedArrayListType<elemType>::orderedArrayListType(int size)
{
}

#include<iostream> 

using namespace std;

template<class elemType>
bool arrayListType<elemType>::isEmpty()
{
	return (length == 0);
}

template<class elemType>
bool arrayListType<elemType>::isFull()
{
	return (length == maxSize);
}

template<class elemType>
int arrayListType<elemType>::listSize()
{
	return length; 
}

template<class elemType>
int arrayListType<elemType>::maxListSize()
{
	return maxSize;
}

template<class elemType>
void arrayListType<elemType>::print() const
{
	for (int i = 0; i < length; i++)
	cout << list[i] <<" ";
	cout << endl;
}

template<class elemType>
bool arrayListType<elemType>::isItemAtEqual
							(int location, const elemType& item)
{
	return (list[location] == item);
}

template<class elemType>
void arrayListType<elemType>::insertAt
				(int location, const elemType& insertItem)
{
	if(location < 0 || location >= maxSize)
		cerr<<"The position of the item to be inserted "
		    <<"is out of range." << endl;
	else
		if(length >= maxSize)    //list is full
			cout<<"Cannot insert in a full list."<<endl;
	else
	{
		for(int i = length; i > location; i--)
		list[i] = list[i - 1];         //move the elements down
		
		list[location] = insertItem;       //insert the item at the specified location
		
		length++;
	}
}   //end insertAt
template<class elemType>
void arrayListType<elemType>::insertEnd(const elemType& insertItem)
{
	if(length >= maxSize)       //the list is full
		cerr<<"Cannot insert in a full list."<<endl;
	else
	{
		list[length] = insertItem;    // insert the item at the end
		
		length++;                    //increment the length
	}
}   //end insertEnd
template<class elemType>
void arrayListType<elemType>::removeAt(int location)
{
	if(location < 0 || location >= length)
		cerr<<"The location of the item to be removed "
		    <<"is out of range." <<endl;
	else
	{
		for(int i = location; i < length - 1; i++)
			list[i] = list[i + 1];
			
		length--;
	}
} // end removeAt
template<class elemType>
void arrayListType<elemType>::retrieveAt
						(int location, elemType& retItem)
{
	if(location < 0 || location >= length)
		cerr<<"The location of the item to be retrieved is "
		    <<"out of range."<<endl;
	else
		retItem = list[location];
}  // end retrieveAt
template<class elemType>
void arrayListType<elemType>::replaceAt
						(int location, const elemType& repItem)
{
	if(location < 0 || location >= length)
		cerr<<"The location of the item to be replaced is "
		    <<" out of range." <<endl;
	else
		list[location] = repItem;
}   // end replaceAT
template<class elemType>
void arrayListType<elemType>::clearList()
{
	length = 0;
}   //end clearList
template<class elemType>
arrayListType<elemType>::arrayListType(int size)
{
	if(size < 0)
	{
		cerr<<"The array size must be positive. Creating "
		    <<"an array of size 100." <<endl;
		maxSize = 100;
	}
	else
		maxSize = size;
		
	length = 0;
	
	list = new elemType[maxSize];
	assert(list != NULL);
}

//template<class elemType>
//arrayListType<elemType>::~arrayListType
//{
//	delete [] list;
//}
template<class elemType>
arrayListType<elemType>::arrayListType
				(const arrayListType<elemType>& otherList)
{
	maxSize = otherList.maxSize;
	length = otherList.length;
	list = new elemType[maxSize];      //create the array
	assert(list != NULL);              //terminate if unable to allocate memort space
	
	for(int j = 0; j < length; j++)       //copy otherList
		list [j] = otherList.list[j];
}   //end copy constructor
template<class elemType>
const arrayListType<elemType>&
					arrayListType<elemType>::operator=
					(const arrayListType<elemType>& otherList)
{
	if(this != &otherList)        //avoid self=assigment
	{
		delete [] list;
		maxSize = otherList.maxSize;
		length = otherList.length;
		
		list = new elemType[maxSize];        //create the array
		assert(list != NULL);                //if unable to allocate memory space,
											 //terminate the program
		for(int i = 0; i < length; i++)
			list[i] = otherList.list[i];
	}
	return *this;
}
template<class elemType>
void arrayListType<elemType>::insert(const elemType& insertItem)
{
	int loc;
	
	if(length == 0)                      //the list is empty
		list[length++] = insertItem;     //insert the item and increment the length
	else
		if(length == maxSize)
			cerr<<"Cannot insert in a full list." <<endl;
		else
		{
			loc = seqSearch(insertItem);
			
			if(loc == -1)               //the item to be inserted
			                            //does not exist in the list
				list[length++] = insertItem;
			else
				cerr<<"The item to be inserted is already in "
				    <<"the list. No duplicates are allowed."  <<endl;
	}
}   //end insert
template<class elemType>
void arrayListType<elemType>::remove(const elemType& removeItem)
{
	int loc;
	
	if(length == 0)
		cerr<<"Cannot delete from an empty list." <<endl;
	else
	{
		loc = seqSearch(removeItem);
		
		if(loc != -1)
			removeAt(loc);
		else
			cout<<"The item to be deleted is not in the list." <<endl;
	}
}   // end remove
template<class elemType>
int arrayListType<elemType>::seqSearch(const elemType& item)
{
	int loc;
	bool found = false;
	
	for(loc = 0; loc < length; loc++)
		if(list[loc] == item)
		{
			found = true;
			break;
		}
	if(found)
		return loc;
	else
		return -1;
}   //end seqSearch
int main() {
	
	orderedArrayListType<int> list;
	
	int num; 
	
	cout<<"\nEnter numbers ending with -999\n";
	
	cin >> num;
	while(num != -999)
	{
		list.insert(num);
		cin >> num;
   	}
	
	cout<<"The list before sorting:"<<endl;
	list.print();
	cout<<endl;
	
	list.selectionSort();
	
	cout<<"The list after sorting:"<<endl;
	list.print();
	cout<<endl;
	
	return 0;
}

I have had this problem for a month now and still cannot fine the problem.
Please help me
Line 32, 45 and 55 look suspicious. On these lines you create local variables that you later use without initializing.
I eventually found where my problem was.

Thank you Peter87
Registered users can post here. Sign in or register to post.