Passing in a vector that stops at a string.

[jollyholly11]

Write your question here.
I am trying to write a code that allows the user to type in a string. And then store that string into a vector, until the user types in "stop".
I call the vector in the first loop, but I am having trouble coding in the stop part.
I need to make two functions, one called GetWords to read in a sequence of words from cin and put them in a vector and the other, called PrintNewVector, to print them out.
I keep on getting a bunch of errors. Please I just need help coding into the right direction!

#include <iostream>
#include <string>
#include <vector>

using namespace std;


string GetWords() {
	string userInput;
	vector<string> newVector;
	const string STOP_LOOP = "stop";
	const int BLASTED_ONE_THOUSAND = 1000;
	string newVectorInput;
	newVectorInput == newVector;

	cout << "Please enter the words for the vector: " << endl;
	cin >> userInput;
		
        if (int i = 0; userInput< STOP_LOOP; i++){
                   

         }

	else if (userInput != STOP_LOOP||cin.fail()){
			cin.clear();
			cin.ignore(BLASTED_ONE_THOUSAND, '\n');
			cout << "Invalid selection " << endl;
		}
	}
	
	return newVector;
}


void PrintNewVector(vector<string>& words) {
	cout << words << endl;
	return;
};
          

int main () {
   vector<string> wonderful;
   
   wonderful = GetWords();
   cout << endl;
   PrintNewVector(words);
   cout << endl;
   
   return 0;
}

[Chervil]

I didn't follow what was the intention of the existing code. This is based on the written description.

vector<string> GetWords() {
    cout << "Please enter the words for the vector: " << endl;
    
    string userInput;
    vector<string>  newVector;
    
    while (cin >> userInput && userInput != "stop")
        newVector.push_back(userInput);
	
    return newVector;
}

http://www.cplusplus.com/reference/vector/vector/push_back/

[Thomas1965]

Shouldn't Getwords return a vector of strings ?

[Chervil]

Good point @Thomas1965

[longberns]

@jollyHolly11, part of the problems you get have been solved by @Chervil. Your PrintNewVector() is not correct

void PrintNewVector(vector<string>& words){
    // method 1: Iterating vector elements
    for(int i = 0; i < words.size(); i++){
        cout << words[i] << endl;
    }
    
    // method 2: Range-for 
    // see also http://en.cppreference.com/w/cpp/language/range-for
    for(auto word: words){
        cout << word << endl;
    }
}

You could also do some "nice" check.

if the vector is empty, 
   tell the user, 
else print vector content

And in your main()

int main() {
	vector<string> wonderful;

	wonderful = GetWords();
	cout << endl;
	PrintNewVector(wonderful);
	cout << endl;

	return 0;
}

Hope the bunch of errors will now be reduced

[jollyholly11]

Thank you! This has helped me go in the right direction!