Removing items from an array without loss of data

[loganc123]

Hello! I am having some trouble with a void function with the purpose of removing an entry in an array that is searched for, and pushing all of those beyond that value in the array down.

However what is happening is that if i delete the 4th element of the array, the 4th, 5th, 6th, 7th etc elements are all being deleted as well. Here is what I have for both the function and how I am calling it.

if (userChoice == 'R') {
			string toRemove;
			int spotInArray;
			cout << "Enter ID of product to remove: ";
			cin >> toRemove;

			spotInArray = search(inventory, toRemove, 100);
			if (spotInArray != -1) {
				remove(inventory, toRemove, 100);
				cout << "Item " << toRemove << " is removed." << endl << endl;
			}
			if (spotInArray == -1) {
				cout << "Item " << toRemove << " does not exist." << endl << endl;
			}

  void remove(Tools inventory[], string name, int length)
// PRE: 0 <= len <= array size
// POST: The first occurrence of the target is removed from the array
{
	int res = search(inventory, name, 100);; // call search function on target
	if (res != -1) // if target is found ...
	{
		length--; // decrement subarray length
		inventory[res] = inventory[length]; // overwrite item with last value of subarray
	}
}

[loganc123]

If it is helpful, the array, inventory, is made up of structs, so for example, inventory[0].price, etc.

[SECMoG1T]

what kind of arrays? dynamic,static.
i would suggest but not limit you to using an stl container, they are quite easy to use.
for example to remove an element just do this:

std::vector<objects> objvec{obj1,obj2,obj3,obj4};
auto iter = std::find(objvec.begin(),objvec.end(),obj2);///find

if(iter != objvec.end())
  objvec.erase(iter);///delete 

this code can remove an object from an array

#include <iostream>

void remov_item(int arr[],int item,std::size_t& used_len);
bool add_item(int arr[],int item,std::size_t& used_len,std::size_t real_len);
int search_item(int arr[],int item,int used_len);
void print_array(int arr[],std::size_t used_len);

int main()
{
  int arr[]{1,2,3,4,5,6,7,8,9,10,11,12,13,15,15,16,17,18,19,20,0,0,0,0,0};///think of 0 as blank

  std::size_t real_len = 24;///can't change
  std::size_t used_len = 20;///can change, denotes the # of items placed in arr

  int to_remov = 4;

  std::cout<<"used length: "<<used_len<<std::endl;
  print_array(arr,used_len);

  std::cout<<"removing "<<to_remov<<std::endl<<std::endl;
  remov_item(arr,to_remov,used_len);

  std::cout<<"used length: "<<used_len<<std::endl;
  print_array(arr,used_len);

  std::cout<<"adding: "<<30<<std::endl;
  if(add_item(arr,30,used_len,real_len))
    std::cout<<"element added successfully\n\n";
  else
    std::cout<<"can't add elements array full\n\n";


  std::cout<<"adding: "<<70<<std::endl;
  if(add_item(arr,70,used_len,real_len))
    std::cout<<"element added successfully\n\n";
  else
    std::cout<<"can't add elements array full\n\n";


  std::cout<<"used length: "<<used_len<<std::endl;
  print_array(arr,used_len);

}

int search_item(int arr[],int item,int used_len)
{
  for(int i=0; i<used_len; i++)
  {
      if(arr[i] == item)
        return i;
  }
  return -1;///not found
}

void remov_item(int arr[],int item,std::size_t& used_len)
{
  auto index = search_item(arr,item,used_len);

  for(std::size_t j = index; j < used_len-1; j++)
  {
     arr[j] = arr[j+1];
  }

  arr[used_len] = 0;///blank now

  if(index!= -1)
    --used_len;
}

void print_array(int arr[],std::size_t used_len)
{
    for(std::size_t i = 0; i<used_len; i++)
    {
        std::cout<<arr[i]<<" ";
    }
    std::cout<<"\n\n";
}

bool add_item(int arr[],int item,std::size_t& used_len,std::size_t real_len)
{
    if(used_len == real_len)///array full
        return false;

    arr[used_len] = item; ///add item
    ++used_len;

    return true;
}

used length: 20
1 2 3 4 5 6 7 8 9 10 11 12 13 15 15 16 17 18 19 20

removing 4

used length: 19
1 2 3 5 6 7 8 9 10 11 12 13 15 15 16 17 18 19 20

adding: 30
element added successfully

adding: 70
element added successfully

used length: 21
1 2 3 5 6 7 8 9 10 11 12 13 15 15 16 17 18 19 20 30 70