hello

[shirshir950]

hello
im trying to run this program .
menu which include functions
the cases worked perfectly alone (in a separatr projects)
but when i added it to the menu it wont work !
hope you can help me
im hopless.

 #include <iostream>
using namespace std;


const int SIZE = 5;
const int COLS = 3;
const int COLS = 4;


int creatingNewNumber(int num);

void  printArray(int arr[], int size);
int SumOfTheDigitsNumber(int number);
int SumOfTheArrayNumbers(int arr[SIZE]);

void setMatrix(int mat[][COLS], int rows);
void printMatrix(int mat[][COLS], int rows);
bool sumOfRowsAndCols(int mat[][COLS], int rows);

void setMatrix(int mat[][COLS], int rows);
void printMatrix(int mat[][COLS], int rows);
bool isMatrixColsAMirror(int mat[][COLS], int rows);

bool isKarperkar(int parts[], int num);






void main()
{

	int choise;
	bool fContinue = true;

	do
	{
		cout << "choose 1 for question 1" << endl;
		cout << "choose 2 for question 3" << endl;
		cout << "choose 3 for question 6" << endl;
		cout << "choose 4 for question 7" << endl;
		cout << "choose 5 for question 9" << endl;
		cout << "choose 0 to Exit" << endl;

		cout << "Plese enter your choise" << endl;
		cin >> choise;

		switch (choise)
		{
			case 1:
			{

				
				int num;
				int temp;
				

				cout << "please enter a number" << endl;
				cin >> num;

				temp = creatingNewNumber(num);
				cout << temp << endl;

			
				break;
			}
			case 2:
			{
			
				const int SIZE = 5;
				
				int number;
				int arr[SIZE] = { 19,35,42,55,97 };
				int size;
				int sumOfDigits;
				int sumOfArrayNum;

				cout << "please enter a number" << endl;
				cin >> number;

				cout << "the sum of the number's digits is" << endl;
				sumOfDigits = SumOfTheDigitsNumber(number);
				cout << sumOfDigits << endl;

				cout << "the array numbers are: " << endl;
				printArray(arr, SIZE);

				cout << "the number of numbers which their sum is 10 are :" << endl;
				sumOfArrayNum = SumOfTheArrayNumbers(arr);
				cout << sumOfArrayNum << endl;

				break;
			}
			case 3:
			{
			
				const int COLS = 3;
				

				int mat1[3][COLS] = { { 2,1,5 } ,{ 6,7,3 },{ 0,8,0 } };
				int trueOrFalse;

				setMatrix(mat1, 3);

				cout << "the matrix is" << endl;
				printMatrix(mat1, 3);

				trueOrFalse = sumOfRowsAndCols(mat1, 3);
				cout << trueOrFalse << endl;


				break;
			}
			case 4:
			{
				
				const int COLS = 4;
				int mat[4][COLS] = { { 1,4,4,1 } ,{ 2,2,2,2 },{ 3,0,0,3 } ,{ 5,6,6,5 } };
				int isMirror;

				setMatrix(mat, 4);

				cout << "the matrix is" << endl;
				printMatrix(mat, 4);

				isMirror = isMatrixColsAMirror(mat, 4);
				cout << isMirror << endl;


				break;
			}
			case 5:
			{

				int parts[2];

				bool isKarperkar(int parts[], int num);

				for (int i = 1; i <= 111111; i++)
				{
					if (isKarperkar(parts, i))
					{
						cout << i << " " << parts[0] << "---" << parts[1] << " " << " is karperkar" << endl;
					}
				}
				break;
			}
			
			case 0:
			{
				fContinue = false;
				break;
			}
			default:
			{
				cout << "invailed option" << endl;
				break;
			}

			cout << endl;
		}

	} while (fContinue);
	cout << "Goodbye" << endl;




		system("pause");
}

int creatingNewNumber(int num)
{
	int newNum = 0;
	int temp = 0;
	int newNum1;

	while (num > 0)
	{
		newNum = newNum * 10;
		if (num % 10 == 9)
		{
			newNum += 0;
		}
		else
		{
			newNum += (num % 10) + 1;
		}
		num = num / 10;

		newNum1 = newNum;
	}

	while (newNum1 > 0)
	{
		temp = temp * 10;
		temp = temp + newNum1 % 10;
		newNum1 = newNum1 / 10;
	}

	return temp;
}



int SumOfTheDigitsNumber(int number)
{
	int sum = 0;
	int temp;
	int newNum1;

	temp = number;
	while (number > 0)
	{
		temp = number % 10;
		sum = sum + temp;
		number = number / 10;
	}

	return sum;
}

void printArray(int arr[], int size)
{
	for (int i = 0; i < size; i++)
	{
		cout << arr[i] << " ";

	}
	cout << endl;
}

int SumOfTheArrayNumbers(int arr[SIZE])
{

	int temp;
	int counter = 0;

	for (int i = 0; i < SIZE; i++)
	{
		int sum = SumOfTheDigitsNumber(arr[i]);
		if (sum == 10)
		{
			counter++;
		}
	}



	return counter;
}



void setMatrix(int mat[][COLS], int rows)
{
	for (int i = 0; i < rows; i++)
	{
		for (int j = 0; j < COLS; j++)
			mat[i][j];
	}
}
void printMatrix(int mat[][COLS], int rows)
{
	for (int i = 0; i < rows; i++)
	{
		for (int j = 0; j < COLS; j++)
			cout << mat[i][j] << " ";
		cout << endl;
	}
	cout << endl;
}

bool sumOfRowsAndCols(int mat[][COLS], int rows)
{
	bool fContinue = true;
	int counter = 0;

	for (int i = 0; i < rows && fContinue; i++)
	{
		int sumRows = 0;
		int sumCols = 0;

		for (int j = 0; j < COLS; j++)
		{
			sumRows += mat[i][j];
			sumCols += mat[j][i];
		}
		if (sumRows == sumCols)
		{
			fContinue = true;
			counter++;
		}
		else
		{
			fContinue = false;
		}

	}
	if (counter == rows)
	{
		return true;
	}
	else
	{
		return false;
	}

}

void setMatrix(int mat[][COLS], int rows)
{
	for (int i = 0; i < rows; i++)
	{
		for (int j = 0; j < COLS; j++)
			mat[i][j];
	}
}
void printMatrix(int mat[][COLS], int rows)
{
	for (int i = 0; i < rows; i++)
	{
		for (int j = 0; j < COLS; j++)
			cout << mat[i][j] << " ";
		cout << endl;
	}
	cout << endl;
}

bool isMatrixColsAMirror(int mat[][COLS], int rows)
{
	bool fContinue = true;


	for (int s = 0; s < rows; s++)
	{
		for (int i = 0, j = COLS - 1; i < rows, j>0 && fContinue; i++, j--)
		{
			if (mat[i][i + 1 - 1] != mat[i][j])
			{
				fContinue = false;
			}
		}
		if (fContinue)
		{
			return true;
		}
		else
		{
			return false;
		}

	}
}

bool isKarperkar(int parts[], int num)
{
	int pow2 = num * num;
	int temp = pow2;
	int right = 0;
	int left = temp;
	int m = 1;
	while (temp > 0) {
		right += (temp % 10) * m;
		left = temp / 10;
		temp = temp / 10;
		m *= 10;
		if (right != 0 && left + right == num)
		{
			parts[0] = left;
			parts[1] = right;
			return true;
		}
	}

	return false;
}

[Handy Andy]

Hello shirshir950,

You should make sure that the program compiles before you post, so someone like me does not have to waste time fixing the errors before figuring out what is wrong.

One thing that did come out in the errors is on line 119 you defined a 2D array as being 4 x 4, but on line 256 "COLS" has a value of 3 not the 4 that it needs.

Something that could be happening here is that a function that worked in another program worked because the variables in the function definition are defined for the other program. Using the function in this new program may not be set up correctly.

Hope that helps some,

Andy

[Handy Andy]

Hello shirshir950,

Once I got it to work this is what I found.

const int SIZE = 5;  // <--- OK.
const int COL = 3;  // <--- Changed this to work with 3 x 3 array. Otherwise it was a redefinition error.
const int COLS = 4;  // <--- OK. 

These proto types and functions OK.

int creatingNewNumber(int num);

void  printArray(int arr[], int size);
int SumOfTheDigitsNumber(int number);
int SumOfTheArrayNumbers(int arr[SIZE]);

These proto types and functions changed.

void setMatrix(int mat[][COLS], int rows);  // <--- To use a 4 x 4 2D array. OK.
void printMatrix(int mat[][COLS], int rows);  // <--- To use a 4 x 4 2D array. OK.
bool sumOfRowsAndCols(int mat[][COLS], int rows);  // <--- OK.
bool sumOfRowsAndCols3(int mat[][COL], int rows);  // <--- Changed.
bool isMatrixColsAMirror(int mat[][COLS], int rows);  // <--- OK. 

void setMatrix3(int mat[][COL], int rows);  // <--- To use a 3 x 3 2D array.
void printMatrix3(int mat[][COL], int rows);  // <--- To use a 3 x 3 2D array.

bool isKarperkar(int parts[], int num);  // <--- OK. 

In main in the switch case 3 is the only case I had to make any changes to.

After main the functions "setMatrix" and "printMatrix" were defined twice. I changed the name of the second definition, as you can see from the proto types, to use the 3 x 3 array.

The function "sumOfRowsAndCols" I had to create a second function like "set/printMatrix to work with the 3 x 3 array.

The difference between "COL" and "COLS" may not be seen right off, but there is a big difference.

Hope that helps,

Andy

[shirshir950]

thank you so much Andy !!

all work !! :)

#include <iostream>
using namespace std;


const int SIZE = 5;
const int COL = 3;
const int COLS = 4;

int creatingNewNumber(int num);
void printArray(int arr[], int size);
int SumOfTheDigitsNumber(int number);
int SumOfTheArrayNumbers(int arr[SIZE]);

void setMatrix(int mat[][COL], int rows);
void printMatrix(int mat[][COL], int rows);
bool sumOfRowsAndCols(int mat[][COL], int rows);


void setMatrix3(int mat[][COLS], int rows);
void printMatrix3(int mat[][COLS], int rows);
bool isMatrixColsAMirror(int mat[][COLS], int rows);

bool isKarperkar(int parts[], int num);


void main()
{

int choise;
bool fContinue = true;

do
{
cout << "choose 1 for question 1" << endl;
cout << "choose 2 for question 3" << endl;
cout << "choose 3 for question 6" << endl;
cout << "choose 4 for question 7" << endl;
cout << "choose 5 for question 9" << endl;
cout << "choose 0 to Exit" << endl;

cout << "Plese enter your choise" << endl;
cin >> choise;

switch (choise)
{
case 1:
{


int num;
int temp;


cout << "please enter a number" << endl;
cin >> num;

temp = creatingNewNumber(num);
cout << temp << endl;


break;
/*
choose 1 for question 1
choose 2 for question 3
choose 3 for question 6
choose 4 for question 7
choose 5 for question 9
choose 0 to Exit
Plese enter your choise
1
please enter a number
123
234
choose 1 for question 1
choose 2 for question 3
choose 3 for question 6
choose 4 for question 7
choose 5 for question 9
choose 0 to Exit
Plese enter your choise

*/
}
case 2:
{

const int SIZE = 5;

int number;
int arr[SIZE] = { 19,35,42,55,97 };
int size;
int sumOfDigits;
int sumOfArrayNum;

cout << "please enter a number" << endl;
cin >> number;

cout << "the sum of the number's digits is" << endl;
sumOfDigits = SumOfTheDigitsNumber(number);
cout << sumOfDigits << endl;

cout << "the array numbers are: " << endl;
printArray(arr, SIZE);

cout << "the number of numbers which their sum is 10 are :" << endl;
sumOfArrayNum = SumOfTheArrayNumbers(arr);
cout << sumOfArrayNum << endl;

break;
}
case 3:
{

const int COL = 3;


int mat1[3][COL] = { { 2,1,5 } ,{ 6,7,3 },{ 0,8,0 } };
int trueOrFalse;

setMatrix(mat1, 3);

cout << "the matrix is" << endl;
printMatrix(mat1, 3);

trueOrFalse = sumOfRowsAndCols(mat1, 3);
cout << trueOrFalse << endl;


break;
}
case 4:
{

const int COLS = 4;
int mat[4][COLS] = { { 1,4,4,1 } ,{ 2,2,2,2 },{ 3,0,0,3 } ,{ 5,6,6,5 } };
int isMirror;

setMatrix3(mat, 4);

cout << "the matrix is" << endl;
printMatrix3(mat, 4);

isMirror = isMatrixColsAMirror(mat, 4);
cout << isMirror << endl;


break;
}
case 5:
{

int parts[2];

bool isKarperkar(int parts[], int num);

for (int i = 1; i <= 111111; i++)
{
if (isKarperkar(parts, i))
{
cout << i << " " << parts[0] << "---" << parts[1] << " " << " is karperkar" << endl;
}
}
break;
}

case 0:
{
fContinue = false;
break;
}
default:
{
cout << "invailed option" << endl;
break;
}

cout << endl;
}

} while (fContinue);
cout << "Goodbye" << endl;




system("pause");
}

int creatingNewNumber(int num)
{
int newNum = 0;
int temp = 0;
int newNum1;

while (num > 0)
{
newNum = newNum * 10;
if (num % 10 == 9)
{
newNum += 0;
}
else
{
newNum += (num % 10) + 1;
}
num = num / 10;

newNum1 = newNum;
}

while (newNum1 > 0)
{
temp = temp * 10;
temp = temp + newNum1 % 10;
newNum1 = newNum1 / 10;
}

return temp;
}



int SumOfTheDigitsNumber(int number)
{
int sum = 0;
int temp;
int newNum1;

temp = number;
while (number > 0)
{
temp = number % 10;
sum = sum + temp;
number = number / 10;
}

return sum;
}

void printArray(int arr[], int size)
{
for (int i = 0; i < size; i++)
{
cout << arr[i] << " ";

}
cout << endl;
}


int SumOfTheArrayNumbers(int arr[SIZE])
{

int temp;
int counter = 0;

for (int i = 0; i < SIZE; i++)
{
int sum = SumOfTheDigitsNumber(arr[i]);
if (sum == 10)
{
counter++;
}
}



return counter;
}

void setMatrix(int mat[][COL], int rows)
{
for (int i = 0; i < rows; i++)
{
for (int j = 0; j < COL; j++)
mat[i][j];
}
}
void printMatrix(int mat[][COL], int rows)
{
for (int i = 0; i < rows; i++)
{
for (int j = 0; j < COLS; j++)
cout << mat[i][j] << " ";
cout << endl;
}
cout << endl;
}

bool sumOfRowsAndCols(int mat[][COL], int rows)
{
bool fContinue = true;
int counter = 0;

for (int i = 0; i < rows && fContinue; i++)
{
int sumRows = 0;
int sumCols = 0;

for (int j = 0; j < COL; j++)
{
sumRows += mat[i][j];
sumCols += mat[j][i];
}
if (sumRows == sumCols)
{
fContinue = true;
counter++;
}
else
{
fContinue = false;
}

}
if (counter == rows)
{
return true;
}
else
{
return false;
}

}

void setMatrix3(int mat[][COLS], int rows)
{
for (int i = 0; i < rows; i++)
{
for (int j = 0; j < COLS; j++)
mat[i][j];
}
}
void printMatrix3(int mat[][COLS], int rows)
{
for (int i = 0; i < rows; i++)
{
for (int j = 0; j < COLS; j++)
cout << mat[i][j] << " ";
cout << endl;
}
cout << endl;
}

bool isMatrixColsAMirror(int mat[][COLS], int rows)
{
bool fContinue = true;


for (int s = 0; s < rows; s++)
{
for (int i = 0, j = COLS - 1; i < rows, j>0 && fContinue; i++, j--)
{
if (mat[i][i + 1 - 1] != mat[i][j])
{
fContinue = false;
}
}
if (fContinue)
{
return true;
}
else
{
return false;
}

}
}

bool isKarperkar(int parts[], int num)
{
int pow2 = num * num;
int temp = pow2;
int right = 0;
int left = temp;
int m = 1;
while (temp > 0) {
right += (temp % 10) * m;
left = temp / 10;
temp = temp / 10;
m *= 10;
if (right != 0 && left + right == num)
{
parts[0] = left;
parts[1] = right;
return true;
}
}

return false;
}

[Handy Andy]

Hello shirshir950,

You are Welcome.

In the future PLEASE remember to use code tags. It makes it much easier to read your code.

If you are finished with this please put a green check on the subject so everyone will know you have your answer.

Andy