if-else error

[salmanilyas]

I am having problem with this statement please help.thanks for your time





#include <iostream>

using namespace std;

int main()
{
int a=10,b;
cout << "Please enter any value (1 or 2) : ";
cin>>a;
if (a==1) {cout << "\nOrange";
cout << "\nOranges are orange";}
if (a==2) { cout << "\nApple";
cout << "\nApples are red";}
else {cout << "\nWrong selection";}
cout << endl;

return 0;
}






Expected answer if pressed 1

Orange
Oranges are orange


but i get

Orange
Oranges are orange
Wrong selection

[Repeater]

#include <iostream>

using namespace std;

int main()
{
  int a=10,b;
  cout << "Please enter any value (1 or 2) : ";
  cin>>a;

  if (a==1) 
  {
    cout << "\nOrange";
    cout << "\nOranges are orange";
  }


  if (a==2) 
 { 
    cout << "\nApple";
    cout << "\nApples are red";
  }
  else 
  {
     cout << "\nWrong selection";
  }


cout << endl;

return 0;
}

Read the code again. If a is 1, what happens when you reach this part:

  if (a==2) 
 { 
    cout << "\nApple";
    cout << "\nApples are red";
  }
  else 
  {
     cout << "\nWrong selection";
  }

[salmanilyas]

it gives the answer

orange
oranges are orange
wrong selection


it should not give wrong selection because i have put it in else statement if i am not wrong

[salmanilyas]

this what i get when pressed 1


Please enter any value (1 or 2) : 1

Orange
Oranges are orange
Wrong selection

Process returned 0 (0x0) execution time : 2.096 s
Press any key to continue.

[Repeater]

it should not give wrong selection because i have put it in else statement if i am not wrong

You are wrong.

The else is associated only with the SECOND if statement. Your program has this logic:

if a is one, output Orange.


Now, if a is 2 output Apple, otherwise output Wrong.

[salmanilyas]

can you specify the code please because its getting over me.

[jonnin]

one way to fix it is to add an else to the first if:

if (a==1)
{
cout << "\nOrange";
cout << "\nOranges are orange";
}

else
if (a==2)
{
cout << "\nApple";
cout << "\nApples are red";
}
else
{
cout << "\nWrong selection";
}

-----------------
the program that you posted does this:
is a 1? yes, print orange stuff.
stop. reset. moving to a new code block that is unrelated in every way to the above block.
begin new block.
is a 2? if yes, print apple stuff.
if not (include, a may be 1 here)
print wrong stuff.

therefore if a is 1,
it prints orange stuff, correctly.
then it checks if 1 is 2, it isnt, so WRONG is printed.

the else I offered ties the 2 if statements together:
is a 1? no.
ok, is it 2? no.
ok its wrong.

or
is a 1? Yes
else//skipped
if//part of skipped else
//else part of skipped if that is part of skipped else above..
the end.

Which is what he said ^^^ But much more explicitly.

You have to be careful with this stuff ... the computer needs everything explicitly stated, whereas a human reading your code understands what you meant, the compiler just does what you said literally.

[salmanilyas]

thanks alot jonnin it was very helpful.