Compare elements of the string.

[Innoox]

Good day,

I need to get several numbers from the user and compare it. If they are growth - print it to the screen. If decreasing - another output. In my code, I always get the same result "Decreasing!". I'm not sure is it valid to use such comparison in this situation var1[i] < var1[i + 1]

#include <iostream>
#include <string>
using namespace std;

void compare(bool x)
{
	if (x == true)
	{
		cout << "Increasing!" << endl;
	}
	else if (x == false)
	{
		cout << "Decreasing!" << endl;
	}
}

int main()
{
	string var1;
	bool res1;
	cout << "Please input numbers here:\t";
	cin >> var1;
	for (int i = 0; i != var1.length(); i++)
	{
		if (var1[i] < var1[i + 1])
		{
			res1 = true;
		}
		else if (var1[i] > var1[i + 1])
		{
			res1 = false;
		}
	}
	compare(res1);
	return 0;
}

[jlb]

I need to get several numbers from the user and compare it.

If you're trying to input numbers why are you using a string for your user input? Wouldn't using a numeric type make more sense?

By the way what should happen if the two numbers are equal?


Also your function can be simplified:

void compare(bool x)
{
	if (x)
	{
		cout << "Increasing!" << endl;
	}
	else
	{
		cout << "Decreasing!" << endl;
	}
}