Program using Bubble and Selection sort

[likeohmygodisthatstnick]

Hey guys. I am working on writing code that will swap using both bubbleSort and selectionSort. However, for the two functions, I have to use two other functions (lessThan or greaterThan and swapItems). The teacher wrote the whole code other than bubbleSort and selectionSort, where he just filled the function with a comment on what needs to go there.

The assignment reads:

Implement bubble sort and selection sort as they are implemented in the book, but instead of swapping items directly, use the swapItems function implemented below and instead of comparing values directly, use the lessThan and greaterThan functions below.

- For example, if you want to swap the items in array arr at indexes i and j, you would write the statement swapItems(arr, i, j)

- If you want to compare two values val1 and val2 you would use the expression lessThan(val1, val2) or greaterThan(val1, val2) to replace the expressions val1< val2 or val1> val2

- You do not have to replace comparisons of indexes like i < size, just comparisons of values in the array like arr[i]<arr[j]

------------

I've made the functions for bubbleSort and selectionSort, but they aren't actually doing anything. There's no change in the output of the program compared to what I had before I made the functions. I'm not sure if I'm missing something totally obvious or if I'm actually not doing any of it correctly. Any help is greatly appreciated.

  #include <iostream>
#include <cstdlib>
#include <ctime>
#include <iomanip>
using namespace std;

void fillArray(int[], int);
void displayArray(int[], int);
void copyArray(int[], int[], int);
void bubbleSort(int[], int);
void selectionSort(int[], int);
void swapItems(int[], int, int);
bool lessThan(int, int);
bool greaterThan(int, int);
void resetStats();
void displayStats();

int numSwaps = 0;
int numComparisons = 0;

int main()
{
	const int SIZE = 100;
	int bubbleArray[SIZE];
	int selectionArray[SIZE];

	// Fill the arrays with identical sets of random numbers
	fillArray(bubbleArray, SIZE);
	copyArray(bubbleArray, selectionArray, SIZE);

	// Display the original contents of the array
	cout << "Unsorted Array" << endl;
	cout << "--------------" << endl;
	displayArray(bubbleArray, SIZE);
	cout << endl;

	// Perform Bubble Sort and display results
	resetStats();
	bubbleSort(bubbleArray, SIZE);
	cout << "BubbleSort" << endl;
	cout << "----------" << endl;
	displayArray(bubbleArray, SIZE);
	cout << endl;
	displayStats();
	cout << endl;

	// Perform Selection Sort and display results
	resetStats();
	selectionSort(selectionArray, SIZE);
	cout << "SelectionSort" << endl;
	cout << "-------------" << endl;
	displayArray(selectionArray, SIZE);
	cout << endl;
	displayStats();
	cout << endl;

	system("pause");
	return 0;
}

// Array management functions
void fillArray(int arr[], int size)
{
	unsigned int seed = static_cast<int>(time(0));
	srand(seed);
	for (int index = 0; index < size; index++)
	{
		arr[index] = rand() % 1000;
	}
}

void copyArray(int source[], int destination[], int size)
{
	for (int index = 0; index < size; index++)
	{
		destination[index] = source[index];
	}
}

void displayArray(int arr[], int size)
{
	for (int index = 0; index < size; index++)
	{
		cout << setw(4) << arr[index];
		if (index % 10 == 9)
			cout << endl;
	}
}

// Bubble Sort algorithm
void bubbleSort(int arr[], int size)
{
int maxElement = 0;
	for (int index = 0; index < maxElement; maxElement--)
	{
		if (greaterThan(index, index + 1))
		{
			swapItems(arr, index, index + 1);
		}
	}

        // implement bubbleSort using the greaterThan
	// and swapItems functions



// Selection Sort algorithm
void selectionSort(int arr[], int size)
{
int maxElement = 0;
	for (int index = 0; index < maxElement; maxElement--)
	{
		if (lessThan(index, index + 1))
		{
			swapItems(arr, index, index + 1);
		}
	}
}
	// implement selectionSort using the lessThan
	// and swapItems functions
}

// Basic operations with counters
void swapItems(int arr[], int index1, int index2)
{
	numSwaps++;
	int temp = arr[index1];
	arr[index1] = arr[index2];
	arr[index2] = temp;
}

bool lessThan(int num1, int num2)
{
	numComparisons++;
	return num1 < num2;
}

bool greaterThan(int num1, int num2)
{
	numComparisons++;
	return num1 > num2;
}

// Functions for managing statistics
void resetStats()
{
	numSwaps = 0;
	numComparisons = 0;
}

void displayStats()
{
	cout << "Swaps: " << numSwaps << " Comparisons: " << numComparisons << endl;
}

[likeohmygodisthatstnick]

Alright, so I found where the issue is, but I am not sure how to fix it.

My teacher wants us to use a function for the if loop in both the parameters and the statement within. I changed the parameters to the actual greaterThan statement and left the swapItems function in the statement. It works now.

This is the changed function:

int maxElement;
	int index;

	for (maxElement = size - 1; maxElement > 0; maxElement--)
	{
		for (index = 0; index < maxElement; index++)
		{
			if (arr[index] > arr[index +1])
			{
				swapItems(arr, index, index + 1);
			}
		}
	}

What I need help with is how to put a function in place of the if parameters... where I have arr[index] > arr[index + 1]

The function that I have for that right now is:

bool greaterThan(int num1, int num2)
{
	numComparisons++;
	return num1 > num2;
}

This function was given to me by the teacher, so I think the issue is with how I am placing it/ what I'm putting in for num1 and num2.

Thank you in advance for any advice you have to offer!

[likeohmygodisthatstnick]

AAAAAAAND I did it!

Sorry for posting when I was able to figure it out. But it was helpful to write everything down and see what I was doing. Maybe this can help someone else in the future.

I'm not really sure what I was thinking, but I just put arr[index] in place of num1 and arr[index + 1] in place of num2 when calling the function. Here's the complete program!

// Allison Johnson
// Program to compare Selection Sort and Bubble Sort
// CSCI 1010
// Practice Problems 12

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <iomanip>
using namespace std;

void fillArray(int[], int);
void displayArray(int[], int);
void copyArray(int[], int[], int);
void bubbleSort(int[], int);
void selectionSort(int[], int);
void swapItems(int[], int, int);
bool lessThan(int, int);
bool greaterThan(int, int);
void resetStats();
void displayStats();

int numSwaps = 0;
int numComparisons = 0;

int main()
{
	const int SIZE = 100;
	int bubbleArray[SIZE];
	int selectionArray[SIZE];

	// Fill the arrays with identical sets of random numbers
	fillArray(bubbleArray, SIZE);
	copyArray(bubbleArray, selectionArray, SIZE);

	// Display the original contents of the array
	cout << "Unsorted Array" << endl;
	cout << "--------------" << endl;
	displayArray(bubbleArray, SIZE);
	cout << endl;

	// Perform Bubble Sort and display results
	resetStats();
	bubbleSort(bubbleArray, SIZE);
	cout << "BubbleSort" << endl;
	cout << "----------" << endl;
	displayArray(bubbleArray, SIZE);
	cout << endl;
	displayStats();
	cout << endl;

	// Perform Selection Sort and display results
	resetStats();
	selectionSort(selectionArray, SIZE);
	cout << "SelectionSort" << endl;
	cout << "-------------" << endl;
	displayArray(selectionArray, SIZE);
	cout << endl;
	displayStats();
	cout << endl;

	system("pause");
	return 0;
}

// Array management functions
void fillArray(int arr[], int size)
{
	unsigned int seed = static_cast<int>(time(0));
	srand(seed);
	for (int index = 0; index < size; index++)
	{
		arr[index] = rand() % 1000;
	}
}

void copyArray(int source[], int destination[], int size)
{
	for (int index = 0; index < size; index++)
	{
		destination[index] = source[index];
	}
}

void displayArray(int arr[], int size)
{
	for (int index = 0; index < size; index++)
	{
		cout << setw(4) << arr[index];
		if (index % 10 == 9)
			cout << endl;
	}
}

// Bubble Sort algorithm
void bubbleSort(int arr[], int size)
{
	int maxElement;
	int index;

	for (maxElement = size - 1; maxElement > 0; maxElement--)
	{
		for (index = 0; index < maxElement; index++)
		{
			if (greaterThan(arr[index], arr[index +1]))
			{
				swapItems(arr, index, index + 1);
			}
		}
	}
	// implement bubbleSort using the greaterThan
	// and swapItems functions
}

// Selection Sort algorithm
void selectionSort(int arr[], int size)
{
	
	int maxElement;
	int index;

	for (maxElement = size - 1; maxElement > 0; maxElement--)
	{
		for (index = 0; index < maxElement; index++)
		{
			if (lessThan(arr[index], arr[index + 1]))
			{
				swapItems(arr, index, index + 1);
			}
		}
	}

	// implement selectionSort using the lessThan
	// and swapItems functions
}

// Basic operations with counters
void swapItems(int arr[], int index1, int index2)
{
	numSwaps++;
	int temp = arr[index1];
	arr[index1] = arr[index2];
	arr[index2] = temp;
}

bool lessThan(int num1, int num2)
{
	numComparisons++;
	return num1 < num2;
}

bool greaterThan(int num1, int num2)
{
	numComparisons++;
	return num1 > num2;
}

// Functions for managing statistics
void resetStats()
{
	numSwaps = 0;
	numComparisons = 0;
}

void displayStats()
{
	cout << "Swaps: " << numSwaps << " Comparisons: " << numComparisons << endl;
}