Random Guesser

[Kejone]

I'm doing that guessing program where you need to guess a number between 1-100, but it seems I can't get it to compare the inputted guess against the random number. If anyone could help it would be greatly appreciated.

Line 15 and 17 give me a warning of "right operand of comma operator has no effect" and they also both give an error of "expected primary expression before '<<' token"

  #include <iostream>
#include <cstdlib>
#include <stdlib.h>
#include <stdio.h>
#include <time.h>

using namespace std;

int main()
{
    int xg;
    int x = rand() % 100+1;
    cout << "Let's play a game. Guess a whole number between 1 and 100."; << endl;
    cin >> xg;
    if (xg < x){cout << "Try guessing higher." or "Higher please."; << endl;}
    else {
            if (xg>x){cout << "Try a smaller number." or "Too low."; << endl;}
            else { if (xg==x){ cout << "You got it! Good job!";}}}
    return 0;
}

[Jaybob66]

line 13,15,17 have embedded semicolons, so remove them.
there should be no semicolons in the middle of your statement.

eg; cout << item << item << item;

where you have cout << item << item; << item;

[Kejone]

@Jaybob66 It really didn't affect the issue but thanks for the suggestion.

[H00G0]

Here is what it should look like:

#include <iostream>
#include <cstdlib>
#include <stdlib.h>
#include <stdio.h>
#include <time.h>

using namespace std;

int main()
{
    int xg;
    int x = rand() % 100+1;
    
    cout << "Let's play a game. Guess a whole number between 1 and 100." << endl;
    cin >> xg;
    
    if (xg < x)
    {
           cout << "Try guessing higher." << endl;
    }
    else
    {
            if (xg>x)
            {
                cout << "Try a smaller number." << endl;
            }
            else 
            { 
                if (xg==x)
                { 
                    cout << "You got it! Good job!";
                }
            }
    }
    
    return 0;
}

Your problem was first of all what Jaybob66 mentioned, you can have a semicolon before << without reusing cout.

Second of all you did this:
cout << "Try guessing higher." or "Higher please."; << endl
the next step to correct this would be removing the semicolon:
cout << "Try guessing higher." or "Higher please." << endl
Finally, you did this
cout << "some string" or "some other string"; "or" isn't recognised by the operator << since it's undefined, it's up to you to chose which string you want to cout, not to the program.
So here is the final and working version of that line:
cout << "Try guessing higher." << endl;

Also, your code was hard to read because of your editing. I know people argue about this, but try to space your code out and not have it like this:

void function(){
    for (/*[...]*/){
        if(/*[...]*/){
            //do something;
}}}    //<- this is confusing 

try this instead:

void function()
{
    for (/*[...]*/)
    {
        if(/*[...]*/)
        {
            //do something;
        }
    }
}

Hope this helps,

Regards,

Hugo


EDIT: Also if you want to keep playing the game until you find the right number, and not have the program terminate after each guess, you should probably use a while loop