constructors

[poohbear]

how to do constructors with this . please help

  #include <iostream>

#include <iomanip>

#include <string>

using namespace std;

class Employee

{

public:

Employee()//constructor with default setting
{
	name=name;
	rate=rate;
	hours= hours;
}

Employee(string name, double rate,double hours)
{ 
	name=name;
	rate=rate;
	hours= hours;
}
//parameterized constructor
bool setName(string name)
{

    if(name=="")

    return false;

    this->name = name;

return true;

}

bool setRate(double rate)
{

    if(rate<0)

    return false;

    this->rate = rate;

    return true;

}

bool setHours(double hours){

    if(hours<0)

return false;

    this->hours = hours;

return true;

}

double getPay(){

double pay = hours*rate;

    if(hours>40)

pay += (hours-40)*rate*0.5;

return pay;

}

double getHours(){

return hours;

}

double getRate(){

return rate;

}

string getName(){

return name;

}

private:

string name;

double hours;

double rate;

};

int main()

{

string name;

double hours, rate;

Employee *emp = new Employee;

char another;

do{

cout<<"Enter employee's name: ";

while(1){

getline(cin, name);

if(emp->setName(name))

break;

cout<<"Name cannot be blank, re-enter: ";

}

cout<<"Enter hours worked: ";

while(1)
{

    cin>>hours;

    if(emp->setHours(hours))

break;

cout<<"Hours must be positive. re-enter: ";

}

cout<<"Enter hourly rate: ";

while(1)
{

    cin>>rate;

    if(emp->setRate(rate))

break;

cout<<"Hourly rate must be positive, re-enter: ";

}

cout<<setprecision(2)<<fixed;

cout<<"\n\nGross pay for "<<emp->getName()<<": $"<<emp->getPay()<<endl<<endl;

cout<<"Another employee? (Y/N): ";

cin>>another;

//for buffering

getline(cin, name);

}
while(another!='Y' || another!='y');

cout<<"Press any key to continue";

cin>>another;

return 0;

}

[Ganado]

Employee()//constructor with default setting
{
	name=name;
	rate=rate;
	hours= hours;
}

"Constructor with default setting" You need to put default values in for name, rate, and hours.
Perhaps:

name = "N/A";
rate = 0.0;
hours = 0.0;

Employee(string name, double rate,double hours)
{ 
	name=name;
	rate=rate;
	hours= hours;
}

name = name; is trying to assign your local variable to itself.
To prevent this, either do
this->name = name;

Or do an initializer list (preferred!)
https://en.cppreference.com/w/cpp/language/initializer_list

Employee()//constructor with default setting
: name("N/A"),
  rate(0.0),
  hours(0.0)
{ }

Employee(string name, double rate,double hours)
: name(name),
  rate(rate),
  hours(hours)
{ }

[Handy Andy]

Hello poonamp6792,

Watch your indenting. The code is hard to read.

Nothing wrong with it, but you have extra blank lines thet you do not need.

What you are calling the default ctor is a good idea, but wrong. You have:

Employee()//constructor with default setting
{
	name=name;
	rate=rate;
	hours= hours;
}

Line 3 will not hurt anything you are setting an empty string equal to its self. But rate and hours have no value to begin with, so you are actually garbage equal to garbage since the variables have not value to start with.

What you want is this:

Employee()//constructor with default setting
{
	rate = 0.0; 
	hours = 0.0;
}

The string is empty to start with and does not need to be given an value unless you want to. "rate" and "hours" being "double"s do need to be given a value.

The overloaded ctor is half right it should be more like:

Employee(string name, double rate,double hours)
{ 
	m_name = name;
	m_rate = rate;
	m_hours = hours;
}

And the private variables of the class would start with "m_", which is what I see quite often, or you could change or do something different with the function parameters so that they are different from your private variable names. Sorry I had a brain freeze with what to do with the function parameters for the variables.

Hope that helps,

Andy

[poohbear]

hi guys , i finished it.

does this look good? i still need to work with indenting

******** Poonam Patel *******/
/* This program calculate the employee's gross pay with overtime hours worked as well */
#include <iostream>

#include <iomanip>

#include <string>

using namespace std;

class Employee

{

public:

Employee()//constructor with default setting
{

m_rate=0.0;
m_hours= 0.0;
}

Employee(string name, double rate,double hours)
{
m_name = name;
m_rate = rate;
m_hours = hours;
}

public://parameterized constructor
bool setName(string name)
{

if(name=="")

return false;

this->m_name = name;

return true;

}

bool setRate(double rate)
{

if(rate<0)

return false;

this->m_rate = rate;

return true;

}

bool setHours(double hours){

if(hours<0)

return false;

this->m_hours =hours;

return true;

}

double getPay(){

double pay = m_hours*m_rate;

if(m_hours>40)

pay += (m_hours-40)*m_rate*0.5;

return pay;

}

double getHours(){

return m_hours;

}

double getRate(){

return m_rate;

}

string getName(){

return m_name;

}

private:

string m_name;

double m_hours;

double m_rate;

};

int main()

{

string name;

double hours, rate;

Employee *emp = new Employee;

char another;

do{

cout<<"Enter employee's name: ";

while(1){

getline(cin, name);

if(emp->setName(name))

break;

cout<<"Name cannot be blank, re-enter: ";

}

cout<<"Enter hours worked: ";

while(1)
{

cin>>hours;

if(emp->setHours(hours))

break;

cout<<"Hours must be positive. re-enter: ";

}

cout<<"Enter hourly rate: ";

while(1)
{

cin>>rate;

if(emp->setRate(rate))

break;

cout<<"Hourly rate must be positive, re-enter: ";

}

cout<<setprecision(2)<<fixed;

cout<<"\n\nGross pay for "<<emp->getName()<<": $"<<emp->getPay()<<endl<<endl;

cout<<"Another employee? (Y/N): ";

cin>>another;

//for buffering

getline(cin, name);

}
while(another!='Y' || another!='y');

cout<<"Press any key to continue";

cin>>another;

return 0;

}