Access Violation

[stoneJax]

I just completed a project and I thought that I was done and now I am getting an exception thrown that says:

Exception thrown at 0x7793D9CB (ucrtbased.dll) in Project18.exe: 0xC0000005: Access violation reading location 0xCCCCCCBC.

This gets thrown in my destructor and now I have a green squiggly line from visual studio and when I put the cursor over it, it says that ptr (pointer used as a c-string) is uninitialized. I set up my pointer exactly how my instructor did in his example so I cannot make sense of what this all means and how to fix it.

namespace cs_mystring
{
	class MyString
	{
	public:
		MyString();
		MyString(const char* inString);
		MyString(const MyString& right);
		~MyString();
		friend std::ostream& operator << (std::ostream& out, const MyString& right);
		char& operator [] (int index);
		char operator [] (int index) const;
		friend bool operator < (const MyString& left, const MyString& right);
		friend bool operator <= (const MyString& left, const MyString& right);
		friend bool operator > (const MyString& left, const MyString& right);
		friend bool operator >= (const MyString& left, const MyString& right);
		friend bool operator == (const MyString& left, const MyString& right);
		friend bool operator != (const MyString& left, const MyString& right);
		MyString operator = (const MyString& right);
		size_t length()const;
		
	private:
		char *ptr;
	};
}





  MyString::MyString(const MyString& right) // Green squiggly line here
	{
		if (this != &right) {
			ptr = new char[strlen(right.ptr) + 1];
			strcpy(ptr, right.ptr);
		}
	}




MyString::~MyString()
	{
		delete[] ptr; // exception thrown here
	}

[stoneJax]

I figured it out. Got rid of the if statement above and noticed that my return statement in my = function was in the wrong place. Seems to be working good now.

[TheIdeasMan]

But did you allow for self assignment? An else statement associated with that if would do that.

[stoneJax]

The copy constructor is how my instructor set his up in his example. I accidentally put that if statement.