Template List not deleting items

I have a simple template list (only using it for ints so far), and all appears to work except deleting items always fails and i'm not sure why. Below is the full code and main function

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
#include <iostream>

template<typename T>
class node
{
public:
	T* data;
	node<T>* next = nullptr;
	node<T>* prev = nullptr;
};

template<typename T>
class list
{
public:
	node<T>* head;
	int length;

	list<T>()
	{
		head = nullptr;
		length = 0;
	}
	list<T>(T item);
	~list<T>() {};
	void addItem(T item);
	bool deleteItem(T item);
	void print();
};

template<typename T>
list<T>::list(T item)
{
	head = nullptr;
	length = 0;
	addItem(item);
}

template<typename T>
void list<T>::addItem(T item)
{
	node<T>* newItem = new node<T>;
	newItem->data = new T;
	newItem->next = nullptr;
	newItem->prev = nullptr;

	*newItem->data = item;

	if (head == nullptr)
	{
		head = newItem;
		length++;
		return;
	}

	node<T>* iterator = head;
	while (iterator->next != nullptr)
	{
		iterator = iterator->next;
	}
	iterator->next = newItem;
	newItem->prev = iterator;
	length++;
}

template<typename T>
bool list<T>::deleteItem(T item)
{
	node<T>* iterator = head;
	if (*iterator->data == item)
	{
		if (length > 1)
		{
			head = iterator->next;
			delete iterator->data;
			delete iterator;
			length--;
			return true;
		}
		else
		{
			head = nullptr;
			delete iterator->data;
			delete iterator;
			length--;
			return true;
		}
	}
	while (iterator->next != nullptr)
	{
		if (*iterator->data == item)
		{
			iterator->prev->next = iterator->next;
			delete iterator->data;
			delete iterator;
			length--;
			return true;
		}
		iterator = iterator->next;
	}
	return false;
}

template<typename T>
void list<T>::print()
{
	if (head == nullptr)
	{
		std::cout << "\nList is empty.";
		return;
	}
	node<T>* iterator = head;
	std::cout << std::endl << *iterator->data << std::endl;
	while (iterator->next != nullptr)
	{
		iterator = iterator->next;
		std::cout << *iterator->data << std::endl;
	}
}


//main.cpp

#include "generic-list.hpp"


int main(void)
{
	list<int> l;
	int x = 5;
	int y = 16;
	int c = 44;
	l.addItem(x);
	l.addItem(y);
	l.addItem(c);

	l.print();
	std::cout << l.length;

	bool success = l.deleteItem(c); //this always fails
	l.print();
	std::cout << l.length << success;


	
	getchar();
	return 0;
}
Line 89 should be just
while (iterator != nullptr)

However, your code may well fail later, because you haven't set a prev pointer on deletion in the same way that you set a next pointer.
Topic archived. No new replies allowed.