randomizing error. help please

[biplav17]

void randomize_deck()
{
      int rand1, rand2;
      card holder;
      card holder2;
      srand ( time(NULL) );              /* initialize random seed: */
  
      for (int j=1; j <1000;j++)         // Swaps a random pair of cards 1000 times
      {   rand1 = rand() % 52;
          rand2 = rand() % 52;
          holder.str_rank = deck[rand1].str_rank;      
          deck[rand1].str_rank = deck[rand2].str_rank;
          deck[rand2].str_rank = holder.str_rank;
      }
} 

whats wrong? it is not randomizig properly?

[Peter87]

Only call srand once at the beginning of your program.

[Disch]

Also you're only swapping str_rank. Why not just swap the entire card?

          holder = deck[rand1];      
          deck[rand1] = deck[rand2];
          deck[rand2] = holder;