What am i doing wrong?

[Ch1156]

Ok im making a program that allows you to open a text file in the cmd window, then it should allow you to find a word from what was inputted and change it to something different, but when i try it, it says something alongs the lines that the proigram was asked to execute in an unusual way and has crashed or something. What am i doing wrong?

#include <iostream>
#include <string>
#include <fstream>

using namespace std;

void find(string& storeText, ifstream& fileIn);
int updateHistory(int& r);

int main()
{
    string fileName;
    string storeText;
    int r = 0;

    cout << "What file do you want to open?" << endl;
    cout << "The file you want to open must be typed in EXACTLY as it" << endl;
    cout << "appears on your computer; for example: document.txt\n" << endl;
    getline(cin, fileName);

    if(fileName == "updatehistory")
    {
        updateHistory(r);
    }
    if(r == 10)
    {
        cout << "File Name" << endl;
        getline(cin, fileName);
    }

    ifstream fileIn;
    fileIn.open(fileName.c_str());

    cout << "\n";

    if(fileIn.fail())
    {
        cout << "Failed to open" << endl;
        fileIn.close();
    }

    while(getline(fileIn, storeText))
    {
        cout << storeText << endl;
    }
    cin.get();

    find(storeText, fileIn);

    fileIn.close();
}

void find(string& storeText, ifstream& fileIn)
{
	string str2;
	cout << "Which word you want to find from the document?: ";
	cin >> str2;
	cin.get();
	size_t found;

	found = storeText.find(str2);
	cout << "Enter a word: ";
	string str3;
	cin.ignore();
	getline(cin,str3);

	cout << "After replacing with the given word: \n" << endl;
	storeText.replace(storeText.find(str2), str2.length(), str3);

    while(!fileIn.eof())
    {
        cout << storeText << endl;
    }

	cin.get();
}

int updateHistory(int& r)
{
    cout << "VERSION INFORMATION\n" << endl;

    cout << "Version: 1.0.0 Alpha" << endl;
    cout << "Recently added features" << endl;
    cout << "1. Added replace function\n" << endl;

    cin.get();

    return r = 10;
}

[Peter87]

The crash is on line 68. storeText.find(str2) returns std::string::npos which means that the sting was not found. Passing std::string::npos to replace will throw an exception because it's not a valid position. You need to check the return value of find before passing it to replace.

When you call getline(fileIn, storeText) storeText will get a new value. If the call to getline fails it will leave storeText empty. That means you have not acutally stored the file content anywhere. After the loop on line 42-44 storeText will always be empty so you are always passing an empty string to ::find.

[Ch1156]

oh ok i'll work on trying to fix that but how can i make an error check for that problem? like i did here:

  if(fileIn.fail())
    {
        cout << "Failed to open" << endl;
        fileIn.close();
    }

[Ch1156]

Ok i tried some things and im totally confused.

[Peter87]

found = storeText.find(str2);
if (found == std::string::npos)
{
	// Do whatever you want to do in case str2 was not found in storeText.
}

[Ch1156]

Ok cool, now about the other problem, im still confused.

[Peter87]

If you want storeText to contain all lines in the file you can use another string to read each line with getline and append it to the end of storeText.

std::string line;
while(getline(fileIn, line))
{
	storeText += line + '\n';
}

[Ch1156]

and i put this in my find() function? replacing:

 while(!fileIn.eof())
    {
        cout << storeText << endl;
    }

[Peter87]

No was thinking about the loop main.

I don't know what you want to do with fileIn inside find. If you want to write to file you need an ofstream, instead of an ifstream.

[Ch1156]

What i want my program to do is open the file in main, then the function find, will find and replace a word in the loaded document. Or do i need to load the document again in the find function?

[Peter87]

You need to open the file again but as an ofstream. Make sure to close fileIn before doing that. fileIn.close();

[Ch1156]

Ok i have been trying this for a while now iand i cant get it working, can you show me what the final code looks like?

[Ch1156]

bump