Seg Fault on Copy Constructor of Binary Tree

[crashAndBurn]

So as the title states I'm getting a segmentation fault when calling the copy constructor for my binTree class. I'm not sure why here is the partial code:

template<class T>
binTree<T>::binTree(const binTree<T>& bt) {
        copy(bt.root);
}


template<class T>
binTreeNode<T>* binTree<T>::copy(const binTreeNode<T>* nodePtr) {
        if(nodePtr) {
                binTreeNode<T>* newRoot = new binTreeNode<T>;
                newRoot->data = nodePtr->data;
                newRoot->left = copy(nodePtr->left);
                newRoot->right = copy(nodePtr->right);

                return newRoot;
        } else
                return NULL;
}

Any help would be appreciated

[cire]

Can you show us in copy (or in the constructor) where you actually modify a data member of the class?

[crashAndBurn]

I was thinking this would modify it because it calls this.copy(bt.root);

template<class T>
binTree<T>::binTree(const binTree<T>& bt) {
        copy(bt.root);
} 

[cire]

From the name, you would think so, but as I asked before.. where in copy is a data member of the class actually modified?

[crashAndBurn]

I'm probably wrong and that's the problem but I was thinking since copy returns a pointer to a new root that in turn points to the rest of the tree and this is being returned to the this pointer which is then an exact copy of the passed in binary tree. Is this wrong?

[crashAndBurn]

I see what your saying. copy doesn't change the root data member but I'm having trouble fixing that I tried this as well:

template<class T>
binTreeNode<T>* binTree<T>::copy(const binTreeNode<T>* nodePtr) {
        if(nodePtr) {
                binTreeNode<T>* newRoot = new binTreeNode<T>;
                newRoot->data = nodePtr->data;
                newRoot->left = copy(nodePtr->left);
                newRoot->right = copy(nodePtr->right);
                root = newRoot;
                delete newRoot
                return root;
        } else
                return NULL;
}

[crashAndBurn]

got it working, all good now...

[cire]

My suggestion would be to keep the previous version of copy and add another overloaded version.

template <class T>
void binTree<T>::copy( const binTree<T>& tree )
{
    if ( tree.root )
        root = copy(tree.root) ;
    else
        root = nullptr ;
}

Then the constructor becomes:

template<class T>
binTree<T>::binTree(const binTree<T>& bt)  {
        copy(bt);
}