Reading a file and storing into its respective variables

[vichu8888]

Hi all,
I have input file which contains a transaction details. Each line have 5 data, date,code,activity,shares,price
for example:

24/12/2010,ABC,BUY,40,15

how do i read it and store it in respective variables say

day=24
month=12
year=2010
code=ABC
activity=BUY
shares=40
price=15

What I have done so far is

ex E;
getline(input,E.line,'/');
stringstream(E.line)>>date1.dday;		
getline(input,E.line,'/');
stringstream(E.line)>>date1.dmonth;
getline(input,E.line,',');
stringstream(E.line)>>date1.dyear;
getline(input,E.line,',');
stringstream(E.line)>>E.Ccode;	
getline(input,E.line,',');
stringstream(E.line)>>E.Cactivity;
getline(input,E.line,',');
stringstream(E.line)>>E.Cshares;
getline(input,E.line);
stringstream(E.line)>>E.Cprice;

This code works fine. But is there any simpler way to read and store the variables. Because im storing the values into variables directly declared in the class ex and Date date1. Im not at all using set methods used. for example I have a set method
for shares

void ex::set_code(int shares)
{
	Cshares=shares;//Cshares is member variable of class ex;
}

How do i use this set method during the reading function

getline(input,E.line,',');
stringstream(E.line)>>E.Cshares;

[strongdrink]

Pass a pointer of your input stream to the set_code method.

EDIT:
I recommend not actually using the input stream in the setters, instead, have a 'load' method, which you pass an input stream to, which will parse the data and stick in the corresponding variables.

[vichu8888]

Thanks for the advice strongdrink.
What I did now is I declared variables

int day,month,year,shares;
	double price;
	string code,activity,line;

in the main itself and using sstream i stored each values into its variables.
Then I call the set methods of the classes and set it.

while(!in.eof())
	{	
		getline(in,line,'/');
		stringstream(line)>>day;
		getline(in,line,'/');
		stringstream(line)>>month;
		getline(in,line,',');
		stringstream(line)>>year;
		getline(in,line,',');
		stringstream(line)>>code;
		getline(in,line,',');
		stringstream(line)>>activity;
		getline(in,line,',');
		stringstream(line)>>shares;
		getline(in,line);
		stringstream(line)>>price;
		E.set_share(shares);
		size++;
	
	}	

Will that be efficient?

[jlb]

I myself would read an entire line from the file into a std::string. Then have a "setter" function that takes this string and fills in the data members, from the string using string streams. For example:

#include <iostream>
#include <sstream>

using namespace std;

struct Test
{
   int day;
   int month;
   int year;
   string code;
   string activity;
   int shares;
   double price;
   void set_all(const std::string& line);
};



int main()
{
   std::string line = "24/12/2010,ABC,BUY,40,15";

   Test test;

   test.set_all(line);

   cout << test.day << endl;
   cout << test.month << endl;
   cout << test.year << endl;
   cout << test.code << endl;
   cout << test.activity << endl;
   cout << test.shares << endl;
   cout << test.price << endl;

   return(0);
}


void Test::set_all(const std::string& line)
{
   // A character for extracting the delimter.
   char delim;
   istringstream ins(line);
   ins >> day >> delim >> month >> delim >> year >> delim;
   getline(ins, code, ',');
   getline(ins, activity,',');
   ins >> shares >> delim >> price;
}

[vichu8888]

thanks jlb. thats look better choice