Please use [co
de] tags for code. Makes it so much easier to read. I'm also going to assume those underscores are supposed to be spaces (to output fixed-width font with spaces you can use the [tt[i][/i]][/tt
Anyway your biggest problem seems to be that you're using 'n' and 'm' for loop counters when they're really supposed to be the size of the box you're drawing. Your first loop:
This throws away whatever the user input as 'n' and replaces it with n=1 (which it then counts up, and by the time that loop is finished... n=m+1). You then throw away the value of 'm' in the next loop. Use another variable for a loop counter.
You also have logic errors:
This will output only one
asterisk before going to a new line, which is not a desired result unless n=1.
It looks like you're trying to draw lines around the box. Like you're trying to draw the top, left, right, then bottom lines of the box. You can't really do this -- what you need to do is output full rows at one time. So if you need to output [tt]* *[/tt] (with 3 spaces... n=5) on one of the rows, then you'll need to output this row in full
before outputting another row. And you'll need to include
those spaces in your output).
Try approaching this one row at a time. It might help to output a solid box first:
Then move on to making the desired hollow box once you get a firmer understanding of the idea.