Converting lower to upper

[cheshirecat]

Hello, I'm trying to have a function outside of main check to see if a number is lowercase, and then to make it uppercase if it is. So far I have this but I'm showing errors.

bool Upper(char x)
{
	if (islower(x))
		putchar (toupper(x));
	return x;
}

int _tmain(int argc, _TCHAR* argv[])
{
	char x;
	int y;
	cout << "Please press a key" << endl;
	cin >> x;
	Upper(x);
	cout << Upper(x);

errors are

1>(34): error C2084: function 'bool Upper(char)' already has a body
1>(17) : see previous definition of 'Upper'
1>(46): error C3861: 'Upper': identifier not found
1>(47): error C2568: '<<' : unable to resolve function overload
1>(17): could be 'bool Upper(char)'
1>(47): error C3861: 'Upper': identifier not found

[KyleMiles]

I would suggest using ASCII values... If it's between certain values it would be either uppercase or lowercase.

- Kyle

[toum]

It says you've defined your Upper function at more than 1 location.
Can you post what's at line 17 of your cpp file ?

[cheshirecat]

Ok I made changes on lines 30-35. I had two instances of Upper. I also was putchar instead of return.

#include "stdafx.h"
#include "iostream"
#include "ctype.h"
using namespace std;

bool Digit(char x)
{	
	if (isdigit(x))
		return 1;
	else 
		return 0;
}

bool Upper(char x)
{
	if (isupper(x))
		return 1;
	else 
		return 0;
}

bool Lower(char x)
{
	if (islower(x))
		return 1;
	else 
		return 0;
}

char Change(char x)
{
	if (islower(x))
	return (toupper(x));
	else 
	return x;
}

int _tmain(int argc, _TCHAR* argv[])
{
	char x;
	int y;
	cout << "Please press a key" << endl;
	cin >> x;
	Change(x);
	cout << Change(x);
}