Convert string to uppercase?

[napharian]

So I'm making a really simple rock paper scissors game in c++. I used to be able to convert my char variable to uppercase, but it did not allow me to add spaces to my username. I converted it to string and I have been searching back and forth how to change the string to uppercase as my one does not work :S - hopefully some of you can help...thanks!

code:

#include <iostream>
#include <cstring>
#include <ctime>
#include <cmath>
#include <cstdlib>
#include <fstream>

using namespace std;
int rand_0toN1(int n);
void upcase(string name); //calling upcase function
int main()
{
    int x;
    int n;
    int i;
    int r;
    int pc_score = 0;
    int user_score = 0;
    string name; //convert to uppercase
    int text = 0;
    int text2 = 0;

cout << "Enter your name:" << endl;
getline(cin, name);
upcase(name); //using the upcase function


while (1) {
    while(1) {
    while (1) {
    cout << endl;
    cout << "Please choose your class:" << endl;
    cout << "(1) Rock" << endl;
    cout << "(2) paper" << endl;
    cout << "(3) Scissor" << endl;
    cout << "(4) Save Scores" << endl;
    cout << "(5) Load Scores" << endl;
    cout << "(0) to exit" << endl;
    cout << endl;
    cin >> x;

    if (x == 0) {
    exit(EXIT_SUCCESS);
    }
        if (x > 5) {
        cout << endl;
        cout << "Please pick a number from one to three" << endl;
        cout << endl;
        } else {
        break;
        }
    }
    if (x == 4) { //just loading scores
    ofstream file;
    ofstream load1;
    ofstream load2;
    file.open("d:\\scores.txt");
    file << name << ": " << user_score << endl;
    file << "COMPUTER: " << pc_score << endl;
    file.close();
    cout << endl;
    cout << "File was successfully saved - if saved again, file will be overwritten" << endl;
    cout << endl;
    load1.open("c:\\scoresuser.txt");
    load1 << user_score;
    load2.open("c:\\scorespc.txt");
    load2 << pc_score;
    } else if (x == 5) {
    ifstream getscorepc ("c:\\scorespc.txt");
    if (getscorepc.is_open()) {
        while (!getscorepc.eof()) {
        int tempString;
        getscorepc >> tempString;
        text += tempString;
        }
        pc_score = text;
    }
    ifstream getscoreuser ("c:\\scoresuser.txt");
if (getscoreuser.is_open()) {
while (!getscoreuser.eof()) {
    int tempString2;
    getscoreuser >> tempString2;
    text2 += tempString2;
}
user_score = text2;
cout << endl;
cout << "Load successful." << endl;
cout << endl;
}
    }
     else {
    break;
    }
    }

n = 1;
for (i=1; i <=n; i++) {
r = rand_0toN1(3) + 1;
}
if (r == 1){
    cout << endl;
    cout << "The computer chooses rock" << endl;
    cout << endl;
} else if (r == 2) {
cout << endl;
cout << "The computer chooses paper" << endl;
cout << endl;
} else if (r == 3) {
cout << endl;
cout << "The computer chooses scissors" << endl;
cout << endl;
}

//here, the scores do not seem to show up as uppercase (the var is name)
if (r == x) {
    cout << "__________________________________________" << endl;
    cout << endl;
    cout << "It is a draw!" << endl;
    cout << endl;
    cout << "__________________________________________" << endl;
    cout << name << ": " << user_score << "            Computer: " << pc_score << endl;
cout << endl;
}
else if (r == 1 && x == 2 || r == 2 && x == 3 || r == 3 && x == 1){
    cout << "__________________________________________" << endl;
    cout << endl;
    cout << "You win!" << endl;
    cout << endl;
    cout << "__________________________________________" << endl;
    user_score++;
    cout << name << ": " << user_score << "            Computer: " << pc_score << endl;
    cout << endl;
}
else {
    cout << "__________________________________________" << endl;
    cout << endl;
    cout << "You loose!" << endl;
    cout << endl;
    cout << "__________________________________________" << endl;
    pc_score++;
    cout << name << ": " << user_score << "            Computer: " << pc_score << endl;
    cout << endl;
}
}
cout << endl;
return 0;
}

int rand_0toN1(int n) {
return rand() % n;
}
void upcase(string name){ //defining the function
int length;
length = name.size(); //making length = to the length of the string (works fine)
int p;
for(p = 0; p < length; p++) {
    name[p] = toupper(name[p]); //this SHOULD convert string name; to uppercase but it doesnt
}
}

Just as a reminder, I still am a semi-beginner so I imagine a lot of the code could be optimised

[Script Coder]

This works:

void upcase(string *name) {
	for(int i=0; i<name->size(); ++i)
		if((*name)[i]>96 && (*name)[i]<123) (*name)[i]-=32;
}

[khal]

You want the user name to be uppercase?
If so you have to pass the string name by reference.

void upcase(string & name); //calling upcase function 

void upcase(string & name){ //defining the function
int length;
length = name.size(); //making length = to the length of the string (works fine)
int p;
for(p = 0; p < length; p++) {
    name[p] = toupper(name[p]); //this SHOULD convert string name; to uppercase but it doesnt
}

[napharian]

Script Coder:
For me it says (I'm using codeblocks if that helps in any way)
undefined reference to std::string name
this is with the upcase(name); line with your code :S
and if I put upcase(string name) it says expected primary-expression before name

[ne555]

@Script Coder: ¿why the obfuscation?

@khal: void upcase(string & name); that is not the `calling', just the prototype.

@OP: the prototype and definition must match.
If you are planning to use Script Coder's version, then the calling should be upcase( &name ); as the function ask for a pointer

[Script Coder]

@ne555 I did not mean to obfuscate my code, that is how I would have done it. how should I have done it?

@OP try including the string header

[napharian]

Thank you so much for your replies :), it worked @Script Coder and @ne555

[ne555]

@Script Coder:
You should simply do (*name)[K] = toupper( (*name)[K] ); (as in the original post)

If for some reason you did not want to use that function, then more clearly

if( (*name)[K]>='a' and (*name)[K]<='z' )
   (*name)[K] = (*name)[K]-'a'+'A';