Code Dump

[whitesaya]

#include "palindrome.h"

void CPali::input()
{
	cout << "Word: ";
	cin >> word;
}

void CPali::check()
{	
	length = word.size()-1;

	for (int i = 0; i < length; i++)
	{
		if(word[i] == ' ')
		{
			word.erase(word[i],1);
			length = word.size()-1;
		}
	}

	for (int i = 0, p = length; p > i; i++, p--)
	{
		if (toupper(word[i]) == toupper(word[p]))
		{
			
			valid = true;
			
		}
		else if (toupper(word[i]) != toupper(word[p]))
		{
			valid = false;
		}

	}

	if (valid)
	{
		cout << "Its a palindrome!" << endl;
	}
	else
	{
		cout << "It's not a palindrome..." << endl;
	}

};

[vlad from moscow]

It is not a good approach. I think that function check shall not modify member word and shall have return type bool. I would declare it as

bool IsPalindrome() const;

[AbstractionAnon]

You have a problem with your loop at line 22.

valid is not tracking it's previous state. When you exit out of the loop, valid only has the state of the last comparison, not the state of all comparison upto and including the last. Line 22-25 should look like this:

    valid = true;  // Assume it's a palindrome to start
    for (int i = 0, p = length; p > i; i++, p--)
    {   if (toupper(word[i]) != toupper(word[p]))
        {   valid = false;
             break;   // no point in checking any further
         }
    }